asteris-llc/converge

Function expandSwitchMacro has 6 return statements (exceeds 4 allowed).

Open

func expandSwitchMacro(data []byte, current *source, n *parse.Node, g *graph.Graph) (*graph.Graph, error) {
    if !control.IsSwitchNode(n) {
        return g, nil
    }
    switchObj, err := control.NewSwitch(n, data)

Function loadKeyring has 6 return statements (exceeds 4 allowed).

Open

func loadKeyring(ks *Keystore) (openpgp.KeyRing, error) {
    var keyring openpgp.EntityList
    trustedKeys := make(map[string]*openpgp.Entity)

    for _, p := range []string{ks.SystemPath, ks.UserPath, ks.LocalPath} {

Method Printer.DrawNode has 6 return statements (exceeds 4 allowed).

Open

func (p *Printer) DrawNode(g *graph.Graph, id string) (pp.Renderable, error) {
    meta, ok := g.Get(id)
    if !ok {
        return pp.HiddenString(), nil
    }

Function TestNotifyTransform has 6 return statements (exceeds 4 allowed).

Open

func TestNotifyTransform(t *testing.T) {
    g := graph.New()
    g.Add(node.New("root", 1))

    doNothing := func(*node.Node, *graph.Graph) error { return nil }

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-mismatched", func(t *testing.T) {
            o := &owner.Ownership{UID: intRef(2), GID: intRef(2)}
            d, err := owner.NewOwnershipDiff(m, "foo", o)
            require.NoError(t, err)
            assert.True(t, d.Changes())

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when installation error", func(t *testing.T) {
        pkg := "foo1"
        runner := newRunner("", makeExitError("", 1))
        a := &apt.Manager{Sys: runner}
        _, err := a.InstallPackage(pkg)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-uid-match", func(t *testing.T) {
            o := &owner.Ownership{UID: intRef(1), GID: intRef(2)}
            d, err := owner.NewOwnershipDiff(m, "foo", o)
            require.NoError(t, err)
            assert.True(t, d.Changes())

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-gid-match", func(t *testing.T) {
            o := &owner.Ownership{UID: intRef(2), GID: intRef(1)}
            d, err := owner.NewOwnershipDiff(m, "foo", o)
            require.NoError(t, err)
            assert.True(t, d.Changes())

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when installation error", func(t *testing.T) {
        pkg := "foo1"
        runner := newRunner("", makeExitError("", 1))
        y := &rpm.YumManager{Sys: runner}
        _, err := y.InstallPackage(pkg)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        t.Run("when-matching", func(t *testing.T) {
            o := &owner.Ownership{UID: intRef(1), GID: intRef(1)}
            d, err := owner.NewOwnershipDiff(m, "foo", o)
            require.NoError(t, err)
            assert.False(t, d.Changes())

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when package never installed", func(t *testing.T) {
        pkg := "foo1"
        runner := newRunner("", makeExitError("", 1))
        a := &apt.Manager{Sys: runner}
        _, err := a.RemovePackage(pkg)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        t.Run("no uid", func(t *testing.T) {
            p := user.Preparer{GID: &testID, Username: "test", Name: "test", HomeDir: "tmp", State: user.StateAbsent}
            _, err := p.Prepare(context.Background(), &fr)

            assert.NoError(t, err)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (d.UIDs != nil) && d.UIDs[0] != d.UIDs[1] {
        uid := d.UIDs[idx]
        userName, err := usernameFromUID(d.p, show(uid))
        if err != nil {
            return show(err)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (d.GIDs != nil) && d.GIDs[0] != d.GIDs[1] {
        gid := d.GIDs[idx]
        groupName, err := groupnameFromGID(d.p, show(gid))
        if err != nil {
            return show(err)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func setUid() (string, error) {
    for i := 0; i <= maxUID; i++ {
        uid := strconv.Itoa(i)
        user, err := os.LookupId(uid)
        if err == nil && user.Username != currUsername {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func setGid() (string, error) {
    for i := 0; i <= maxGID; i++ {
        gid := strconv.Itoa(i)
        group, err := user.LookupGroupId(gid)
        if err == nil && group.Name != currName {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        t.Run("no group", func(t *testing.T) {
            p := user.Preparer{UID: &testID, Username: "test", Name: "test", HomeDir: "tmp", State: user.StateAbsent}
            _, err := p.Prepare(context.Background(), &fr)

            assert.NoError(t, err)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        assert.True(t, strings.Contains(u.fetchContents[0], expF[3]) || strings.Contains(u.fetchContents[1], expF[3]) || strings.Contains(u.fetchContents[2], expF[3]) || strings.Contains(u.fetchContents[3], expF[3]))

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        assert.True(t, strings.Contains(u.fetchContents[0], expF[0]) || strings.Contains(u.fetchContents[1], expF[0]) || strings.Contains(u.fetchContents[2], expF[0]) || strings.Contains(u.fetchContents[3], expF[0]))

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("no mkfs, no unit, only mount", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "xfs", false, false)
        _ = simpleApplySuccess(t, lvm)
        m.AssertNotCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")

• Read up
  Read up