Sign upLogin

badgeteam/Hatchery

View on GitHub
Star

Showing 536 of 536 total issues

Avoid using short method names like AddGitCommitIdFieldToProjects::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table('projects', function (Blueprint $table) {
            $table->string('git_commit_id')->nullable()->after('git');
        });
Severity: Minor
Found in database/migrations/2020_02_21_163350_add_git_commit_id_field_to_projects.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like CreateCategoriesTableAlterProjectsAddCategory::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::create(
            'categories',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2017_07_03_143514_create_categories_table_alter_projects_add_category.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AlterUsersAddEditorField::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'users',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2017_07_28_172959_alter_users_add_editor_field.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AlterProjectsAddLicense::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2022_06_24_210616_alter_projects_add_license.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like CreateWarningsTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::create(
            'warnings',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2019_09_18_173501_create_warnings_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AddSomeUniqueConstraints::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2020_03_19_101905_add_some_unique_constraints.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like MoveStatusToBadgeProjects::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        foreach (\App\Models\BadgeProject::all() as $bp) {
            $bp->status = $bp->project->getOriginal('status');
            $bp->save();
Severity: Minor
Found in database/migrations/2019_09_19_095351_move_status_to_badge_projects.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AlterUsersAddEmailVerifiedAt::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'users',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2022_04_06_030426_alter_users_add_email_verified_at.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AddPublicBoolToUsersTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table('users', function (Blueprint $table) {
            $table->boolean('public')->default(false)->after('editor');
        });
Severity: Minor
Found in database/migrations/2020_03_03_180724_add_public_bool_to_users_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AlterProjectAddRightsFlags::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2022_06_16_185859_alter_project_add_rights_flags.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AddShowProjectsToUsersTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table('users', function (Blueprint $table) {
            $table->boolean('show_projects')->default(true)->after('public');
        });
Severity: Minor
Found in database/migrations/2020_03_04_121435_add_show_projects_to_users_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $sitemap = Sitemap::create()
            ->add(
                Url::create('/')
Severity: Minor
Found in app/Console/Commands/GenerateSitemap.php - About 1 hr to fix

    Method projectJson has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function projectJson(string $slug): JsonResponse
    {
        /** @var Project|null $project */
        $project = Project::where('slug', $slug)->first();
        if ($project === null) {
    Severity: Minor
    Found in app/Http/Controllers/PublicController.php - About 1 hr to fix

      Method boot has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function boot(): void
    {
        parent::boot();

        static::creating(
      Severity: Minor
      Found in app/Models/Project.php - About 1 hr to fix

        Method execute has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function execute(string $command): int
    {
        $stdOut = $stdErr = '';
        $returnValue = 255;
        $fds = [
        Severity: Minor
        Found in app/Jobs/ProcessFile.php - About 1 hr to fix

          Method handle has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function handle(Git $git)
    {
        $version = $this->project->getUnpublishedVersion();

        try {
          Severity: Minor
          Found in app/Jobs/UpdateProject.php - About 1 hr to fix

            Method update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function update(FileUpdateRequest $request, File $file): RedirectResponse
    {
        try {
            $file->content = $request->file_content;
            $file->save();
            Severity: Minor
            Found in app/Http/Controllers/FilesController.php - About 1 hr to fix

              Method makeZip has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function makeZip(string $filename, Version $version): void
    {
        $zip = new PharData(public_path($filename));

        foreach ($version->files as $file) {
              Severity: Minor
              Found in app/Jobs/PublishProject.php - About 1 hr to fix

                Function returnProjectView has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function returnProjectView(Request $request, $projects, string $badge = '')
    {
        $category = '';
        if ($request->has('category')) {
            $category = Category::where('slug', $request->get('category'))->firstOrFail();
                Severity: Minor
                Found in app/Http/Controllers/PublicController.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
                Severity: Major
                Found in database/migrations/2020_03_04_121435_add_show_projects_to_users_table.php and 2 other locations - About 1 hr to fix
                database/migrations/2017_07_12_101551_alter_users_add_admin_boolean.php on lines 1..40
                database/migrations/2020_03_03_180724_add_public_bool_to_users_table.php on lines 1..34

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 102.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language