Sign upLogin

bergerx/kubectl-status

View on GitHub
Star

Showing 37 of 37 total issues

Function hasMapListAMatchingItem has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func hasMapListAMatchingItem(searchFor map[string]interface{}, typedMapListItem map[string]interface{}) bool {
    klog.V(5).InfoS("hasMapListAMatchingItem will search", "searchFor", searchFor, "typedMapListItem", typedMapListItem)
    if len(searchFor) == 0 {
        return false
    }
Severity: Minor
Found in pkg/plugin/template_functions_static.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isStatusConditionHealthy has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func isStatusConditionHealthy(condition map[string]interface{}) bool {
    switch {
    /*
        From https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties:
Severity: Minor
Found in pkg/plugin/template_functions_static.go - About 1 hr to fix

    Function hasMapListAMatchingItem has 9 return statements (exceeds 4 allowed).
    Open

    func hasMapListAMatchingItem(searchFor map[string]interface{}, typedMapListItem map[string]interface{}) bool {
    klog.V(5).InfoS("hasMapListAMatchingItem will search", "searchFor", searchFor, "typedMapListItem", typedMapListItem)
    if len(searchFor) == 0 {
        return false
    }
    Severity: Major
    Found in pkg/plugin/template_functions_static.go - About 55 mins to fix

      Function Run has 6 return statements (exceeds 4 allowed).
      Open

      func Run(f util.Factory, streams genericiooptions.IOStreams, args []string) error {
    klog.V(5).InfoS("All config settings", "settings", viper.AllSettings())
    if viper.Get("color") == "always" {
        color.NoColor = false
    } else if viper.Get("color") == "never" {
      Severity: Major
      Found in pkg/plugin/plugin.go - About 40 mins to fix

        Function runWatch has 6 return statements (exceeds 4 allowed).
        Open

        func runWatch(results *resource.Result, engine *renderEngine) error {
    color.HiYellow("\nPrinted all existing resource statuses, starting to watch. Switching to shallow mode during watch!\n\n")
    viper.Set("shallow", true)
    viper.Set("watching", true)
    klog.V(5).InfoS("Will run watch")
        Severity: Major
        Found in pkg/plugin/plugin.go - About 40 mins to fix

          Method renderEngine.mappingFor has 6 return statements (exceeds 4 allowed).
          Open

          func (e *renderEngine) mappingFor(resourceOrKindArg string) (*meta.RESTMapping, error) {
    fullySpecifiedGVR, groupResource := schema.ParseResourceArg(resourceOrKindArg)
    gvk := schema.GroupVersionKind{}
    restMapper, err := e.repo.ToRESTMapper()
    if err != nil {
          Severity: Major
          Found in pkg/plugin/render_engine.go - About 40 mins to fix

            Method RenderableObject.kubeGetUnifiedDiffString has 5 return statements (exceeds 4 allowed).
            Open

            func (r RenderableObject) kubeGetUnifiedDiffString(resourceOrKind, namespace, nameA, nameB string) (string, error) {
    controllerRevisionMapping, err := r.engine.mappingFor(resourceOrKind)
    if err != nil {
        klog.V(3).ErrorS(err, "failed to get mapping", "resourceOrKind", resourceOrKind)
        return "", err
            Severity: Major
            Found in pkg/plugin/template_functions_dynamic.go - About 35 mins to fix

              should replace count += 1 with count++
              Open

                      count += 1
              Severity: Minor
              Found in pkg/plugin/plugin.go by golint

              exported method RenderableObject.KubeGetIngressesMatchingService should have comment or be unexported
              Open

              func (r RenderableObject) KubeGetIngressesMatchingService(namespace, svcName string) (out []RenderableObject) {
              Severity: Minor
              Found in pkg/plugin/template_functions_dynamic.go by golint

              exported method RenderableObject.IncludeRenderableObject should have comment or be unexported
              Open

              func (r RenderableObject) IncludeRenderableObject(obj RenderableObject) (output string) {
              Severity: Minor
              Found in pkg/plugin/template_functions_static.go by golint

              exported method RenderableObject.Metadata should have comment or be unexported
              Open

              func (r RenderableObject) Metadata() (metadata map[string]interface{}) {
              Severity: Minor
              Found in pkg/plugin/renderable.go by golint

              if block ends with a return statement, so drop this else and outdent its block
              Open

                  } else {
              Severity: Minor
              Found in pkg/plugin/template_functions_static.go by golint

              exported method RenderableObject.KubeGet should have comment or be unexported
              Open

              func (r RenderableObject) KubeGet(namespace string, args ...string) (out []RenderableObject) {
              Severity: Minor
              Found in pkg/plugin/template_functions_dynamic.go by golint

              exported method RenderableObject.KubeGetNodeStatsSummary should have comment or be unexported
              Open

              func (r RenderableObject) KubeGetNodeStatsSummary(nodeName string) map[string]interface{} {
              Severity: Minor
              Found in pkg/plugin/template_functions_dynamic.go by golint

              exported method RenderableObject.Kind should have comment or be unexported
              Open

              func (r RenderableObject) Kind() (kind string) {
              Severity: Minor
              Found in pkg/plugin/renderable.go by golint

              exported method RenderableObject.Labels should have comment or be unexported
              Open

              func (r RenderableObject) Labels() (labels map[string]interface{}) {
              Severity: Minor
              Found in pkg/plugin/renderable.go by golint

              2: cannot find package "github.com/bergerx/kubectl-status/pkg/plugin" in any of:
              Open

                  "github.com/bergerx/kubectl-status/pkg/plugin"
              Severity: Minor
              Found in cmd/main.go by govet

              exported method ResourceRepo.ToRESTMapper should have comment or be unexported
              Open

              func (r *ResourceRepo) ToRESTMapper() (meta.RESTMapper, error) {
              Severity: Minor
              Found in pkg/input/input.go by golint

              exported method RenderableObject.Annotations should have comment or be unexported
              Open

              func (r RenderableObject) Annotations() (annotations map[string]interface{}) {
              Severity: Minor
              Found in pkg/plugin/renderable.go by golint

              exported method ResourceRepo.CLIQueryResults should have comment or be unexported
              Open

              func (r *ResourceRepo) CLIQueryResults(args []string) *resource.Result {
              Severity: Minor
              Found in pkg/input/input.go by golint
              Severity
              Category
              Status
              Source
              Language