Sign upLogin

bergerx/kubectl-status

View on GitHub
Star
pkg/plugin/template_functions_static.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function hasMapListAMatchingItem has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func hasMapListAMatchingItem(searchFor map[string]interface{}, typedMapListItem map[string]interface{}) bool {
    klog.V(5).InfoS("hasMapListAMatchingItem will search", "searchFor", searchFor, "typedMapListItem", typedMapListItem)
    if len(searchFor) == 0 {
        return false
    }
Severity: Minor
Found in pkg/plugin/template_functions_static.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isStatusConditionHealthy has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func isStatusConditionHealthy(condition map[string]interface{}) bool {
    switch {
    /*
        From https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties:
Severity: Minor
Found in pkg/plugin/template_functions_static.go - About 1 hr to fix

    Function hasMapListAMatchingItem has 9 return statements (exceeds 4 allowed).
    Open

    func hasMapListAMatchingItem(searchFor map[string]interface{}, typedMapListItem map[string]interface{}) bool {
    klog.V(5).InfoS("hasMapListAMatchingItem will search", "searchFor", searchFor, "typedMapListItem", typedMapListItem)
    if len(searchFor) == 0 {
        return false
    }
    Severity: Major
    Found in pkg/plugin/template_functions_static.go - About 55 mins to fix

      exported method RenderableObject.IncludeRenderableObject should have comment or be unexported
      Open

      func (r RenderableObject) IncludeRenderableObject(obj RenderableObject) (output string) {
      Severity: Minor
      Found in pkg/plugin/template_functions_static.go by golint

      if block ends with a return statement, so drop this else and outdent its block
      Open

          } else {
      Severity: Minor
      Found in pkg/plugin/template_functions_static.go by golint

      exported method RenderableObject.Include should have comment or be unexported
      Open

      func (r RenderableObject) Include(templateName string, data interface{}) (string, error) {
      Severity: Minor
      Found in pkg/plugin/template_functions_static.go by golint

      exported function DefaultDurationRound should have comment or be unexported
      Open

      func DefaultDurationRound() func(duration interface{}) string {
      Severity: Minor
      Found in pkg/plugin/template_functions_static.go by golint

      There are no issues that match your filters.

      Category
      Status