Sign upLogin

chrisandchris/passive-record-orm

View on GitHub
Star

Showing 161 of 161 total issues

Method handle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function handle(
        PdoStatement $statement,
        Entity $entity = null,
        \Closure $callAfter = null,
        array $mappingInfo = []
Severity: Minor
Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Model/ConcreteModel.php - About 1 hr to fix

    Method values has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function values(array $values = [])
    {
        if (is_array($values) && count($values) > 0) {
            $this->append('values');
    Severity: Minor
    Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  'comparison' => function (array $params) {
                $allowed = [
                    '<',
                    '>',
                    '<>',
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php on lines 76..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  'comparison'     => function (array $params) {
                $allowed = [
                    '<',
                    '>',
                    '<>',
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php on lines 90..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  'orderby'        => function (array $params) {
                if ($params['direction'] != 'asc' &&
                    $params['direction'] != 'desc'
                ) {
                    throw new MalformedQueryException('Unknown order type');
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php on lines 273..286

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  'orderby'    => function (array $params) {
                if ($params['direction'] != 'asc' &&
                    $params['direction'] != 'desc'
                ) {
                    throw new MalformedQueryException('Unknown order type');
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php on lines 304..317

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function implodeIdentifier has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function implodeIdentifier($identifier, $d)
    {
        // $identifier = 'database:table:field'
        if (!is_array($identifier) && strstr($identifier, ':') !== false) {
            return $d . implode($d . '.' . $d, explode(':', $identifier)) . $d;
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/AbstractBag.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function appendMultiple has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function appendMultiple($types)
    {
        if ($types instanceof Builder) {
            $types = $types->getStatement();
        } else {
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function minimizeBrace has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function minimizeBrace() {
        if (count($this->braces) === 0) {
            throw new MalformedQueryException(
                'You must open braces before closing them.'
            );
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/DefaultParser.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function allowAppend has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function allowAppend()
    {
        // for speed, we first check only the last index
        // if the last index says we should append, we check all other indexes
        // any of the index must be false
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              PdoFactory $pdoFactory,
        RowMapperFactory $mapperFactory,
        ErrorHandler $errorHandler,
        BuilderFactory $builderFactory,
        ContainerInterface $container = null,
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Model/ModelDependencyProvider.php - About 45 mins to fix

        Function getEntityFiller has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getEntityFiller() : \Closure
    {
        return
            function (
                Entity &$entity,
        Severity: Minor
        Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Mapper/RowMapper.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function __construct($system, $host, $port = null, $name = null, $user = null, $password = null)
        Severity: Minor
        Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoLayer.php - About 45 mins to fix

          Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function run(
        \Closure $process,
        $eventClass = null,
        $eventData = null
    ) {
          Severity: Minor
          Found in src/ChrisAndChris/Common/RowMapperBundle/Services/BusinessProcess.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getDsn has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getDsn($system, $host, $port, $database, $username, $password)
          Severity: Minor
          Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoLayer.php - About 45 mins to fix

            Method bindColumn has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function bindColumn($column, &$param, $type = null, $maxlen = null, $driverdata = null)
            Severity: Minor
            Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoStatement.php - About 35 mins to fix

              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $query,
        $parameters = [],
        $calcRowCapable = false,
        array $mappingInfo = null,
        bool $readOnly = false
              Severity: Minor
              Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/SqlQuery.php - About 35 mins to fix

                Method bindParam has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $parameter,
        &$variable,
        $data_type = PDO::PARAM_STR,
        $length = null,
        $driver_options = null
                Severity: Minor
                Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoStatement.php - About 35 mins to fix

                  Method getPgDsn has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private function getPgDsn($host, $port, $database, $username, $password)
                  Severity: Minor
                  Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoLayer.php - About 35 mins to fix

                    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function __construct($source = null, $target = null, $sourceField = null, $targetField = null, $alias = null)
                    Severity: Minor
                    Found in src/ChrisAndChris/Common/RowMapperBundle/Entity/Mapping/Relation.php - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language