Sign upLogin

cloudfoundry/cf-k8s-controllers

View on GitHub
Star

Showing 26 of 26 total issues

Method ImageRepository.UploadSourceImage has 6 arguments (exceeds 5 allowed). Consider refactoring.
Open

func (r *ImageRepository) UploadSourceImage(ctx context.Context, authInfo authorization.Info, imageRef string, srcReader io.Reader, spaceGUID string, tags ...string) (string, error) {
Severity: Minor
Found in api/repositories/image_repository.go - About 35 mins to fix

    Function NewRoute has 6 arguments (exceeds 5 allowed). Consider refactoring.
    Open

        serverURL url.URL,
    routeRepo CFRouteRepository,
    domainRepo CFDomainRepository,
    appRepo CFAppRepository,
    spaceRepo CFSpaceRepository,
    Severity: Minor
    Found in api/handlers/route.go - About 35 mins to fix

      Function NewStateCollector has 6 arguments (exceeds 5 allowed). Consider refactoring.
      Open

          appRepo shared.CFAppRepository,
    domainRepo shared.CFDomainRepository,
    processRepo shared.CFProcessRepository,
    routeRepo shared.CFRouteRepository,
    serviceInstanceRepo shared.CFServiceInstanceRepository,
      Severity: Minor
      Found in api/actions/manifest/state_collector.go - About 35 mins to fix

        Function NewOrg has 6 arguments (exceeds 5 allowed). Consider refactoring.
        Open

        func NewOrg(apiBaseURL url.URL, orgRepo CFOrgRepository, domainRepo CFDomainRepository, requestValidator RequestValidator, userCertificateExpirationWarningDuration time.Duration, defaultDomainName string) *Org {
        Severity: Minor
        Found in api/handlers/org.go - About 35 mins to fix

          Function NewApplier has 6 arguments (exceeds 5 allowed). Consider refactoring.
          Open

              appRepo shared.CFAppRepository,
    domainRepo shared.CFDomainRepository,
    processRepo shared.CFProcessRepository,
    routeRepo shared.CFRouteRepository,
    serviceInstanceRepo shared.CFServiceInstanceRepository,
          Severity: Minor
          Found in api/actions/manifest/applier.go - About 35 mins to fix

            Method Validator.ValidateUpdate has 9 return statements (exceeds 8 allowed).
            Open

            func (v *Validator) ValidateUpdate(ctx context.Context, oldObj, obj runtime.Object) (admission.Warnings, error) {
    route, ok := obj.(*korifiv1alpha1.CFRoute)
    if !ok {
        return nil, apierrors.NewBadRequest(fmt.Sprintf("expected a CFRoute but got a %T", obj))
    }
            Severity: Major
            Found in controllers/webhooks/networking/routes/validator.go - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language