Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/jetstream/plugins/cfapppush/pushapp.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method CFPushApp.Init has a Cognitive Complexity of 25 (exceeds 8 allowed). Consider refactoring.
Open

func (c *CFPushApp) Init(appDir string, manifestPath string, overrides CFPushAppOverrides) error {

    // App name
    if len(overrides.Name) > 0 {
        c.pushCommand.OptionalArgs = flag.OptionalAppName{
Severity: Minor
Found in src/jetstream/plugins/cfapppush/pushapp.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CFPushApp.Init has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *CFPushApp) Init(appDir string, manifestPath string, overrides CFPushAppOverrides) error {

    // App name
    if len(overrides.Name) > 0 {
        c.pushCommand.OptionalArgs = flag.OptionalAppName{
Severity: Minor
Found in src/jetstream/plugins/cfapppush/pushapp.go - About 1 hr to fix

    Method CFPushApp.Run has 7 return statements (exceeds 4 allowed).
    Open

    func (c *CFPushApp) Run(msgSender DeployAppMessageSender, clientWebsocket *websocket.Conn) error {

    // Get a CF Config
    config, err := configv3.LoadConfig()
    if err != nil {
    Severity: Major
    Found in src/jetstream/plugins/cfapppush/pushapp.go - About 45 mins to fix

      Method CFPushApp.Init has 6 return statements (exceeds 4 allowed).
      Open

      func (c *CFPushApp) Init(appDir string, manifestPath string, overrides CFPushAppOverrides) error {

    // App name
    if len(overrides.Name) > 0 {
        c.pushCommand.OptionalArgs = flag.OptionalAppName{
      Severity: Major
      Found in src/jetstream/plugins/cfapppush/pushapp.go - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status