cloudfoundry/stratos

View on GitHub
src/jetstream/plugins/yamlgenerated/main.go

Summary

Maintainability
A
1 hr
Test Coverage

Method GeneratedEndpointPlugin.Connect has 6 return statements (exceeds 4 allowed).
Open

func (gep GeneratedEndpointPlugin) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
    params := new(interfaces.LoginToCNSIParams)
    err := interfaces.BindOnce(params, ec)
    if err != nil {
        return nil, false, err
Severity: Major
Found in src/jetstream/plugins/yamlgenerated/main.go - About 40 mins to fix

    Function createPluginForEndpointType has 6 return statements (exceeds 4 allowed).
    Wontfix

    func createPluginForEndpointType(endpointType string) GeneratedEndpointPlugin {
        log.Debugf("Generating plugin %s", endpointType)
        gep := GeneratedEndpointPlugin{}
        gep.endpointType = endpointType
        gep.subTypes = make(map[string]pluginConfig)
    Severity: Major
    Found in src/jetstream/plugins/yamlgenerated/main.go - About 40 mins to fix

      Function MakePluginsFromConfig has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

      func MakePluginsFromConfig() {
          log.Debug("MakePluginsFromConfig")
      
          var config []pluginConfig
      
      
      Severity: Minor
      Found in src/jetstream/plugins/yamlgenerated/main.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method GeneratedEndpointPlugin.fetchUsername has 5 return statements (exceeds 4 allowed).
      Wontfix

      func (gep GeneratedEndpointPlugin) fetchUsername(config pluginConfig, cnsiRecord *interfaces.CNSIRecord, tr *interfaces.TokenRecord) string {
          if len(config.UserInfoAPI) == 0 || len(config.UserInfoPath) == 0 {
              // Not configured
              return defaultTokenUsername
          }
      Severity: Major
      Found in src/jetstream/plugins/yamlgenerated/main.go - About 35 mins to fix

        Function getJSONValue has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Wontfix

        func getJSONValue(data map[string]interface{}, valuePath string) string {
            parts := strings.Split(valuePath, ".")
            value := data[parts[0]]
            if value != nil {
                if len(parts) == 1 {
        Severity: Minor
        Found in src/jetstream/plugins/yamlgenerated/main.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status