Sign upLogin

connectbot/sshlib

View on GitHub
Star

Showing 412 of 412 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.trilead.ssh2.signature;
 
import com.trilead.ssh2.log.Logger;
import com.trilead.ssh2.packets.TypesReader;
import com.trilead.ssh2.packets.TypesWriter;
Severity: Major
Found in src/main/java/com/trilead/ssh2/signature/RSASHA512Verify.java and 1 other location - About 6 hrs to fix
src/main/java/com/trilead/ssh2/signature/RSASHA256Verify.java on lines 1..124

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.trilead.ssh2.signature;
 
import com.trilead.ssh2.log.Logger;
import com.trilead.ssh2.packets.TypesReader;
import com.trilead.ssh2.packets.TypesWriter;
Severity: Major
Found in src/main/java/com/trilead/ssh2/signature/RSASHA256Verify.java and 1 other location - About 6 hrs to fix
src/main/java/com/trilead/ssh2/signature/RSASHA512Verify.java on lines 1..124

ChannelManager has 46 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ChannelManager implements MessageHandler
{
    private static final Logger log = Logger.getLogger(ChannelManager.class);
 
    private final HashMap<String, X11ServerData> x11_magic_cookies = new HashMap<>();
Severity: Minor
Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 6 hrs to fix

    File AuthenticationManager.java has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

     
    package com.trilead.ssh2.auth;
     
    import com.trilead.ssh2.crypto.keys.Ed25519PrivateKey;
    import com.trilead.ssh2.crypto.keys.Ed25519PublicKey;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 6 hrs to fix

      Method hostnameMatches has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

          private final boolean hostnameMatches(String[] hostpatterns, String hostname)
          {
              boolean isMatch = false;
              boolean negate = false;
       
       
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 5 hrs to fix

      File ECDSASHA2Verify.java has 405 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
       * Copyright 2014 Kenny Root
       *
       * Redistribution and use in source and binary forms, with or without
       * modification, are permitted provided that the following conditions
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/signature/ECDSASHA2Verify.java - About 5 hrs to fix

        SFTPv3Client has 42 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class SFTPv3Client
        {
            final Connection conn;
            final Session sess;
            final PrintStream debug;
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 5 hrs to fix

          Method authenticatePublicKey has 136 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
                      throws IOException
              {
                  PrivateKey privateKey = null;
                  PublicKey publicKey = null;
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

            Method authenticatePublicKey has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
            Open

                public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
                        throws IOException
                {
                    PrivateKey privateKey = null;
                    PublicKey publicKey = null;
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            package com.trilead.ssh2.packets;
             
            import java.io.IOException;
             
            /**
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/packets/PacketChannelOpenConfirmation.java and 1 other location - About 4 hrs to fix
            src/main/java/com/trilead/ssh2/packets/PacketChannelOpenFailure.java on lines 1..66

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            package com.trilead.ssh2.packets;
             
            import java.io.IOException;
             
            /**
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/packets/PacketChannelOpenFailure.java and 1 other location - About 4 hrs to fix
            src/main/java/com/trilead/ssh2/packets/PacketChannelOpenConfirmation.java on lines 1..66

            Method run has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                public void run()
                {
                    try
                    {
                        /* Send Open Confirmation */
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/channel/RemoteX11AcceptThread.java - About 4 hrs to fix

            Method run has 111 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void run()
                {
                    try
                    {
                        /* Send Open Confirmation */
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/channel/RemoteX11AcceptThread.java - About 4 hrs to fix

              Method close has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void close(Throwable cause, boolean useDisconnectPacket)
                  {
                      if (!useDisconnectPacket)
                      {
                          /* OK, hard shutdown - do not aquire the semaphore,
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 4 hrs to fix

              Method getChannelData has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public int getChannelData(Channel c, boolean extended, byte[] target, int off, int len) throws IOException
                  {
                      int copylen = 0;
                      int increment = 0;
                      int remoteID = 0;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 4 hrs to fix

              Method waitForCondition has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public int waitForCondition(Channel c, long timeout, int condition_mask)
                  {
                      long end_time = 0;
                      boolean end_time_set = false;
               
               
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 4 hrs to fix

              Method decode has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static byte[] decode(char[] message) throws IOException
                  {
                      byte buff[] = new byte[4];
                      byte dest[] = new byte[message.length];
               
               
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/Base64.java - About 4 hrs to fix

              Method parsePEM has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static final PEMStructure parsePEM(char[] pem) throws IOException
                  {
                      PEMStructure ps = new PEMStructure();
               
                      String line = null;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 4 hrs to fix

              Method addIdentity has 101 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void addIdentity(TypesReader tr, boolean checkConstraints) {
                      try
                      {
                          if (failWhenLocked())
                              return;
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 4 hrs to fix

                Method run has 96 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
                    public void run()
                    {
                        try
                        {
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language