Sign upLogin

connectbot/sshlib

View on GitHub
Star

Showing 412 of 412 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.trilead.ssh2.signature;

import com.trilead.ssh2.log.Logger;
import com.trilead.ssh2.packets.TypesReader;
import com.trilead.ssh2.packets.TypesWriter;
Severity: Major
Found in src/main/java/com/trilead/ssh2/signature/RSASHA512Verify.java and 1 other location - About 6 hrs to fix
src/main/java/com/trilead/ssh2/signature/RSASHA256Verify.java on lines 1..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 400.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package com.trilead.ssh2.signature;

import com.trilead.ssh2.log.Logger;
import com.trilead.ssh2.packets.TypesReader;
import com.trilead.ssh2.packets.TypesWriter;
Severity: Major
Found in src/main/java/com/trilead/ssh2/signature/RSASHA256Verify.java and 1 other location - About 6 hrs to fix
src/main/java/com/trilead/ssh2/signature/RSASHA512Verify.java on lines 1..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 400.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

ChannelManager has 46 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ChannelManager implements MessageHandler
{
    private static final Logger log = Logger.getLogger(ChannelManager.class);

    private final HashMap<String, X11ServerData> x11_magic_cookies = new HashMap<>();
Severity: Minor
Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 6 hrs to fix

    File AuthenticationManager.java has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    
package com.trilead.ssh2.auth;

import com.trilead.ssh2.crypto.keys.Ed25519PrivateKey;
import com.trilead.ssh2.crypto.keys.Ed25519PublicKey;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 6 hrs to fix

      Method hostnameMatches has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

          private final boolean hostnameMatches(String[] hostpatterns, String hostname)
    {
        boolean isMatch = false;
        boolean negate = false;
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File ECDSASHA2Verify.java has 405 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Copyright 2014 Kenny Root
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/signature/ECDSASHA2Verify.java - About 5 hrs to fix

        SFTPv3Client has 42 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class SFTPv3Client
{
    final Connection conn;
    final Session sess;
    final PrintStream debug;
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 5 hrs to fix

          Method authenticatePublicKey has 136 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
            throws IOException
    {
        PrivateKey privateKey = null;
        PublicKey publicKey = null;
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

            Method authenticatePublicKey has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
            Open

                public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
            throws IOException
    {
        PrivateKey privateKey = null;
        PublicKey publicKey = null;
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            package com.trilead.ssh2.packets;

import java.io.IOException;

/**
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/packets/PacketChannelOpenFailure.java and 1 other location - About 4 hrs to fix
            src/main/java/com/trilead/ssh2/packets/PacketChannelOpenConfirmation.java on lines 1..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 293.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            package com.trilead.ssh2.packets;

import java.io.IOException;

/**
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/packets/PacketChannelOpenConfirmation.java and 1 other location - About 4 hrs to fix
            src/main/java/com/trilead/ssh2/packets/PacketChannelOpenFailure.java on lines 1..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 293.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method run has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                public void run()
    {
        try
        {
            /* Send Open Confirmation */
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/channel/RemoteX11AcceptThread.java - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has 111 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void run()
    {
        try
        {
            /* Send Open Confirmation */
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/channel/RemoteX11AcceptThread.java - About 4 hrs to fix

              Method close has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void close(Throwable cause, boolean useDisconnectPacket)
    {
        if (!useDisconnectPacket)
        {
            /* OK, hard shutdown - do not aquire the semaphore,
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getChannelData has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public int getChannelData(Channel c, boolean extended, byte[] target, int off, int len) throws IOException
    {
        int copylen = 0;
        int increment = 0;
        int remoteID = 0;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method waitForCondition has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public int waitForCondition(Channel c, long timeout, int condition_mask)
    {
        long end_time = 0;
        boolean end_time_set = false;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method parsePEM has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static final PEMStructure parsePEM(char[] pem) throws IOException
    {
        PEMStructure ps = new PEMStructure();

        String line = null;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method decode has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static byte[] decode(char[] message) throws IOException
    {
        byte buff[] = new byte[4];
        byte dest[] = new byte[message.length];
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/Base64.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method addIdentity has 101 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void addIdentity(TypesReader tr, boolean checkConstraints) {
        try
        {
            if (failWhenLocked())
                return;
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 4 hrs to fix

                Method run has 96 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
    public void run()
    {
        try
        {
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language