Sign upLogin

connectbot/sshlib

View on GitHub
Star

Showing 412 of 412 total issues

Method generateWorkingKey has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected int[] generateWorkingKey(boolean encrypting, byte[] key, int off)
    {
        int[] newKey = new int[32];
        boolean[] pc1m = new boolean[56], pcr = new boolean[56];
 
 
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 3 hrs to fix

Method receiveFiles has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private void receiveFiles(Session sess, String[] files, String target) throws IOException
    {
        byte[] buffer = new byte[8192];
 
        OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
Severity: Minor
Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 3 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String canonicalPath(String path) throws IOException
    {
        int req_id = generateNextRequestID();
 
        TypesWriter tw = new TypesWriter();
Severity: Major
Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java and 1 other location - About 3 hrs to fix
src/main/java/com/trilead/ssh2/SFTPv3Client.java on lines 482..529

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String readLink(String path) throws IOException
    {
        int req_id = generateNextRequestID();
 
        TypesWriter tw = new TypesWriter();
Severity: Major
Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java and 1 other location - About 3 hrs to fix
src/main/java/com/trilead/ssh2/SFTPv3Client.java on lines 658..705

Method receiveLoop has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void receiveLoop() throws IOException
    {
        byte[] msg = new byte[35004];
 
        while (true)
Severity: Major
Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 3 hrs to fix

    Method addIdentity has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private void addIdentity(TypesReader tr, boolean checkConstraints) {
            try
            {
                if (failWhenLocked())
                    return;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 3 hrs to fix

    Method sendMessage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public void sendMessage(byte[] message, int off, int len, int padd) throws IOException
        {
            if (padd < 4)
                padd = 4;
            else if (padd > 64)
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/transport/TransportConnection.java - About 3 hrs to fix

    Method receiveFiles has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private void receiveFiles(Session sess, OutputStream[] targets) throws IOException
        {
            byte[] buffer = new byte[8192];
     
            OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 3 hrs to fix

    Method scanDirectory has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        private final Vector scanDirectory(byte[] handle) throws IOException
        {
            Vector files = new Vector();
     
            while (true)
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 3 hrs to fix

    Method sendData has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public void sendData(Channel c, byte[] buffer, int pos, int len) throws IOException
        {
            while (len > 0)
            {
                int thislen = 0;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 3 hrs to fix

    Method handleMessage has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void handleMessage(byte[] msg, int msglen) throws IOException
        {
            if (msg == null)
            {
                if (log.isEnabled())
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 3 hrs to fix

      Method connect has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public synchronized ConnectionInfo connect(ServerHostKeyVerifier verifier, int connectTimeout, int kexTimeout)
                  throws IOException
          {
              final class TimeoutState
              {
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/Connection.java - About 3 hrs to fix

        Method desFunc has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected void desFunc(int[] wKey, byte[] in, int inOff, byte[] out, int outOff)
            {
                int work, right, left;
         
                left = (in[inOff + 0] & 0xff) << 24;
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 3 hrs to fix

          Method getChannelData has 79 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public int getChannelData(Channel c, boolean extended, byte[] target, int off, int len) throws IOException
              {
                  int copylen = 0;
                  int increment = 0;
                  int remoteID = 0;
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 3 hrs to fix

            Method msgChannelOpen has 79 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void msgChannelOpen(byte[] msg, int msglen) throws IOException
                {
                    TypesReader tr = new TypesReader(msg, 0, msglen);
             
                    tr.readByte(); // skip packet type
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 3 hrs to fix

              Method createAttrs has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                  private byte[] createAttrs(SFTPv3FileAttributes attr)
                  {
                      TypesWriter tw = new TypesWriter();
               
                      int attrFlags = 0;
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 3 hrs to fix

              Method openConnection has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                  @Override
                  public Socket openConnection(String hostname, int port, int connectTimeout) throws IOException {
                      Socket sock = new Socket();
               
                      InetAddress addr = InetAddress.getByName(proxyHost);
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/HTTPProxyData.java - About 3 hrs to fix

              Method openConnection has 77 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @Override
                  public Socket openConnection(String hostname, int port, int connectTimeout) throws IOException {
                      Socket sock = new Socket();
               
                      InetAddress addr = InetAddress.getByName(proxyHost);
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/HTTPProxyData.java - About 3 hrs to fix

                Method parsePEM has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static final PEMStructure parsePEM(char[] pem) throws IOException
                    {
                        PEMStructure ps = new PEMStructure();
                 
                        String line = null;
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 3 hrs to fix

                  Method decryptData has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private static byte[] decryptData(byte[] data, byte[] pw, byte[] salt, int rounds, String algo) throws IOException
                      {
                          BlockCipher bc;
                          int keySize;
                   
                   
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language