Sign upLogin

connectbot/sshlib

View on GitHub
Star

Showing 415 of 415 total issues

Method run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        public void run()
        {
            byte[] buff = new byte[8192];
 
            while (true)
Severity: Minor
Found in src/main/java/com/trilead/ssh2/StreamGobbler.java - About 2 hrs to fix

Method decryptData has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private static byte[] decryptData(byte[] data, byte[] pw, byte[] salt, int rounds, String algo) throws IOException
    {
        BlockCipher bc;
        int keySize;
 
 
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 2 hrs to fix

File BlowFish.java has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

 
package com.trilead.ssh2.crypto.cipher;
 
/*
 * This file was shamelessly taken from the Bouncy Castle Crypto package.
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/cipher/BlowFish.java - About 2 hrs to fix

    Method sendMessage has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void sendMessage(byte[] message, int off, int len, int padd) throws IOException
        {
            if (padd < 4)
                padd = 4;
            else if (padd > 64)
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/transport/TransportConnection.java - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void msgChannelSuccess(byte[] msg, int msglen) throws IOException
          {
              if (msglen != 5)
                  throw new IOException("SSH_MSG_CHANNEL_SUCCESS message has wrong size (" + msglen + ")");
       
       
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 1 other location - About 2 hrs to fix
      src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1499..1519

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void msgChannelFailure(byte[] msg, int msglen) throws IOException
          {
              if (msglen != 5)
                  throw new IOException("SSH_MSG_CHANNEL_FAILURE message has wrong size (" + msglen + ")");
       
       
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 1 other location - About 2 hrs to fix
      src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1477..1497

      Method decode has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static byte[] decode(char[] message) throws IOException
          {
              byte buff[] = new byte[4];
              byte dest[] = new byte[message.length];
       
       
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/crypto/Base64.java - About 2 hrs to fix

        Method run has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
            public void run()
            {
                try
                {
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

         
        package com.trilead.ssh2.packets;
         
        import java.io.IOException;
         
         
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/packets/PacketKexDhGexReply.java and 1 other location - About 2 hrs to fix
        src/main/java/com/trilead/ssh2/packets/PacketKexDHReply.java on lines 1..53

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        package com.trilead.ssh2.packets;
         
        import java.io.IOException;
         
        /**
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/packets/PacketKexDHReply.java and 1 other location - About 2 hrs to fix
        src/main/java/com/trilead/ssh2/packets/PacketKexDhGexReply.java on lines 1..56

        Method run has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void run()
            {
                try
                {
                    while (true)
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/channel/StreamForwarder.java - About 2 hrs to fix

          Method generateWorkingKey has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected int[] generateWorkingKey(boolean encrypting, byte[] key, int off)
              {
                  int[] newKey = new int[32];
                  boolean[] pc1m = new boolean[56], pcr = new boolean[56];
           
           
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 2 hrs to fix

            TransportManager has 24 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public class TransportManager
            {
                private static final Logger log = Logger.getLogger(TransportManager.class);
             
                class HandlerEntry
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

              Method filterHostKeyTypes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void filterHostKeyTypes(CryptoWishList cwl) {
                      if (verifier instanceof ExtendedServerHostKeyVerifier) {
                          ExtendedServerHostKeyVerifier extendedVerifier = (ExtendedServerHostKeyVerifier) verifier;
               
                          List<String> knownAlgorithms = extendedVerifier.getKnownKeyAlgorithmsForHost(hostname, port);
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 2 hrs to fix

              Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void run()
                  {
                      try
                      {
                          while (true)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/StreamForwarder.java - About 2 hrs to fix

              File DES.java has 274 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

               
              package com.trilead.ssh2.crypto.cipher;
               
              /*
               * This file is based on the 3DES implementation from the Bouncy Castle Crypto package.
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 2 hrs to fix

                Method close has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void close(Throwable cause, boolean useDisconnectPacket)
                    {
                        if (!useDisconnectPacket)
                        {
                            /* OK, hard shutdown - do not aquire the semaphore,
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

                  Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public void run()
                      {
                          try
                          {
                              cm.registerThread(this);
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/channel/LocalAcceptThread.java - About 2 hrs to fix

                    Method msgChannelRequest has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public void msgChannelRequest(byte[] msg, int msglen) throws IOException
                        {
                            TypesReader tr = new TypesReader(msg, 0, msglen);
                     
                            tr.readByte(); // skip packet type
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 2 hrs to fix

                    Method connect has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public synchronized ConnectionInfo connect(ServerHostKeyVerifier verifier, int connectTimeout, int kexTimeout)
                                throws IOException
                        {
                            final class TimeoutState
                            {
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/Connection.java - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language