Sign upLogin

connectbot/sshlib

View on GitHub
Star

Showing 412 of 412 total issues

Method run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        public void run()
        {
            byte[] buff = new byte[8192];

            while (true)
Severity: Minor
Found in src/main/java/com/trilead/ssh2/StreamGobbler.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decryptData has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private static byte[] decryptData(byte[] data, byte[] pw, byte[] salt, int rounds, String algo) throws IOException
    {
        BlockCipher bc;
        int keySize;
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/PEMDecoder.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File BlowFish.java has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open


package com.trilead.ssh2.crypto.cipher;

/*
 * This file was shamelessly taken from the Bouncy Castle Crypto package.
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/cipher/BlowFish.java - About 2 hrs to fix

    Method sendMessage has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void sendMessage(byte[] message, int off, int len, int padd) throws IOException
    {
        if (padd < 4)
            padd = 4;
        else if (padd > 64)
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/transport/TransportConnection.java - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void msgChannelSuccess(byte[] msg, int msglen) throws IOException
    {
        if (msglen != 5)
            throw new IOException("SSH_MSG_CHANNEL_SUCCESS message has wrong size (" + msglen + ")");
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 1 other location - About 2 hrs to fix
      src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1499..1519

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 177.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void msgChannelFailure(byte[] msg, int msglen) throws IOException
    {
        if (msglen != 5)
            throw new IOException("SSH_MSG_CHANNEL_FAILURE message has wrong size (" + msglen + ")");
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 1 other location - About 2 hrs to fix
      src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1477..1497

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 177.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method decode has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static byte[] decode(char[] message) throws IOException
    {
        byte buff[] = new byte[4];
        byte dest[] = new byte[message.length];
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/crypto/Base64.java - About 2 hrs to fix

        Method run has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    public void run()
    {
        try
        {
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        package com.trilead.ssh2.packets;

import java.io.IOException;

/**
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/packets/PacketKexDHReply.java and 1 other location - About 2 hrs to fix
        src/main/java/com/trilead/ssh2/packets/PacketKexDhGexReply.java on lines 1..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 174.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        
package com.trilead.ssh2.packets;

import java.io.IOException;
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/packets/PacketKexDhGexReply.java and 1 other location - About 2 hrs to fix
        src/main/java/com/trilead/ssh2/packets/PacketKexDHReply.java on lines 1..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 174.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method run has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void run()
    {
        try
        {
            while (true)
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/channel/StreamForwarder.java - About 2 hrs to fix

          Method generateWorkingKey has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected int[] generateWorkingKey(boolean encrypting, byte[] key, int off)
    {
        int[] newKey = new int[32];
        boolean[] pc1m = new boolean[56], pcr = new boolean[56];
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 2 hrs to fix

            TransportManager has 24 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public class TransportManager
{
    private static final Logger log = Logger.getLogger(TransportManager.class);

    class HandlerEntry
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

              Method filterHostKeyTypes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void filterHostKeyTypes(CryptoWishList cwl) {
        if (verifier instanceof ExtendedServerHostKeyVerifier) {
            ExtendedServerHostKeyVerifier extendedVerifier = (ExtendedServerHostKeyVerifier) verifier;

            List<String> knownAlgorithms = extendedVerifier.getKnownKeyAlgorithmsForHost(hostname, port);
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void run()
    {
        try
        {
            while (true)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/StreamForwarder.java - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File DES.java has 274 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              
package com.trilead.ssh2.crypto.cipher;

/*
 * This file is based on the 3DES implementation from the Bouncy Castle Crypto package.
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/cipher/DES.java - About 2 hrs to fix

                Method close has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void close(Throwable cause, boolean useDisconnectPacket)
    {
        if (!useDisconnectPacket)
        {
            /* OK, hard shutdown - do not aquire the semaphore,
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

                  Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public void run()
    {
        try
        {
            cm.registerThread(this);
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/channel/LocalAcceptThread.java - About 2 hrs to fix

                    Method msgChannelRequest has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public void msgChannelRequest(byte[] msg, int msglen) throws IOException
    {
        TypesReader tr = new TypesReader(msg, 0, msglen);

        tr.readByte(); // skip packet type
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method connect has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public synchronized ConnectionInfo connect(ServerHostKeyVerifier verifier, int connectTimeout, int kexTimeout)
            throws IOException
    {
        final class TimeoutState
        {
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/Connection.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language