Sign upLogin

cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
Star

Showing 899 of 899 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static function isIssueValid(Issue $issue)
    {
        $summary = $issue->getSummary();
        $valid = !blank($summary);
        $status = $issue->getStatus();
Severity: Minor
Found in services/Jira.service.php and 1 other location - About 35 mins to fix
services/GitHub.service.php on lines 46..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!empty($webhooks)) {
            $oldID = $webhooks[0]['id'];
            // get current webhook projects
            $projects = explode(',', $webhooks[0]['repository_id']);
            // remove old webhook
Severity: Minor
Found in services/Jira.service.php and 1 other location - About 35 mins to fix
services/Jira.service.php on lines 408..416

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static function isIssueValid(Issue $issue)
    {
        $summary = $issue->getSummary();
        $valid = !blank($summary);
        $status = $issue->getStatus();
Severity: Minor
Found in services/GitHub.service.php and 1 other location - About 35 mins to fix
services/Jira.service.php on lines 51..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!empty($webhooks)) {
            $oldID = $webhooks[0]['id'];
            // get current webhook projects
            $projects = explode(',', $webhooks[0]['repository_id']);
            // remove old webhook
Severity: Minor
Found in services/Jira.service.php and 1 other location - About 35 mins to fix
services/Jira.service.php on lines 354..362

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getAdditionalDataHTML has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAdditionalDataHTML()
    {
        $this->getFromService();
        $data = [];
        if (!empty($this->assignee)) {
Severity: Minor
Found in classes/Issue.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Opening brace of a class must be on the line after the definition
Open

class linksyntax_plugin_issuelinks_test extends DokuWikiTest {
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpcodesniffer

Method name "general_plugin_issuelinks_test::test_plugin_conf" is not in camel caps format
Open

    public function test_plugin_conf()
Severity: Minor
Found in _test/general.test.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class util_plugin_issuelinks_test extends DokuWikiTest {
Severity: Minor
Found in _test/util.test.php by phpcodesniffer

Method name "linksyntax_plugin_issuelinks_test::test_jiralink_oldrev" is not in camel caps format
Open

    public function test_jiralink_oldrev() {
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpcodesniffer

Method name "util_plugin_issuelinks_test::parseHTTPLinkHeaders_testdata" is not in camel caps format
Open

    public static function parseHTTPLinkHeaders_testdata() {
Severity: Minor
Found in _test/util.test.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in _test/general.test.php by phpcodesniffer

Method name "linksyntax_plugin_issuelinks_test::test_jiralink" is not in camel caps format
Open

    public function test_jiralink() {
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpcodesniffer

Method name "general_plugin_issuelinks_test::test_plugininfo" is not in camel caps format
Open

    public function test_plugininfo()
Severity: Minor
Found in _test/general.test.php by phpcodesniffer

Method name "linksyntax_plugin_issuelinks_test::test_jiralink_moresyntax" is not in camel caps format
Open

    public function test_jiralink_moresyntax() {
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpcodesniffer

Method name "util_plugin_issuelinks_test::test_parseHTTPLinkHeaders" is not in camel caps format
Open

    public function test_parseHTTPLinkHeaders($linkHeader, $expected_links, $msg) {
Severity: Minor
Found in _test/util.test.php by phpcodesniffer

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in services/Jira.service.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in services/GitLab.service.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in services/GitHub.service.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in services/GitHub.service.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in services/GitLab.service.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language