cse112-sp20/Team-Potato

View on GitHub
src/components/Menu.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    /** Add those to the current state
     * addGroupModel: decide whether the add group modal pop oopen or not
     * activeTabs: the tabs being active currently on chrome browser
     * tabGroups: the tabGroups the user has created
Severity: Major
Found in src/components/Menu.jsx - About 5 hrs to fix

    File Menu.jsx has 377 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * @fileOverview This file is the menu class which contains tabgroups,
     *               activetabs, and savedtabs. Here included functionalities from
     *               constrcutor, component render, create a new tabgroup, and so on
     *
    Severity: Minor
    Found in src/components/Menu.jsx - About 5 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                  if (i !== deleteIndex) {
                    updatedTabs.push({
                      title: tabGroups[deleteGroup].tabs[i].title,
                      url: tabGroups[deleteGroup].tabs[i].url,
                      stored: tabGroups[deleteGroup].tabs[i].stored,
      Severity: Major
      Found in src/components/Menu.jsx - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            } else if (e.target.attributes.getNamedItem('droppable').value !== 'true') {
              /** if not droppable, do nothing */
              e.preventDefault();
              e.dataTransfer.effectAllowed = 'none';
              e.dataTransfer.dropEffect = 'none';
        Severity: Minor
        Found in src/components/Menu.jsx and 1 other location - About 35 mins to fix
        src/components/Menu.jsx on lines 167..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (
              e.target === undefined ||
              e.target.attributes.getNamedItem('droppable') === null
            ) {
              /** if invalid, do nothing */
        Severity: Minor
        Found in src/components/Menu.jsx and 1 other location - About 35 mins to fix
        src/components/Menu.jsx on lines 175..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status