Sign upLogin

dbudwin/RoboHome-Web

View on GitHub
Star

Showing 76 of 76 total issues

Line exceeds 120 characters; contains 123 characters
Open

        $this->assertJsonResponse($response, json_encode(['error' => "Action '$action' not implemented for device"]), 400);
Severity: Minor
Found in tests/Unit/DeviceActionInfo/DeviceActionInfoBrokerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 135 characters
Open

            'header' => $this->createHeader($request, DeviceActions::actionToConfirmationName($action), 'Alexa.ConnectedHome.Control'),
Severity: Minor
Found in app/Http/Controllers/API/DevicesController.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

        $rfDevice = $this->makeRFDevice(self::$faker->randomNumber(), self::$faker->randomNumber(), self::$faker->randomNumber());
Severity: Minor
Found in tests/Unit/DeviceActionInfo/DeviceActionInfoBrokerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 126 characters
Open

Route::post('/devices/{action}/{publicDeviceId}', 'Web\DevicesController@handleControlRequest')->name('handleControlRequest');
Severity: Minor
Found in routes/web.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

        return $this->redirectToDevicesWithMessage($request, FlashMessageLevels::SUCCESS, "Device '$name' was successfully added!");
Severity: Minor
Found in app/Http/Controllers/Web/DevicesController.php by phpcodesniffer

Line exceeds 120 characters; contains 142 characters
Open

        return $this->redirectToDevicesWithMessage($request, FlashMessageLevels::SUCCESS, "Device '$device->name' was successfully updated!");
Severity: Minor
Found in app/Http/Controllers/Web/DevicesController.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

    private function redirectToDevicesWithMessage(Request $request, string $flashLevel, string $message): RedirectResponse
Severity: Minor
Found in app/Http/Controllers/Web/DevicesController.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

Route::post('/devices/control/{action}', 'API\DevicesController@control')->name('control')->middleware('scope:control', 'apiVerifyUserOwnsDevice');
Severity: Minor
Found in routes/api.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

            $this->assertEquals($expectedSpecificDevice->attributesToArray(), $actualSpecificDevice->attributesToArray());
Severity: Minor
Found in tests/Unit/Model/DeviceTest.php by phpcodesniffer

Line exceeds 120 characters; contains 159 characters
Open

                ->whenAvailable('#edit-device-modal', function ($modal) use ($newDeviceName, $newDeviceDescription, $newOnCode, $newOffCode, $newPulseLength) {
Severity: Minor
Found in tests/Browser/DevicesTest.php by phpcodesniffer

Line exceeds 120 characters; contains 158 characters
Open

    private function loginAndAddDevice(Browser $browser, string $deviceName, string $deviceDescription, int $onCode, int $offCode, int $pulseLength) : Browser
Severity: Minor
Found in tests/Browser/DevicesTest.php by phpcodesniffer

Line exceeds 120 characters; contains 148 characters
Open

            $this->assertHtmlAttributesMatchSpecificDeviceProperties($specificDevice, $attributeNames, $attributeValues, $specificDeviceProperties);
Severity: Minor
Found in tests/Unit/Model/DeviceTest.php by phpcodesniffer

Line exceeds 120 characters; contains 179 characters
Open

    private function assertHtmlAttributesMatchSpecificDeviceProperties(Model $specificDevice, array $attributeNames, array $attributeValues, array $specificDeviceProperties): void
Severity: Minor
Found in tests/Unit/Model/DeviceTest.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

        $this->mockDeviceRepository->shouldReceive('getForPublicId')->with(Mockery::on(function (Uuid $argument) use ($device) {
Severity: Minor
Found in tests/Unit/Controller/API/DevicesControllerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 123 characters
Open

    private function infoForDeviceAction(IActionInfo $deviceInfoClass, Model $specificDevice, string $action): JsonResponse
Severity: Minor
Found in app/DeviceActionInfo/DeviceActionInfoBroker.php by phpcodesniffer

Line exceeds 120 characters; contains 139 characters
Open

            ->whenAvailable('#add-device-modal', function ($modal) use ($deviceName, $deviceDescription, $onCode, $offCode, $pulseLength) {
Severity: Minor
Found in tests/Browser/DevicesTest.php by phpcodesniffer

Line exceeds 120 characters; contains 145 characters
Open

    public function testHtmlDataAttributesForSpecificDeviceProperties_GivenDeviceAddedToDatabase_AttributesMatchNameAndValueOfAddedDevice(): void
Severity: Minor
Found in tests/Unit/Model/DeviceTest.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

        $mockDeviceRepository->shouldReceive('getForPublicId')->with(Mockery::on(function (Uuid $argument) use ($device) {
Severity: Minor
Found in tests/Unit/Controller/Web/DevicesControllerTest.php by phpcodesniffer

Rule doesn't have all its properties in alphabetical order.
Open

.notfound .notfound-404 h1 {
Severity: Minor
Found in public/css/404.css by csslint

Heading (h2) has already been defined.
Open

    .notfound h2 {
Severity: Minor
Found in public/css/404.css by csslint
Severity
Category
Status
Source
Language