Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Start context description with 'when', 'with', or 'without'.
Open

    context "updated file card" do
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

      expect(subject.image.size).to eq 6836
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

      expect(subject.image.small.size).to be < 6000
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

        .to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Use let instead of an instance variable.
Open

      item_names_args = @context ? { context: @context } : {}
Severity: Minor
Found in mod/collection/spec/set/all/item_spec.rb by rubocop

Empty example group detected.
Open

describe Card::Set::Self::Alerts do
Severity: Minor
Found in mod/layout/spec/set/self/alerts_spec.rb by rubocop

Missing top-level class documentation comment.
Open

class StopFollowLink < FollowLink
Severity: Minor
Found in mod/follow/set/all/follow/stop_follow_link.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer annotated tokens (like %<foo>s</foo>) over unannotated tokens (like %s).
Open

        "%s/%s/%s" % [local_url_base(opts), file_dir, full_filename(url_filename)]
Severity: Minor
Found in mod/carrierwave/lib/carrier_wave/file_card_uploader/path.rb by rubocop

Use a consistent style for named format string tokens.

Note: unannotated style cop only works for strings which are passed as arguments to those methods: sprintf, format, %. The reason is that unannotated format is very similar to encoded URLs or Date/Time formatting strings.

Example: EnforcedStyle: annotated (default)

# bad
format('%{greeting}', greeting: 'Hello')
format('%s', 'Hello')

# good
format('%<greeting>s', greeting: 'Hello')</greeting>

Example: EnforcedStyle: template

# bad
format('%<greeting>s', greeting: 'Hello')
format('%s', 'Hello')

# good
format('%{greeting}', greeting: 'Hello')</greeting>

Example: EnforcedStyle: unannotated

# bad
format('%<greeting>s', greeting: 'Hello')
format('%{greeting}', 'Hello')

# good
format('%s', 'Hello')</greeting>

Name your test subject if you need to reference it explicitly.
Open

          expect(File).to be_exist(subject.file.path)
Severity: Minor
Found in mod/carrierwave/spec/set/type/file_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

      expect(subject.file.url)
Severity: Minor
Found in mod/carrierwave/spec/set/type/file_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

        .to eq "~#{subject.id}/#{subject.last_action_id}.jpg"
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

        act_summary = subject.format.render_content_changes
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

        expect(subject.image.original_filename).to eq "rails.gif"
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

          .to eq "/files/~#{subject.id}/#{subject.last_action_id}-original.gif"
Severity: Minor
Found in mod/carrierwave/spec/set/type/image_spec.rb by rubocop

The first argument to describe should be the class or module being tested.
Open

describe "#bucket config" do
Severity: Minor
Found in mod/carrierwave/spec/set/type/file/bucket_config_spec.rb by rubocop

Missing top-level class documentation comment.
Open

    class ProcLayout < Layout
Severity: Minor
Found in mod/layout/lib/card/layout/proc_layout.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class UnknownLayout < Layout
Severity: Minor
Found in mod/layout/lib/card/layout/unknown_layout.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not stub your test subject.
Open

      allow(format).to receive(:view_setting)
Severity: Minor
Found in mod/layout/spec/set/all/process_layout/explicit_modal_wrapper_spec.rb by rubocop

Script file stop_follow_link.rb doesn't have execute permission.
Open

#! no set module
Severity: Minor
Found in mod/follow/set/all/follow/stop_follow_link.rb by rubocop

Use let instead of an instance variable.
Open

      @account.password_card.update!(content: "new Pas5word!")
Severity: Minor
Found in mod/account/spec/set/right/account_spec.rb by rubocop
Severity
Category
Status
Source
Language