Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 668 of 700 total issues

Spec path should end with card_controller*locationtestfromoldintegration*_spec.rb.
Open

RSpec.describe CardController, "location test from old integration" do
Severity: Minor
Found in decko/spec/controllers/location_spec.rb by rubocop

Missing top-level module documentation comment.
Open

      module Tag
Severity: Minor
Found in card/config/initializers/02_patches/kaminari.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Remove debugger entry point save_and_open_page.
Open

  save_and_open_page
Severity: Minor
Found in decko/features/step_definitions/web_steps.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/history_steps.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/attachment_steps.rb by rubocop

Missing top-level class documentation comment.
Open

    class CucumberCommand < Cardio::Command::CommandBase
Severity: Minor
Found in decko/lib/decko/commands/cucumber_command.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Spec path should end with /content/diff*_spec.rb.
Open

RSpec.describe Card::Content::Diff do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

The second argument to describe should be the method being tested. '#instance' or '.class'.
Open

RSpec.describe ActiveJob::Arguments, "serialize patch" do
Severity: Minor
Found in card/spec/config/initializers/patches/active_job_spec.rb by rubocop
Severity
Category
Status
Source
Language