decko-commons/decko

View on GitHub

Showing 666 of 699 total issues

Missing top-level module documentation comment.
Open

module ClassMethods
Severity: Minor
Found in mod/account/set/all/account.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use let instead of an instance variable.
Open

      expect(@mail.body.raw_source).to include("Welcome Big Bad Sheep")

Use let instead of an instance variable.
Open

      expect(@signup.type_id).to eq(Card::SignupID)

Use let instead of an instance variable.
Open

      expect(@signup.format.invitation?).to be(true)

Beware of using before(:all) as it may cause state to leak between tests. If you are using rspec-rails, and use_transactional_fixtures is enabled, then records created in before(:all) are not automatically rolled back.
Open

    before(:all) do

Empty example group detected.
Open

describe Card::Set::Right::Status do

Start context description with 'when', 'with', or 'without'.
Open

    context "for Joe User" do

Start context description with 'when', 'with', or 'without'.
Open

  context "<User>+*email" do

Use let instead of an instance variable.
Open

      @format = @card.format

Use let instead of an instance variable.
Open

          @email_card.update! content: "QuIrE@example.com"

Use let instead of an instance variable.
Open

        expect(@signup.account.status).to eq("unverified")

Use let instead of an instance variable.
Open

        expect(@parties)

Use let instead of an instance variable.
Open

        Card::Auth.as_bot { r1_members.items = [@joe_user_card.id] }

Start context description with 'when', 'with', or 'without'.
Open

    context "blank password" do

Empty example group detected.
Open

describe Card::Set::Right::Salt do

Freeze mutable objects assigned to constants.
Open

  OK4KEY_RE = '\p{Word}\*'
Severity: Minor
Found in cardname/lib/cardname.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Start context description with 'when', 'with', or 'without'.
Open

    context "do not stabilize" do
Severity: Minor
Found in cardname/spec/lib/cardname_spec.rb by rubocop

Use let instead of an instance variable.
Open

      @account = @signup.account

Use let instead of an instance variable.
Open

      expect(@signup.type_id).to eq(Card::SignupID)

Use let instead of an instance variable.
Open

      expect(@account.email).to eq("wolf@decko.org")
Severity
Category
Status
Source
Language