Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Empty example group detected.
Open

describe Card::Set::Right::Default do
Severity: Minor
Found in mod/content/spec/set/right/default_spec.rb by rubocop

Empty line detected around arguments.
Open


    :comment,      # TODO: refactor in favor of card[add], card[drop]
Severity: Minor
Found in card/lib/card.rb by rubocop

This cops checks if empty lines exist around the arguments of a method invocation.

Example:

# bad
do_something(
  foo

)

process(bar,

        baz: qux,
        thud: fred)

some_method(

  [1,2,3],
  x: y
)

# good
do_something(
  foo
)

process(bar,
        baz: qux,
        thud: fred)

some_method(
  [1,2,3],
  x: y
)

Use match? instead of =~ when MatchData is not used.
Open

          name = pattern.to_name.absolute(name) if pattern =~ /_\w+/
Severity: Minor
Found in card/lib/card/query/card_query/run.rb by rubocop

In Ruby 2.4, String#match?, Regexp#match? and Symbol#match? have been added. The methods are faster than match. Because the methods avoid creating a MatchData object or saving backref. So, when MatchData is not used, use match? instead of match.

Example:

# bad
def foo
  if x =~ /re/
    do_something
  end
end

# bad
def foo
  if x.match(/re/)
    do_something
  end
end

# bad
def foo
  if /re/ === x
    do_something
  end
end

# good
def foo
  if x.match?(/re/)
    do_something
  end
end

# good
def foo
  if x =~ /re/
    do_something(Regexp.last_match)
  end
end

# good
def foo
  if x.match(/re/)
    do_something($~)
  end
end

# good
def foo
  if /re/ === x
    do_something($~)
  end
end

Missing top-level class documentation comment.
Open

    class JsonFormat < DataFormat
Severity: Minor
Found in mod/format/lib/card/format/json_format.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class JsFormat < Format
Severity: Minor
Found in mod/format/lib/card/format/js_format.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class CsvFormat < Format
Severity: Minor
Found in mod/format/lib/card/format/csv_format.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Empty example group detected.
Open

describe Card::Format::EmailHtmlFormat do
Severity: Minor
Found in mod/format/spec/format/email_html_format_spec.rb by rubocop

Missing top-level module documentation comment.
Open

  module Bootstrapper
Severity: Minor
Found in mod/bootstrap/lib/card/bootstrapper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

The use of eval is a serious security risk.
Open

        eval to_s, TOPLEVEL_BINDING, @content_path, offset
Severity: Minor
Found in card/lib/cardio/mod/module_template.rb by rubocop

This cop checks for the use of Kernel#eval and Binding#eval.

Example:

# bad

eval(something)
binding.eval(something)

Empty example group detected.
Open

describe Card::Format::TextFormat do
Severity: Minor
Found in mod/format/spec/format/text_format_spec.rb by rubocop

Do not suppress exceptions.
Open

      rescue SystemCallError
Severity: Minor
Found in card/lib/cardio/script_loader.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Name your test subject if you need to reference it explicitly.
Open

        assert_view_select subject, 'ins[class="diffins diff-added"]',
Severity: Minor
Found in mod/history/spec/set/all/history_spec.rb by rubocop

Missing top-level module documentation comment.
Open

module OverrideCodeFile
Severity: Minor
Found in mod/bootstrap/set/abstract/bootstrap_code_file.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class BadAddress < UserError
Severity: Minor
Found in card/lib/card/error.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

When using method_missing, fall back on super.
Open

      def method_missing method_name, *args, &block
        # return super unless @context.respond_to? method_name
        if block_given?
          @context.send(method_name, *args, &block)
        else
Severity: Minor
Found in mod/bootstrap/lib/card/bootstrap/delegate.rb by rubocop

This cop checks for the presence of method_missing without also defining respond_to_missing? and falling back on super.

Example:

#bad
def method_missing(name, *args)
  # ...
end

#good
def respond_to_missing?(name, include_private)
  # ...
end

def method_missing(name, *args)
  # ...
  super
end

Put prepend mixins in separate statements.
Open

      prepend { tag :prepend, "prepend-class" }
Severity: Minor
Found in mod/bootstrap/spec/bootstrap_builder_spec.rb by rubocop

This cop checks for grouping of mixins in class and module bodies. By default it enforces mixins to be placed in separate declarations, but it can be configured to enforce grouping them in one declaration.

Example: EnforcedStyle: separated (default)

# bad
class Foo
  include Bar, Qox
end

# good
class Foo
  include Qox
  include Bar
end

Example: EnforcedStyle: grouped

# bad
class Foo
  extend Bar
  extend Qox
end

# good
class Foo
  extend Qox, Bar
end

Variable @name used in void context.
Open

        @name
Severity: Minor
Found in card/lib/card/name/all.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Missing top-level class documentation comment.
Open

      class QueryReference < Reference
Severity: Minor
Found in mod/content/lib/card/content/chunk/query_reference.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Replace class var @@variant_methods with a class instance var.
Open

      @@variant_methods = %i[capitalize singularize pluralize titleize
Severity: Minor
Found in card/lib/card/name/name_variants.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Start context description with 'when', 'with', or 'without'.
Open

  context "syntax parsing" do
Severity: Minor
Found in mod/content/spec/card/content/chunk/query_reference_spec.rb by rubocop
Severity
Category
Status
Source
Language