Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Start context description with 'when', 'with', or 'without'.
Open

    context "card with account" do
Severity: Minor
Found in card/mod/core/spec/set/all/trash_spec.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

    context "(search)" do
Severity: Minor
Found in card/mod/core/spec/set/all/initialize_spec.rb by rubocop

Trailing whitespace detected.
Open

          See https://rspec.info/features/3-12/rspec-core/command-line/ or
Severity: Minor
Found in card/lib/cardio/command/rspec_command/parser.rb by rubocop

The use of eval is a serious security risk.
Open

            eval(
Severity: Minor
Found in card/lib/cardio/mod/load_strategy/set_binding_magic.rb by rubocop

This cop checks for the use of Kernel#eval and Binding#eval.

Example:

# bad

eval(something)
binding.eval(something)

Missing top-level module documentation comment.
Open

    module Clause
Severity: Minor
Found in card/lib/card/query/clause.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Trailing whitespace detected.
Open

  #
Severity: Minor
Found in mod/edit/set/all/form_buttons.rb by rubocop

Missing top-level class documentation comment.
Open

      class HostUri < Uri
Severity: Minor
Found in mod/content/lib/card/content/chunk/uri.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

      class Reference < Abstract
Severity: Minor
Found in mod/content/lib/card/content/chunk/reference.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use let instead of an instance variable.
Open

        @bt.type = "Phrase"
Severity: Minor
Found in mod/content/spec/set/all/templating_spec.rb by rubocop

Use let instead of an instance variable.
Open

      jb = @jb.refresh true
Severity: Minor
Found in mod/content/spec/set/all/templating_spec.rb by rubocop

Don't repeat descriptions within an example group.
Open

  it "one_line_content is rendered as type + raw" do
Severity: Minor
Found in mod/content/spec/set/right/structure_spec.rb by rubocop

Replace class var @@options with a class instance var.
Open

@@options = { compound_only: true }
Severity: Minor
Found in card/mod/core/set_pattern/05_rstar.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Use let instead of an instance variable.
Open

      expect(@hat.type_id).to eq(@type.id)
Severity: Minor
Found in card/mod/core/spec/set/all/type_spec.rb by rubocop

Use let instead of an instance variable.
Open

      expect(@hat.type_card).to eq(@type)
Severity: Minor
Found in card/mod/core/spec/set/all/type_spec.rb by rubocop

Pass __FILE__ and __LINE__ to eval method, as they are used by backtraces.
Open

            eval(
              "[ #{part} , #{part}.module_eval('binding') ]",
              b
            )
Severity: Minor
Found in card/lib/cardio/mod/load_strategy/set_binding_magic.rb by rubocop

This cop checks eval method usage. eval can receive source location metadata, that are filename and line number. The metadata is used by backtraces. This cop recommends to pass the metadata to eval method.

Example:

# bad
eval <<-RUBY
  def do_something
  end
RUBY

# bad
C.class_eval <<-RUBY
  def do_something
  end
RUBY

# good
eval <<-RUBY, binding, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY

# good
C.class_eval <<-RUBY, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY

The use of eval is a serious security risk.
Open

          eval "#{set_module}.module_eval ::File.read('#{abs_path}'), '#{abs_path}'",
Severity: Minor
Found in card/lib/cardio/mod/load_strategy/set_binding_magic.rb by rubocop

This cop checks for the use of Kernel#eval and Binding#eval.

Example:

# bad

eval(something)
binding.eval(something)

Missing top-level module documentation comment.
Open

  module Version
Severity: Minor
Found in card/lib/cardio/version.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class PreferenceCache < Cache
Severity: Minor
Found in card/lib/card/rule/preference_cache.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Empty example group detected.
Open

describe Card::Format::CsvFormat do
Severity: Minor
Found in mod/format/spec/format/csv_format_spec.rb by rubocop

Missing top-level class documentation comment.
Open

  class TableHelper
Severity: Minor
Found in mod/bootstrap/set/all/bootstrap/table.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language