Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Name your test subject if you need to reference it explicitly.
Open

      expect(subject.content).to eq '{"name":"YYY"}'
Severity: Minor
Found in mod/search/spec/set/type/search_type_spec.rb by rubocop

Missing top-level module documentation comment.
Open

module ClassMethods
Severity: Minor
Found in card/mod/core/set/all/states.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use let instead of an instance variable.
Open

      expect(@hat.type_code).to eq(nil)
Severity: Minor
Found in card/mod/core/spec/set/all/type_spec.rb by rubocop

Variable Cache used in void context.
Open

  Card::Cache # trigger autoload
Severity: Minor
Found in card/lib/card.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Variable Chunk used in void context.
Open

    Chunk # trigger autoload
Severity: Minor
Found in card/lib/card/content.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Use let instead of an instance variable.
Open

      expect(@a.format._render(:raw)).to eq("{{A}}")
Severity: Minor
Found in mod/format/spec/set/all/base_spec.rb by rubocop

Empty example group detected.
Open

describe Card::Format::FileFormat do
Severity: Minor
Found in mod/format/spec/format/file_format_spec.rb by rubocop

Missing top-level module documentation comment.
Open

    module BasicTags
Severity: Minor
Found in mod/bootstrap/lib/card/bootstrap/basic_tags.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

  class BuilderTest < Card::Bootstrap::Component
Severity: Minor
Found in mod/bootstrap/spec/bootstrap_builder_spec.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Name your test subject if you need to reference it explicitly.
Open

        subject.bs_form do
Severity: Minor
Found in mod/bootstrap/spec/bootstrap/component/form_spec.rb by rubocop

Use let instead of an instance variable.
Open

      Card::Content.new(@content, Card.new(type: "Search")).find_chunks(:QueryReference)
Severity: Minor
Found in mod/content/spec/card/content/chunk/query_reference_spec.rb by rubocop

Use let instead of an instance variable.
Open

        @bt.content = "Tomorrow"
Severity: Minor
Found in mod/content/spec/set/all/templating_spec.rb by rubocop

Empty example group detected.
Open

RSpec.describe Card::Set::Self::Recent do
Severity: Minor
Found in mod/search/spec/set/self/recent_spec.rb by rubocop

Add an empty line after magic comments.
Open

require_relative "card/lib/cardio/version"
Severity: Minor
Found in decko_gem.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Missing top-level class documentation comment.
Open

    class XmlFormat < DataFormat
Severity: Minor
Found in mod/format/lib/card/format/xml_format.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Empty example group detected.
Open

describe Card::Format::RssFormat do
Severity: Minor
Found in mod/format/spec/format/rss_format_spec.rb by rubocop

Missing top-level class documentation comment.
Open

      class Form < Component
Severity: Minor
Found in mod/bootstrap/lib/card/bootstrap/component/form.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

      class ViewStub < Abstract
Severity: Minor
Found in mod/content/lib/card/content/chunk/view_stub.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use let instead of an instance variable.
Open

      jb = @jb.refresh true
Severity: Minor
Found in mod/content/spec/set/all/templating_spec.rb by rubocop

Pass __FILE__ and __LINE__ to eval method, as they are used by backtraces.
Open

          eval "#{set_module}.module_eval ::File.read('#{abs_path}'), '#{abs_path}'",
               module_path_binding(set_module)
Severity: Minor
Found in card/lib/cardio/mod/load_strategy/set_binding_magic.rb by rubocop

This cop checks eval method usage. eval can receive source location metadata, that are filename and line number. The metadata is used by backtraces. This cop recommends to pass the metadata to eval method.

Example:

# bad
eval <<-RUBY
  def do_something
  end
RUBY

# bad
C.class_eval <<-RUBY
  def do_something
  end
RUBY

# good
eval <<-RUBY, binding, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY

# good
C.class_eval <<-RUBY, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY
Severity
Category
Status
Source
Language