Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 661 of 695 total issues

Useless assignment to variable - backtrace.
Open

      backtrace = @example_locations["#{parent.description} #{example_name}"]
Severity: Minor
Found in decko/spec/javascripts/support/jasmine_config.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Start context description with 'when', 'with', or 'without'.
Open

  context "text format" do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

  context "pointer format" do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

Missing top-level module documentation comment.
Open

    module Relation
Severity: Minor
Found in card/config/initializers/02_patches/active_record.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [96/90]
Open

  # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
Severity: Minor
Found in card/config/environments/production.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/account_steps.rb by rubocop

Missing top-level class documentation comment.
Open

    class CucumberCommand < Cardio::Command::CommandBase
Severity: Minor
Found in decko/lib/decko/commands/cucumber_command.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Start context description with 'when', 'with', or 'without'.
Open

      context "called on Symbol" do
Severity: Minor
Found in card/spec/config/initializers/core_extensions_spec.rb by rubocop

Name your test subject if you need to reference it explicitly.
Open

          expect(subject.id).to eq Card::LogoID
Severity: Minor
Found in card/spec/config/initializers/core_extensions_spec.rb by rubocop

Remove debugger entry point binding.pry.
Open

    binding.pry
Severity: Minor
Found in decko/features/support/debugger.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/wait_steps.rb by rubocop

Missing top-level class documentation comment.
Open

class RenderTest < ActionDispatch::PerformanceTest
Severity: Minor
Found in decko/test/performance/render_test.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

        class Flagger
Severity: Minor
Found in decko/lib/decko/commands/cucumber_command/parser.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Start context description with 'when', 'with', or 'without'.
Open

    context "jpg" do
Severity: Minor
Found in decko/spec/controllers/files_spec.rb by rubocop

The second argument to describe should be the method being tested. '#instance' or '.class'.
Open

RSpec.describe CardController, "location test from old integration" do
Severity: Minor
Found in decko/spec/controllers/location_spec.rb by rubocop

Remove debugger entry point binding.pry.
Open

    binding.pry
Severity: Minor
Found in decko/features/support/debugger.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Missing top-level class documentation comment.
Open

  class Commands < Cardio::Command
Severity: Minor
Found in decko/lib/decko/commands.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

The second argument to describe should be the method being tested. '#instance' or '.class'.
Open

RSpec.describe ActiveJob::Arguments, "serialize patch" do
Severity: Minor
Found in card/spec/config/initializers/patches/active_job_spec.rb by rubocop

Missing top-level module documentation comment.
Open

      module AbstractAdapter
Severity: Minor
Found in card/config/initializers/02_patches/active_record.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [125/90]
Open

  #  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$})   { |m| Dir[File.join("**/#{m[1]}.feature")][0] || 'spec/acceptance' }
Severity: Minor
Found in decko/Guardfile by rubocop
Severity
Category
Status
Source
Language