Sign upLogin

decko-commons/decko

View on GitHub
Star

Showing 667 of 699 total issues

Start context description with 'when', 'with', or 'without'.
Open

    context "jpg" do
Severity: Minor
Found in decko/spec/controllers/files_spec.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

  context "raw format" do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

Missing top-level module documentation comment.
Open

    module Relation
Severity: Minor
Found in card/config/initializers/02_patches/active_record.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [138/90]
Open

  # callback(:run_on_modifications_begin) { puts "<script>document.body.innerHTML = '';</script>" } # use js to clear textmate's html view
Severity: Minor
Found in decko/Guardfile by rubocop

Remove debugger entry point debugger.
Open

    debugger
Severity: Minor
Found in decko/features/support/debugger.rb by rubocop

This cop checks for calls to debugger or pry.

Example:

# bad (ok during development)

# using pry
def some_method
  binding.pry
  do_something
end

Example:

# bad (ok during development)

# using byebug
def some_method
  byebug
  do_something
end

Example:

# good

def some_method
  do_something
end

Prefer have_received for setting message expectations. Setup store as a spy using allow or instance_spy.
Open

      expect(store).to receive(:write).with("#{prefix}/foo", "val")
Severity: Minor
Found in card/spec/card/cache_spec.rb by rubocop

Replace class var @@demark_enable with a class instance var.
Open

      @@demark_enable = true
Severity: Minor
Found in card/config/initializers/internationalization.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Missing top-level module documentation comment.
Open

    module Transformers
Severity: Minor
Found in card/config/initializers/internationalization.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/web_steps.rb by rubocop

Missing top-level class documentation comment.
Open

    class TestCase
Severity: Minor
Found in decko/test/test_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Name your test subject if you need to reference it explicitly.
Open

          expect(subject.key).to eq(:logo.cardname.key)
Severity: Minor
Found in card/spec/config/initializers/core_extensions_spec.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/history_steps.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/card_content_steps.rb by rubocop

Variable Card used in void context.
Open

  Card
Severity: Minor
Found in decko/test/performance/render_test.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Missing top-level module documentation comment.
Open

module Decko
Severity: Minor
Found in decko/lib/decko.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer have_received for setting message expectations. Setup store as a spy using allow or instance_spy.
Open

      expect(store).to receive(:delete).with("#{prefix}/foo")
Severity: Minor
Found in card/spec/card/cache_spec.rb by rubocop

Spec path should end with active_job/arguments*serializepatch*_spec.rb.
Open

RSpec.describe ActiveJob::Arguments, "serialize patch" do
Severity: Minor
Found in card/spec/config/initializers/patches/active_job_spec.rb by rubocop

Re-enable Lint/AmbiguousRegexpLiteral cop with # rubocop:enable after disabling it.
Open

# rubocop:disable Lint/AmbiguousRegexpLiteral
Severity: Minor
Found in decko/features/step_definitions/account_steps.rb by rubocop

Start context description with 'when', 'with', or 'without'.
Open

  context "text format" do
Severity: Minor
Found in card/spec/card/diff_spec.rb by rubocop

The second argument to describe should be the method being tested. '#instance' or '.class'.
Open

RSpec.describe ActiveJob::Arguments, "serialize patch" do
Severity: Minor
Found in card/spec/config/initializers/patches/active_job_spec.rb by rubocop
Severity
Category
Status
Source
Language