decko-commons/decko

View on GitHub

Showing 661 of 695 total issues

Start context description with 'when', 'with', or 'without'.
Open

  context "comment addition" do

Start context description with 'when', 'with', or 'without'.
Open

  context "signup (without approval)" do

Use let instead of an instance variable.
Open

      expect(@account.password.length).to be > 10 # encrypted

Use let instead of an instance variable.
Open

        @signup.update! trigger: :approve_with_verification

Use let instead of an instance variable.
Open

        expect(@signup.type_id).to eq(Card::SignupID)

Use let instead of an instance variable.
Open

      @card.update! "+*email" => "schmoe@admin.com", trigger: :send_reset_password_token

Beware of using before(:all) as it may cause state to leak between tests. If you are using rspec-rails, and use_transactional_fixtures is enabled, then records created in before(:all) are not automatically rolled back.
Open

    before(:all) do

Use let instead of an instance variable.
Open

        @email_card.update content: "joe@user.com"

Start context description with 'when', 'with', or 'without'.
Open

    context "A+B+C" do
Severity: Minor
Found in cardname/spec/lib/cardname_spec.rb by rubocop

Use let instead of an instance variable.
Open

    @card.delete

Use let instead of an instance variable.
Open

      expect(@card.errors[:email].first).to match(/not recognized/)

Start context description with 'when', 'with', or 'without'.
Open

    context "update" do

Use let instead of an instance variable.
Open

    edit_view = @card.format.render_edit

Use let instead of an instance variable.
Open

      expect(@mail.to).to eq([@email])

Start context description with 'when', 'with', or 'without'.
Open

    context "stabilize" do
Severity: Minor
Found in cardname/spec/lib/cardname_spec.rb by rubocop

Use let instead of an instance variable.
Open

      expect(@account.salt).not_to eq("")

Name your test subject if you need to reference it explicitly.
Open

        expect(subject.match(/Sign up/)).to be_truthy

Use let instead of an instance variable.
Open

      @card.update! "+*email" => "joe@admin.com",

Use let instead of an instance variable.
Open

      @card.update! "+*email" => "joe@admin.com",

Use let instead of an instance variable.
Open

      expect(@format.render_raw).to match(/denied/)
Severity
Category
Status
Source
Language