Showing 118 of 118 total issues
Expected 1 space after FOREACH keyword; 0 found Open
foreach($aliases as $uri => $alias) {
- Exclude checks
Ordered list item prefix Open
2. Use `properties.yml`:
- Read upRead up
- Exclude checks
MD029 - Ordered list item prefix
Tags: ol
Aliases: ol-prefix
Parameters: style ("one", "ordered"; default "one")
This rule is triggered on ordered lists that do not either start with '1.' or do not have a prefix that increases in numerical order (depending on the configured style, which defaults to 'one').
Example valid list if the style is configured as 'one':
1. Do this.
1. Do that.
1. Done.
Example valid list if the style is configured as 'ordered':
1. Do this.
2. Do that.
3. Done.
Lists should be surrounded by blank lines Open
- We assume the value of `$config_directories['sync']` is relative to the web
- Read upRead up
- Exclude checks
MD032 - Lists should be surrounded by blank lines
Tags: bullet, ul, ol, blank_lines
Aliases: blanks-around-lists
This rule is triggered when lists (of any kind) are either not preceded or not followed by a blank line:
Some text
* Some
* List
1. Some
2. List
Some text
To fix this, ensure that all lists have a blank line both before and after (except where the block is at the beginning or end of the document):
Some text
* Some
* List
1. Some
2. List
Some text
Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse lists that don't have blank lines before and after them.
Note: List items without hanging indents are a violation of this rule; list items with hanging indents are okay:
* This is
not okay
* This is
okay
Opening brace should be on a new line Open
public function getPriority(): int {
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Expected 1 space after FOREACH keyword; 0 found Open
foreach($languageFinder as $language) {
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 6 Open
return parent::getPriority() - 100;
- Exclude checks
Lists should be surrounded by blank lines Open
- If multiple aliases point to the same folder, we only use the first alias in
- Read upRead up
- Exclude checks
MD032 - Lists should be surrounded by blank lines
Tags: bullet, ul, ol, blank_lines
Aliases: blanks-around-lists
This rule is triggered when lists (of any kind) are either not preceded or not followed by a blank line:
Some text
* Some
* List
1. Some
2. List
Some text
To fix this, ensure that all lists have a blank line both before and after (except where the block is at the beginning or end of the document):
Some text
* Some
* List
1. Some
2. List
Some text
Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse lists that don't have blank lines before and after them.
Note: List items without hanging indents are a violation of this rule; list items with hanging indents are okay:
* This is
not okay
* This is
okay
Opening brace should be on a new line Open
public function getPriority(): int {
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 14 Open
continue;
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Opening brace should be on a new line Open
public function getPriority(): int {
- Exclude checks
The variable $app_root is not named in camelCase. Open
protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
{
$app_root = $this->getConfig()->get('digipolis.root.web', false);
$subfolder = $uri ? $aliases[$uri] : 'default';
$site_path = $app_root . '/sites/' . $subfolder;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $site_path is not named in camelCase. Open
protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
{
$app_root = $this->getConfig()->get('digipolis.root.web', false);
$subfolder = $uri ? $aliases[$uri] : 'default';
$site_path = $app_root . '/sites/' . $subfolder;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $site_path is not named in camelCase. Open
protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
{
$app_root = $this->getConfig()->get('digipolis.root.web', false);
$subfolder = $uri ? $aliases[$uri] : 'default';
$site_path = $app_root . '/sites/' . $subfolder;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $site_path is not named in camelCase. Open
protected function addDrushInstallTask(
CollectionBuilder $collection,
array $options,
array $aliases,
string $profile,
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_directories is not named in camelCase. Open
public function getSiteUuid($uri = false, $aliases = [])
{
$aliases ??= [0 => false];
$webDir = $this->getConfig()->get('digipolis.root.web', false);
if (!$webDir) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $site_path is not named in camelCase. Open
public function getLanguageUuids($uri = false, $aliases = [])
{
$aliases ??= [0 => false];
$webDir = $this->getConfig()->get('digipolis.root.web', false);
if (!$webDir) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $site_path is not named in camelCase. Open
protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
{
$app_root = $this->getConfig()->get('digipolis.root.web', false);
$subfolder = $uri ? $aliases[$uri] : 'default';
$site_path = $app_root . '/sites/' . $subfolder;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $app_root is not named in camelCase. Open
protected function addDrushInstallTask(
CollectionBuilder $collection,
array $options,
array $aliases,
string $profile,
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}