dotcloud/docker

Method Controller.reservePools has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *Controller) reservePools() {
    networks, err := c.getNetworks()
    if err != nil {
        log.G(context.TODO()).Warnf("Could not retrieve networks from local store during ipam allocation for existing networks: %v", err)
        return

Method Controller.addServiceBinding has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *Controller) addServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases, taskAliases []string, ip net.IP, method string) error {
    var addService bool

    // Failure to lock the network ID on add can result in racing
    // against network deletion resulting in inconsistent state

Method NetworkDB.gossip has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (nDB *NetworkDB) gossip() {
    networkNodes := make(map[string][]string)
    nDB.RLock()
    thisNodeNetworks := nDB.networks[nDB.config.NodeID]
    for nid := range thisNodeNetworks {

Function withCgroups has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func withCgroups(daemon *Daemon, daemonCfg *dconfig.Config, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        var cgroupsPath string
        scopePrefix := "docker"
        parent := "/docker"

Method Reader.TestConcurrent has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (tr Reader) TestConcurrent(t *testing.T) {
    t.Parallel()
    l := tr.Factory(t, logger.Info{
        ContainerID:   "logconcurrent0",
        ContainerName: "logconcurrent123",

Method ImageService.ImageHistory has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (i *ImageService) ImageHistory(ctx context.Context, name string, platform *ocispec.Platform) ([]*image.HistoryResponseItem, error) {
    start := time.Now()
    img, err := i.GetImage(ctx, name, backend.GetImageOpts{Platform: platform})
    if err != nil {
        return nil, err

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if named != nil && len(sameRef) > 0 && len(sameRef) != len(all) {
            var records []imagetypes.DeleteResponse
            for _, ref := range sameRef {
                // TODO: Add with target
                err := i.images.Delete(ctx, ref.Name)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if len(sameRef) != len(all) {
            var records []imagetypes.DeleteResponse
            for _, ref := range sameRef {
                // TODO: Add with target
                err := i.images.Delete(ctx, ref.Name)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Cluster) RemoveConfig(input string) error {
    return c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        config, err := getConfig(ctx, state.controlClient, input)
        if err != nil {
            return err

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Cluster) RemoveSecret(input string) error {
    return c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        secret, err := getSecret(ctx, state.controlClient, input)
        if err != nil {
            return err

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func getSubnetForIP(ip *net.IPNet, subnets []*ipSubnet) *ipSubnet {
    for _, s := range subnets {
        _, snet, err := net.ParseCIDR(s.SubnetIP)
        if err != nil {
            return nil

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func getSubnetForIP(ip *net.IPNet, subnets []*ipSubnet) *ipSubnet {
    for _, s := range subnets {
        _, snet, err := net.ParseCIDR(s.SubnetIP)
        if err != nil {
            return nil

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func toContainer(hostID int, idMap []IDMap) (int, error) {
    if idMap == nil {
        return hostID, nil
    }
    for _, m := range idMap {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func lookupSubUIDRanges(usr user.User) ([]IDMap, error) {
    rangeList, err := parseSubuid(strconv.Itoa(usr.Uid))
    if err != nil {
        return nil, err
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (n *bridgeNetwork) setupFirewalld(config *networkConfiguration, i *bridgeInterface) error {
    d := n.driver
    d.Lock()
    driverConfig := d.config
    d.Unlock()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (n *bridgeNetwork) setupFirewalld6(config *networkConfiguration, i *bridgeInterface) error {
    d := n.driver
    d.Lock()
    driverConfig := d.config
    d.Unlock()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func toHost(contID int, idMap []IDMap) (int, error) {
    if idMap == nil {
        return contID, nil
    }
    for _, m := range idMap {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func lookupSubGIDRanges(usr user.User) ([]IDMap, error) {
    rangeList, err := parseSubgid(strconv.Itoa(usr.Uid))
    if err != nil {
        return nil, err
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func GetBroadcastIP(ip net.IP, mask net.IPMask) (net.IP, error) {
    // Find the effective starting of address and mask
    is, ms, err := compareIPMask(ip, mask)
    if err != nil {
        return nil, fmt.Errorf("cannot compute broadcast ip address because %s", err)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

package client // import "github.com/docker/docker/client"

import (
    "context"
    "encoding/json"

• Read up
  Read up