Sign upLogin

elliotchance/gedcom

View on GitHub
Star

Showing 640 of 640 total issues

Function runMaxYears has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func runMaxYears(gedcom1 *gedcom.Document, gedcom2 *gedcom.Document, idealScore int, options gedcom.SimilarityOptions, tuneFlags *TuneFlags) {
Severity: Minor
Found in cmd/gedcom/tune.go - About 35 mins to fix

    Function NewSourceListPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewSourceListPage(document *gedcom.Document, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *SourceListPage {
    Severity: Minor
    Found in html/source_list_page.go - About 35 mins to fix

      Function NewFamilyListPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func NewFamilyListPage(document *gedcom.Document, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *FamilyListPage {
      Severity: Minor
      Found in html/family_list_page.go - About 35 mins to fix

        Function runJaroPrefixSize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func runJaroPrefixSize(gedcom1 *gedcom.Document, gedcom2 *gedcom.Document, idealScore int, options gedcom.SimilarityOptions, tuneFlags *TuneFlags) {
        Severity: Minor
        Found in cmd/gedcom/tune.go - About 35 mins to fix

          Function NewIndividualEvent has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func NewIndividualEvent(date, place string, description core.Component, individual *gedcom.IndividualNode, event gedcom.Node, placesMap map[string]*place) *IndividualEvent {
          Severity: Minor
          Found in html/individual_event.go - About 35 mins to fix

            Function runJaroBoost has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func runJaroBoost(gedcom1 *gedcom.Document, gedcom2 *gedcom.Document, idealScore int, options gedcom.SimilarityOptions, tuneFlags *TuneFlags) {
            Severity: Minor
            Found in cmd/gedcom/tune.go - About 35 mins to fix

              Function filter has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func filter(root Node, fn FilterFunction, entityMap entityMap, document *Document, family *FamilyNode) Node {
              Severity: Minor
              Found in filter.go - About 35 mins to fix

                Function NewPlaceListPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func NewPlaceListPage(document *gedcom.Document, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *PlaceListPage {
                Severity: Minor
                Found in html/place_list_page.go - About 35 mins to fix

                  Function NewIndividualCompare has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func NewIndividualCompare(comparison *gedcom.IndividualComparison, filterFlags *gedcom.FilterFlags, progress chan gedcom.Progress, compareOptions *gedcom.IndividualNodesCompareOptions, visibility LivingVisibility) *IndividualCompare {
                  Severity: Minor
                  Found in html/individual_compare.go - About 35 mins to fix

                    Function runNameToDateRatio has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func runNameToDateRatio(gedcom1 *gedcom.Document, gedcom2 *gedcom.Document, idealScore int, options gedcom.SimilarityOptions, tuneFlags *TuneFlags) {
                    Severity: Minor
                    Found in cmd/gedcom/tune.go - About 35 mins to fix

                      Function newNodeWithChildren has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func newNodeWithChildren(document *Document, family *FamilyNode, tag Tag, value, pointer string, children Nodes) Node {
                      Severity: Minor
                      Found in decoder.go - About 35 mins to fix

                        Function NewSurnameListPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func NewSurnameListPage(document *gedcom.Document, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *SurnameListPage {
                        Severity: Minor
                        Found in html/surname_list_page.go - About 35 mins to fix

                          Function runIndividualWeight has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func runIndividualWeight(gedcom1 *gedcom.Document, gedcom2 *gedcom.Document, idealScore int, options gedcom.SimilarityOptions, tuneFlags *TuneFlags) {
                          Severity: Minor
                          Found in cmd/gedcom/tune.go - About 35 mins to fix

                            Function NewStatisticsPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func NewStatisticsPage(document *gedcom.Document, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *StatisticsPage {
                            Severity: Minor
                            Found in html/statistics_page.go - About 35 mins to fix

                              Method HTMLFormatter.Write has 5 return statements (exceeds 4 allowed).
                              Open

                              func (f *HTMLFormatter) Write(result interface{}) error {
    pageTitle := "gedcom"

    // Nil should be treated as a blank document.
    if gedcom.IsNil(result) {
                              Severity: Major
                              Found in q/html_formatter.go - About 35 mins to fix

                                Method Publisher.Places has 5 return statements (exceeds 4 allowed).
                                Open

                                func (publisher *Publisher) Places() map[string]*place {
    if publisher.placesMap == nil {
        publisher.placesMap = map[string]*place{}

        // Get all of the unique place names.
                                Severity: Major
                                Found in html/publish.go - About 35 mins to fix

                                  Method ResidenceNode.Equals has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func (node *ResidenceNode) Equals(node2 Node) bool {
    if IsNil(node) {
        return false
    }
                                  Severity: Major
                                  Found in residence_node.go - About 35 mins to fix

                                    Method EventNode.Equals has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func (node *EventNode) Equals(node2 Node) bool {
    if IsNil(node) {
        return false
    }
                                    Severity: Major
                                    Found in event_node.go - About 35 mins to fix

                                      Method UniqueIDNode.Equals has 5 return statements (exceeds 4 allowed).
                                      Open

                                      func (node *UniqueIDNode) Equals(node2 Node) bool {
    if IsNil(node) {
        return false
    }
                                      Severity: Major
                                      Found in unique_id_node.go - About 35 mins to fix

                                        Method GEDCOMFormatter.Write has 5 return statements (exceeds 4 allowed).
                                        Open

                                        func (f *GEDCOMFormatter) Write(result interface{}) error {
    // Nil should be treated as a blank document.
    if gedcom.IsNil(result) {
        return nil
    }
                                        Severity: Major
                                        Found in q/gedcom_formatter.go - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language