Sign upLogin

etsy/411

View on GitHub
Star

Showing 370 of 370 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        processSave: function() {
            var data = this.readForm();

            if(!this.model.isNew()) {
                this.collection.save();
Severity: Major
Found in htdocs/assets/js/views/groups/group.js and 1 other location - About 1 hr to fix
htdocs/assets/js/views/reports/report.js on lines 183..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function process has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Renderer.process = function(App, base_mapping, callback, preview) {
        var remote_mapping = {};

        // First loop over each group of views.
        for(var v in base_mapping) {
Severity: Minor
Found in htdocs/assets/js/views/renderer.js - About 1 hr to fix

    Method _execute has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _execute($date, $constructed_qdata) {
        // If our last_success_date is within 10 seconds of the start time, use that
        // as the start time.
        $from = $date - ($this->obj['range'] * 60);
        if(abs($this->obj['last_success_date'] - $from) < 10) {
    Severity: Minor
    Found in phplib/Search/ECL.php - About 1 hr to fix

      Method bootstrap has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function bootstrap($query, $from=null, $to=null) {
        $client = self::getClient();

        $fields = ['escalated', 'assignee_type', 'assignee', 'search_id', 'state'];
        $aggs = [];
      Severity: Minor
      Found in phplib/ESClient.php - About 1 hr to fix

        Method route has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function route() {
        $ret = self::format();
        try {
            $this->checkAuthorization();
        Severity: Minor
        Found in phplib/REST.php - About 1 hr to fix

          Function process has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function process(Alert $alert, $date) {
        $script = self::$SCRIPTS[$this->obj['data']['script']];
        $spec = [
            0 => ['pipe', 'r'],
            1 => ['pipe', 'w'],
          Severity: Minor
          Found in phplib/Filter/Script.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function validateData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validateData(array $data) {
        parent::validateData($data);

        if(strlen(trim($data['name'])) == 0) {
            throw new ValidationException('Invalid name');
          Severity: Minor
          Found in phplib/Search.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          define(function(require) {
    var $ = require('jquery'),
        Model = require('model'),
        Data = require('data');
          Severity: Major
          Found in htdocs/assets/js/models/grouptarget.js and 3 other locations - About 1 hr to fix
          htdocs/assets/js/models/alertlog.js on lines 2..18
          htdocs/assets/js/models/reporttarget.js on lines 2..18
          htdocs/assets/js/models/searchlog.js on lines 2..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          define(function(require) {
    var $ = require('jquery'),
        Model = require('model'),
        Data = require('data');
          Severity: Major
          Found in htdocs/assets/js/models/searchlog.js and 3 other locations - About 1 hr to fix
          htdocs/assets/js/models/alertlog.js on lines 2..18
          htdocs/assets/js/models/grouptarget.js on lines 2..18
          htdocs/assets/js/models/reporttarget.js on lines 2..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          define(function(require) {
    var $ = require('jquery'),
        Model = require('model'),
        Data = require('data');
          Severity: Major
          Found in htdocs/assets/js/models/alertlog.js and 3 other locations - About 1 hr to fix
          htdocs/assets/js/models/grouptarget.js on lines 2..18
          htdocs/assets/js/models/reporttarget.js on lines 2..18
          htdocs/assets/js/models/searchlog.js on lines 2..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          define(function(require) {
    var $ = require('jquery'),
        Model = require('model'),
        Data = require('data');
          Severity: Major
          Found in htdocs/assets/js/models/reporttarget.js and 3 other locations - About 1 hr to fix
          htdocs/assets/js/models/alertlog.js on lines 2..18
          htdocs/assets/js/models/grouptarget.js on lines 2..18
          htdocs/assets/js/models/searchlog.js on lines 2..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _render: function() {
            this.App.setTitle('Index');
            var user = this.App.Data.User;
            var vars = {
                logged_in: !!user,
          Severity: Minor
          Found in htdocs/assets/js/views/index.js - About 1 hr to fix

            Method processSite has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function processSite($site, $date, $backfill) {
        Logger::info('Process site', ['id' => $site['id'], 'date' => $date, 'backfill' => $backfill], self::LOG_NAMESPACE);
        $base_title = sprintf('411] Time: %d Site: %d', $date, $site['id']);
        cli_set_process_title($base_title);
        $timer = new Timer();
            Severity: Minor
            Found in phplib/Scheduler.php - About 1 hr to fix

              Method getDescription has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getDescription($name=true) {
        $desc_parts = [];

        switch($this->obj['action']) {
            case static::A_CREATE:
              Severity: Minor
              Found in phplib/AlertLog.php - About 1 hr to fix

                Method backfill has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function backfill($start_date, $end_date, $max_jobs=5) {
        Logger::info('Scheduler backfill run', ['start' => $start_date, 'end' => $end_date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Backfill');
        print "[+] Backfill: $start_date to $end_date\n";
        $timer = new Timer();
                Severity: Minor
                Found in phplib/Scheduler.php - About 1 hr to fix

                  Method initializeIndex has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function initializeIndex() {
        // Create template.
        if(!$this->client->indices()->existsTemplate(['name' => self::MAPPING_TEMPLATE])) {
            $version = explode('.', $this->client->info()['version']['number'])[0];
            $string_type = 'string';
                  Severity: Minor
                  Found in phplib/ESClient.php - About 1 hr to fix

                    Function getDescription has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getDescription($name=true) {
        $desc_parts = [];

        switch($this->obj['action']) {
            case static::A_CREATE:
                    Severity: Minor
                    Found in phplib/AlertLog.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function process($date, $backfill) {
        Logger::info('Scheduler run', ['time' => $date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Scheduler');
        print "[+] Scheduler: $date\n";
        $timer = new Timer();
                    Severity: Minor
                    Found in phplib/Scheduler.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _ajax has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            _ajax: function(options) {
            options = options || {};

            // Whether we've displayed the results of this request.
            var processed = false;
                    Severity: Minor
                    Found in htdocs/assets/js/app.js - About 1 hr to fix

                      Method process has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function process(Alert $alert, $date) {
        $script = self::$SCRIPTS[$this->obj['data']['script']];
        $spec = [
            0 => ['pipe', 'r'],
            1 => ['pipe', 'w'],
                      Severity: Minor
                      Found in phplib/Filter/Script.php - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language