etsy/411

Method validateData has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function validateData(array $data) {
        parent::validateData($data);

        if(strlen(trim($data['name'])) == 0) {
            throw new ValidationException('Invalid name');

Function serializeForm has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var serializeForm = function(f, ignore_blank, ignore_checks) {
        var data = {};
        var inps = f.find(':input').filter(function() {
            var hf = $(this).closest('.hidden-form');
            if(hf.length === 0) return true;

Method process has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(Alert $alert, $date) {
        $scfg = Config::get('slack');
        if(is_null($scfg['webhook_url'])) {
            throw new TargetException('Slack not configured');
        }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(is_null($lastjob) || $date - $lastjob['target_date'] >= 1 * 60 * 60 - 5) {
            $rollupjob = new Rollup_Job();
            $rollupjob['target_id'] = Rollup_Job::I_HOURLY;
            $rollupjob['target_date'] = $date;
            $rollupjob->store();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(is_null($lastjob) || $date - $lastjob['target_date'] >= 24 * 60 * 60 - 5) {
            $rollupjob = new Rollup_Job();
            $rollupjob['target_id'] = Rollup_Job::I_DAILY;
            $rollupjob['target_date'] = $date;
            $rollupjob->store();

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

        showDelete: function() {
            var view = this.App.setModal(new ModelView.DeleteModalView(this.App, this.modelName));
            this.listenTo(view, 'button:delete', this.destroyModel);
        },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        getInfo: function(options) {
            options = options || {};
            options.url = this.urlRoot + '/' + this.id + '/info';
            return Backbone.ajax(options);
        },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        getJobs: function(options) {
            options = options || {};
            options.url = this.urlRoot + '/' + this.id + '/job';
            return Backbone.ajax(options);
        },

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

        showDelete: function() {
            var view = this.App.setModal(new ModelView.DeleteModalView(this.App, this.modelName));
            this.listenTo(view, 'button:delete', this.destroyModel);
        },

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

        showDelete: function() {
            var view = this.App.setModal(new ModelView.DeleteModalView(this.App, this.modelName));
            this.listenTo(view, 'button:delete', this.destroyModel);
        },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        getStats: function(options) {
            options = options || {};
            options.url = this.urlRoot + '/' + this.id + '/stats';
            return Backbone.ajax(options);
        },

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

        showDelete: function() {
            var view = this.App.setModal(new ModelView.DeleteModalView(this.App, this.modelName));
            this.listenTo(view, 'button:delete', this.destroyModel);
        },

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

        showDelete: function() {
            var view = this.App.setModal(new ModelView.DeleteModalView(this.App, this.modelName));
            this.listenTo(view, 'button:delete', this.destroyModel);
        },

• Read up
  Read up

Function tokenBase has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function tokenBase(stream, state) {
            if (stream.eatSpace()) return null;

            var sol = stream.sol();
            var ch = stream.next();

Method render has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function render($tpl, $vars, $debug_data=[]) {
        $site = SiteFinder::getCurrent();

        // Embedded CSS. This is unfortunately necessary as most (all?) mail clients only allow inline CSS.
        $font = "font-family: 'Myriad Pro','Helvetica Neue',Helvetica,Tahoma,Arial,sans-serif;";

Method _execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function _execute($date, $constructed_qdata) {
        $gcfg = $this->getConfig();
        if(is_null($gcfg['host'])) {
            throw new SearchException('Graphite not configured');
        }

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                assignee_name: Util.getAssigneeName(
                    this.model.get('assignee_type'), this.model.get('assignee'),
                    this.App.Data.Users, this.App.Data.Groups
                )

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                assignee_name: Util.getAssigneeName(
                    this.model.get('assignee_type'), this.model.get('assignee'),
                    this.App.Data.Users, this.App.Data.Groups
                )

• Read up
  Read up

Function changeSelectable has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        changeSelectable: function(down, group) {
            // Don't do anything if we have no selectables.
            if(this.selectableGroups.length === 0) {
                return;
            }

Function tokenize has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    QueryParser.prototype.tokenize = function(str) {
        if(!str) {
            return [];
        }
        if(str.length > 1024) {