Sign upLogin

etsy/411

View on GitHub
Star

Showing 370 of 370 total issues

Method preview has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function preview($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
Severity: Minor
Found in phplib/REST/Searches.php - About 1 hr to fix

    Function generateWhere has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static function generateWhere(array $query) {
        $MODEL = 'FOO\\' . static::$MODEL;

        $clauses = [];
        $vals = [];
    Severity: Minor
    Found in phplib/Model.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateField has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function validateField($field, $settings, $value) {
        $ok = false;
        switch($settings[0]) {
            case static::T_BOOL:
                $ok = is_bool($value);
    Severity: Minor
    Found in phplib/Model.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getData() {
        $curl = new Curl;
        $raw_data = $curl->get($this->obj['url']);

        $ret = null;
    Severity: Minor
    Found in phplib/SList.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hydrateModels has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function hydrateModels($objs) {
        $models = [];
        foreach($objs as $obj) {
            foreach(array_keys($obj) as $key) {
                // If a value is numeric, cast it into an int.
    Severity: Minor
    Found in phplib/Model.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseDates has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function parseDates($format, array $dates) {
        $ret = [];
        switch($format) {
        case '#':
            $ret = $dates;
    Severity: Minor
    Found in phplib/Util.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function filterSearchesFunc has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var filterSearchesFunc = function(collection, query) {
        for(var k in query) {
            if(!_.isArray(query[k])) {
                query[k] = [query[k]];
            }
    Severity: Minor
    Found in htdocs/assets/js/views/searches/searches.js - About 1 hr to fix

      Function _render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _render: function() {
            var sidelinks = [
                {name: 'Keyboard shortcuts', action: 'shortcuts'},
                {name: 'Message history', action: 'messages'}
            ];
      Severity: Minor
      Found in htdocs/assets/js/views/header.js - About 1 hr to fix

        Function readForm has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                readForm: function() {
            var form = this.$('#search-form');
            var data = Util.serializeForm(form);

            // schedule_type is an int.
        Severity: Minor
        Found in htdocs/assets/js/views/searches/search.js - About 1 hr to fix

          Function update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  update: function() {
            var query = Util.parseQuery(window.location.href);

            var processResults = this.cbRendered(function(resp) {
                this.collections = [];
          Severity: Minor
          Found in htdocs/assets/js/views/alerts/alerts.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            Util.initTimeSelect(this.registerElement('input[name=lifetime]'), {
                    allow_zero: true,
                    format: function(num) { return parseInt(num, 10) === 0 ? 'Forever':Util.formatTime(num); }
                });
            Severity: Major
            Found in htdocs/assets/js/views/element.js and 1 other location - About 1 hr to fix
            htdocs/assets/js/views/alerts/actions.js on lines 99..102

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method process has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function process(Alert $alert, $date) {
        $site = SiteFinder::getCurrent();
        $search = SearchFinder::getById($alert['search_id']);
        $issue_key = null;
            Severity: Minor
            Found in phplib/Target/Jira.php - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          Util.initTimeSelect(this.registerElement('input[name=lifetime]'), {
                allow_zero: true,
                format: function(num) { return parseInt(num, 10) === 0 ? 'Forever':Util.formatTime(num); }
            });
              Severity: Major
              Found in htdocs/assets/js/views/alerts/actions.js and 1 other location - About 1 hr to fix
              htdocs/assets/js/views/element.js on lines 56..59

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method process has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function process($date, $backfill) {
        Logger::info('Scheduler run', ['time' => $date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Scheduler');
        print "[+] Scheduler: $date\n";
        $timer = new Timer();
              Severity: Minor
              Found in phplib/Scheduler.php - About 1 hr to fix

                Function App has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var App = function() {
        // Store a global collection of each type. This allows for caching objects between pages.
        this.Data = {
            Searches: new SearchCollection(),
            Alerts: new AlertCollection(),
                Severity: Minor
                Found in htdocs/assets/js/app.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if(!this.model.isNew()) {
                this.registerView(
                    new ReportTargetsListView(this.App, {collection: this.collection}),
                    true, this.$('.target-list')
                );
                  Severity: Major
                  Found in htdocs/assets/js/views/reports/report.js and 1 other location - About 1 hr to fix
                  htdocs/assets/js/views/groups/group.js on lines 145..150

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if(!this.model.isNew()) {
                this.registerView(
                    new GroupTargetsListView(this.App, {collection: this.collection}),
                    true, this.$('.target-list')
                );
                  Severity: Major
                  Found in htdocs/assets/js/views/groups/group.js and 1 other location - About 1 hr to fix
                  htdocs/assets/js/views/reports/report.js on lines 130..135

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Consider simplifying this complex logical expression.
                  Open

                              if(
                !('href' in anchor) ||
                anchor.target === '_blank' ||
                anchor.href.length === 0 ||
                anchor.href.indexOf('#') !== -1 ||
                  Severity: Critical
                  Found in htdocs/assets/js/app.js - About 1 hr to fix

                    Method run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function run() {
        $cfg = new DBConfig;
        $dt = new \DateTime('@' . $this->obj['target_date']);
        $dt->setTime(0, 0, 0);
        $end_ts = $dt->getTimestamp();
                    Severity: Minor
                    Found in phplib/Job/Summary.php - About 1 hr to fix

                      Function initializeCollection has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              initializeCollection: function(params) {
            var arr = this.initializeCollectionData(params);
            var models = arr[0],
                frag = arr[1];
                      Severity: Minor
                      Found in htdocs/assets/js/views/table.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language