Sign upLogin

etsy/phan

View on GitHub
Star

Showing 4,939 of 4,939 total issues

Method analyzeOverrideRealSignature has 163 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function analyzeOverrideRealSignature(
        CodeBase $code_base,
        Method $method,
        Clazz $class,
        Method $o_method,
Severity: Major
Found in src/Phan/Analysis/ParameterTypesAnalyzer.php - About 6 hrs to fix

    ContextNode has 47 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ContextNode
{

    /** @var CodeBase The code base within which we're operating */
    private $code_base;
    Severity: Minor
    Found in src/Phan/AST/ContextNode.php - About 6 hrs to fix

      File KindVisitorImplementation.php has 437 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

declare(strict_types=1);

namespace Phan\AST\Visitor;
      Severity: Minor
      Found in src/Phan/AST/Visitor/KindVisitorImplementation.php - About 6 hrs to fix

        Method fromReflectionClass has 162 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function fromReflectionClass(
        CodeBase $code_base,
        ReflectionClass $class
    ): Clazz {
        // Build a set of flags based on the constitution
        Severity: Major
        Found in src/Phan/Language/Element/Clazz.php - About 6 hrs to fix

          Function getMethod has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getMethod(
        $method_name,
        bool $is_static,
        bool $is_direct = false,
        bool $is_new_expression = false
          Severity: Minor
          Found in src/Phan/AST/ContextNode.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function print(IssueInstance $instance): void
    {
        $issue = $instance->getIssue();
        $message = [
            'type' => 'issue',
          Severity: Major
          Found in src/Phan/Output/Printer/CapturingJSONPrinter.php and 1 other location - About 6 hrs to fix
          src/Phan/Output/Printer/JSONPrinter.php on lines 27..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 209.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function print(IssueInstance $instance): void
    {
        $issue = $instance->getIssue();
        $message = [
            'type' => 'issue',
          Severity: Major
          Found in src/Phan/Output/Printer/JSONPrinter.php and 1 other location - About 6 hrs to fix
          src/Phan/Output/Printer/CapturingJSONPrinter.php on lines 21..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 209.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function addParamToScopeOfFunctionOrMethod has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function addParamToScopeOfFunctionOrMethod(
        Context $context,
        CodeBase $code_base,
        FunctionInterface $function,
        Comment $comment,
          Severity: Minor
          Found in src/Phan/Language/Element/FunctionTrait.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function analyzeShapedArrayAssignment has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
          Open

              private function analyzeShapedArrayAssignment(Node $node): void
    {
        // Figure out the type of elements in the list
        $fallback_element_type = null;
        /** @suppress PhanAccessMethodInternal */
          Severity: Minor
          Found in src/Phan/Analysis/AssignmentVisitor.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getClassList has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getClassList(
        bool $ignore_missing_classes = false,
        int $expected_type_categories = self::CLASS_LIST_ACCEPT_ANY,
        string $custom_issue_type = null,
        bool $warn_if_wrong_type = true
          Severity: Minor
          Found in src/Phan/AST/ContextNode.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getMethod has 156 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getMethod(
        $method_name,
        bool $is_static,
        bool $is_direct = false,
        bool $is_new_expression = false
          Severity: Major
          Found in src/Phan/AST/ContextNode.php - About 6 hrs to fix

            IncompatibleXMLSignatureDetector has 45 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class IncompatibleXMLSignatureDetector extends IncompatibleSignatureDetectorBase
{
    use Memoize;

    /** @var string the directory for english PHP element references */
            Severity: Minor
            Found in internal/lib/IncompatibleXMLSignatureDetector.php - About 6 hrs to fix

              Function analyzeFileList has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function analyzeFileList(
        CodeBase $code_base,
        Closure $file_path_lister
    ): bool {
        if (Config::getValue('dump_parsed_file_list') === true) {
              Severity: Minor
              Found in src/Phan/Phan.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function visitClosure has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function visitClosure(Node $node): Context
    {
        $code_base = $this->code_base;
        $context = $this->context->withoutLoops();
        $closure_fqsen = FullyQualifiedFunctionName::fromClosureInContext(
              Severity: Minor
              Found in src/Phan/Analysis/PreOrderAnalysisVisitor.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File DuplicateExpressionPlugin.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

declare(strict_types=1);

use ast\flags;
              Severity: Minor
              Found in .phan/plugins/DuplicateExpressionPlugin.php - About 6 hrs to fix

                Builder has 44 functions (exceeds 20 allowed). Consider refactoring.
                Open

                final class Builder
{
    /** @var string the original raw comment */
    public $comment;
    /** @var list<string> the list of lines of the doc comment */
                Severity: Minor
                Found in src/Phan/Language/Element/Comment/Builder.php - About 6 hrs to fix

                  ParseVisitor has 44 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class ParseVisitor extends ScopeVisitor
{

    /**
     * @param Context $context
                  Severity: Minor
                  Found in src/Phan/Parse/ParseVisitor.php - About 6 hrs to fix

                    File Comment.php has 416 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php

declare(strict_types=1);

namespace Phan\Language\Element;
                    Severity: Minor
                    Found in src/Phan/Language/Element/Comment.php - About 6 hrs to fix

                      Method getFlagInfo has 148 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private static function getFlagInfo(): array
    {
        // TODO: Use AST's built in flag info if available.
        static $exclusive, $combinable;
        // Write this in a way that lets Phan infer the value of $combinable at the end.
                      Severity: Major
                      Found in src/Phan/Debug.php - About 5 hrs to fix

                        Function parseCommentLine has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function parseCommentLine(int $i, string $line): void
    {
        // https://secure.php.net/manual/en/regexp.reference.internal-options.php
        // (?i) makes this case-sensitive, (?-1) makes it case-insensitive
        // phpcs:ignore Generic.Files.LineLength.MaxExceeded
                        Severity: Minor
                        Found in src/Phan/Language/Element/Comment/Builder.php - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language