Sign upLogin

eveseat/api

View on GitHub
Star

Showing 137 of 137 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getMarketOrders(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getAssets(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getAssets(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getContacts(int $corporation_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CorporationController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/AllianceController.php on lines 89..102
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public function getContacts(int $alliance_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/AllianceController.php and 8 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 111..124
src/Http/Controllers/Api/v2/CharacterController.php on lines 574..587
src/Http/Controllers/Api/v2/CharacterController.php on lines 747..760
src/Http/Controllers/Api/v2/CharacterController.php on lines 813..825
src/Http/Controllers/Api/v2/CorporationController.php on lines 103..116
src/Http/Controllers/Api/v2/CorporationController.php on lines 169..182
src/Http/Controllers/Api/v2/CorporationController.php on lines 367..380
src/Http/Controllers/Api/v2/CorporationController.php on lines 433..446

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid using short method names like CreateApiTokenLogsTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {

        Schema::create('api_token_logs', function (Blueprint $table) {
Severity: Minor
Found in src/database/migrations/2015_11_30_153848_create_api_token_logs_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AddMethodToApiTokenLogsTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {

        Schema::table('api_token_logs', function (Blueprint $table) {
Severity: Minor
Found in src/database/migrations/2018_07_12_220118_add_method_to_api_token_logs_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like CreateApiTokensTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {

        Schema::create('api_tokens', function (Blueprint $table) {
Severity: Minor
Found in src/database/migrations/2015_11_30_153611_create_api_tokens_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getContacts(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getNotifications(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getJumpClones(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getCorporationHistory(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 375..387
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function getIndustry(int $character_id)
    {
        request()->validate([
            '$filter' => 'string',
        ]);
Severity: Major
Found in src/Http/Controllers/Api/v2/CharacterController.php and 4 other locations - About 1 hr to fix
src/Http/Controllers/Api/v2/CharacterController.php on lines 177..189
src/Http/Controllers/Api/v2/CharacterController.php on lines 310..322
src/Http/Controllers/Api/v2/CharacterController.php on lines 440..452
src/Http/Controllers/Api/v2/CharacterController.php on lines 640..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid variables with short names like $tk. Configured minimum length is 3.
Open

        $tk = ApiTokenModel::where('token', $request->header('X-Token'))
Severity: Minor
Found in src/Http/Middleware/ApiToken.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class CorporationController has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.
Open

class CorporationController extends ApiController
{
    use Filterable;

    /**
Severity: Minor
Found in src/Http/Controllers/Api/v2/CorporationController.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The class CharacterController has a coupling between objects value of 24. Consider to reduce the number of dependencies under 13.
Open

class CharacterController extends ApiController
{
    use Filterable;

    /**
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Method addFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function addFilter(Builder $query, string $field, string $operator, $value, ?string $join = 'and')
Severity: Minor
Found in src/Http/Traits/Filterable.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                case 'le': return '<=';
    Severity: Major
    Found in src/Http/Traits/Filterable.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  default: return '=';
      Severity: Major
      Found in src/Http/Traits/Filterable.php - About 30 mins to fix

        Avoid using static access to class '\Illuminate\Support\Str' in method 'generateToken'.
        Open

                $fields['token'] = Str::random(32);
        Severity: Minor
        Found in src/Http/Controllers/Admin/ApiAdminController.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Severity
        Category
        Status
        Source
        Language