Sign upLogin

eveseat/api

View on GitHub
Star

Showing 137 of 137 total issues

Avoid using static access to class '\Seat\Api\Http\Resources\CorporationHistoryResource' in method 'getCorporationHistory'.
Open

        return CorporationHistoryResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$scope'.
Open

        $permissions = collect(config('seat.permissions'))->map(function ($item, $scope) {
Severity: Minor
Found in src/Http/Controllers/Api/v2/RoleLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$sub_item'.
Open

            return collect($item)->map(function ($sub_item, $name) {
Severity: Minor
Found in src/Http/Controllers/Api/v2/RoleLookupController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Seat\Web\Models\User' in method 'getPermissionCheck'.
Open

        $user = User::findOrFail($user_id);
Severity: Minor
Found in src/Http/Controllers/Api/v2/RoleLookupController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Models\ApiTokenLog' in method 'query'.
Open

        return ApiTokenLog::query();
Severity: Minor
Found in src/Http/DataTables/ApiTokenLogDataTable.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Schema' in method 'up'.
Open

        Schema::create('api_tokens', function (Blueprint $table) {

            $table->increments('id');
            $table->string('token');
            $table->string('allowed_src');
Severity: Minor
Found in src/database/migrations/2015_11_30_153611_create_api_tokens_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Web\Models\Acl\Role' in method 'deleteRole'.
Open

        Role::findOrFail($role_id);
Severity: Minor
Found in src/Http/Controllers/Api/v2/RoleController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\UserResource' in method 'getUsers'.
Open

        return UserResource::collection(User::paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/UserController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Arr' in method 'toArray'.
Open

        Arr::forget($definition, 'character_id');
Severity: Minor
Found in src/Http/Resources/MailResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\NotificationResource' in method 'getNotifications'.
Open

        return NotificationResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CharacterController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getIndex'.
Open

        return Resource::collection(Role::paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/RoleController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Arr' in method 'toArray'.
Open

        Arr::forget($definition, 'killmail_id');
Severity: Minor
Found in src/Http/Resources/KillmailDetailResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Arr' in method 'toArray'.
Open

        Arr::forget($definition, 'from');
Severity: Minor
Found in src/Http/Resources/MailResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Arr' in method 'toArray'.
Open

        Arr::set($definition, 'recipients', array_map(function ($recipient) {
            return [
                'entity_id' => $recipient['entity']['entity_id'],
                'name' => $recipient['entity']['name'],
                'category' => $recipient['entity']['category'],
Severity: Minor
Found in src/Http/Resources/MailResource.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Schema' in method 'up'.
Open

        Schema::create('api_token_logs', function (Blueprint $table) {

            $table->increments('id');
            $table->integer('api_token_id')->nullable();
            $table->enum('action', ['allow', 'deny']);
Severity: Minor
Found in src/database/migrations/2015_11_30_153848_create_api_token_logs_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Validator' in method 'add_custom_validators'.
Open

        Validator::extend('base64image', 'Seat\Api\Http\Validation\Image@validate');
Severity: Minor
Found in src/ApiServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Http\Resources\Json\Resource' in method 'getStructures'.
Open

        return Resource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CorporationController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Models\ApiToken' in method 'generateToken'.
Open

        ApiToken::create($fields);
Severity: Minor
Found in src/Http/Controllers/Admin/ApiAdminController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\MemberTrackingResource' in method 'getMemberTracking'.
Open

        return MemberTrackingResource::collection($query->paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/CorporationController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Api\Http\Resources\SquadResource' in method 'index'.
Open

        return SquadResource::collection(Squad::paginate()->appends(request()->except('page')));
Severity: Minor
Found in src/Http/Controllers/Api/v2/SquadController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language