Showing 440 of 440 total issues
Method handle
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
parent::handle();
// get last known mail ID to detect when parity has been reached
Method handle
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
$contract = ContractDetail::find($this->contract_id);
Method handle
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
$contract = ContractDetail::find($this->contract_id);
if ($contract->type == 'courier')
Method handle
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle(EsiBase $job, Closure $next): void
{
// in case the job does not require specific scopes - forward
if ($job->getScope() == '') {
logger()->debug(
Method handle
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
$contract = ContractDetail::find($this->contract_id);
// this job can only work with auction contracts
Avoid excessively long variable names like $scheduled_corporations. Keep variable name length under 20. Open
private array $scheduled_corporations = [];
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $extracted_target_path. Keep variable name length under 20. Open
private function uncompressFile($archive_path, $extracted_target_path): void
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $returned_characters_ids. Keep variable name length under 20. Open
$returned_characters_ids = collect();
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Method handle
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
parent::handle();
CorporationStarbase::where('corporation_id', $this->getCorporationId())
Method explodeMap
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function explodeMap()
{
// extract regions
DB::table('regions')->truncate();
DB::table('regions')
Method handle
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
// the time only needs to be loaded once instead of every time in the loop
$now = carbon();
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function customValidationMessages()
{
return [
'0.integer' => self::INTEGER_VALIDATION_MESSAGE,
'0.min' => self::MIN_VALIDATION_MESSAGE,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 112.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function customValidationMessages()
{
return [
'0.integer' => self::INTEGER_VALIDATION_MESSAGE,
'0.min' => self::MIN_VALIDATION_MESSAGE,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 112.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method handle
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
// collect optional kills ID from arguments
$killmail_ids = $this->argument('killmail_ids') ?: [];
Method handle
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
$contract = ContractDetail::find($this->contract_id);
Method handle
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle()
{
parent::handle();
$response = $this->retrieve([
Method fire
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fire(): void
{
$this->addPublicJobs();
if (! is_null($this->token))
Method fire
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fire(): void
{
$this->addPublicJobs();
if (! is_null($this->token))
Method fire
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fire(): void
{
$this->addPublicJobs();
if (! is_null($this->token))
Method customValidationMessages
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function customValidationMessages()
{
return [
'0.integer' => self::INTEGER_VALIDATION_MESSAGE,
'0.min' => self::MIN_VALIDATION_MESSAGE,