eveseat/eveapi

View on GitHub

Showing 440 of 440 total issues

Method handle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        parent::handle();

        // get last known mail ID to detect when parity has been reached
Severity: Minor
Found in src/Jobs/Mail/Mails.php - About 1 hr to fix

    Method handle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handle()
        {
    
            $contract = ContractDetail::find($this->contract_id);
    
    
    Severity: Minor
    Found in src/Jobs/Contracts/Character/Items.php - About 1 hr to fix

      Method handle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle()
          {
              $contract = ContractDetail::find($this->contract_id);
      
              if ($contract->type == 'courier')
      Severity: Minor
      Found in src/Jobs/Contracts/Corporation/Items.php - About 1 hr to fix

        Method handle has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function handle(EsiBase $job, Closure $next): void
            {
                // in case the job does not require specific scopes - forward
                if ($job->getScope() == '') {
                    logger()->debug(
        Severity: Minor
        Found in src/Jobs/Middleware/CheckTokenScope.php - About 1 hr to fix

          Method handle has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function handle()
              {
                  $contract = ContractDetail::find($this->contract_id);
          
                  // this job can only work with auction contracts
          Severity: Minor
          Found in src/Jobs/Contracts/Corporation/Bids.php - About 1 hr to fix

            Avoid excessively long variable names like $scheduled_corporations. Keep variable name length under 20.
            Open

                private array $scheduled_corporations = [];
            Severity: Minor
            Found in src/Commands/Seat/Buckets/Update.php by phpmd

            LongVariable

            Since: 0.2

            Detects when a field, formal or local variable is declared with a long name.

            Example

            class Something {
                protected $reallyLongIntName = -3; // VIOLATION - Field
                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                    $otherReallyLongName = -5; // VIOLATION - Local
                    for ($interestingIntIndex = 0; // VIOLATION - For
                         $interestingIntIndex < 10;
                         $interestingIntIndex++ ) {
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#longvariable

            Avoid excessively long variable names like $extracted_target_path. Keep variable name length under 20.
            Open

                private function uncompressFile($archive_path, $extracted_target_path): void
            Severity: Minor
            Found in src/Commands/Eve/Update/Sde.php by phpmd

            LongVariable

            Since: 0.2

            Detects when a field, formal or local variable is declared with a long name.

            Example

            class Something {
                protected $reallyLongIntName = -3; // VIOLATION - Field
                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                    $otherReallyLongName = -5; // VIOLATION - Local
                    for ($interestingIntIndex = 0; // VIOLATION - For
                         $interestingIntIndex < 10;
                         $interestingIntIndex++ ) {
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#longvariable

            Avoid excessively long variable names like $returned_characters_ids. Keep variable name length under 20.
            Open

                    $returned_characters_ids = collect();
            Severity: Minor
            Found in src/Jobs/Corporation/Roles.php by phpmd

            LongVariable

            Since: 0.2

            Detects when a field, formal or local variable is declared with a long name.

            Example

            class Something {
                protected $reallyLongIntName = -3; // VIOLATION - Field
                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                    $otherReallyLongName = -5; // VIOLATION - Local
                    for ($interestingIntIndex = 0; // VIOLATION - For
                         $interestingIntIndex < 10;
                         $interestingIntIndex++ ) {
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#longvariable

            Method handle has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function handle()
                {
                    parent::handle();
            
                    CorporationStarbase::where('corporation_id', $this->getCorporationId())
            Severity: Minor
            Found in src/Jobs/Corporation/StarbaseDetails.php - About 1 hr to fix

              Method explodeMap has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function explodeMap()
                  {
                      // extract regions
                      DB::table('regions')->truncate();
                      DB::table('regions')
              Severity: Minor
              Found in src/Commands/Eve/Update/Sde.php - About 1 hr to fix

                Method handle has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function handle()
                    {
                        // the time only needs to be loaded once instead of every time in the loop
                        $now = carbon();
                
                
                Severity: Minor
                Found in src/Jobs/Market/OrderAggregates.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function customValidationMessages()
                      {
                          return [
                              '0.integer' => self::INTEGER_VALIDATION_MESSAGE,
                              '0.min' => self::MIN_VALIDATION_MESSAGE,
                  Severity: Major
                  Found in src/Mapping/Sde/RamActivityMapping.php and 1 other location - About 1 hr to fix
                  src/Mapping/Sde/InvMarketGroupMapping.php on lines 79..96

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function customValidationMessages()
                      {
                          return [
                              '0.integer' => self::INTEGER_VALIDATION_MESSAGE,
                              '0.min' => self::MIN_VALIDATION_MESSAGE,
                  Severity: Major
                  Found in src/Mapping/Sde/InvMarketGroupMapping.php and 1 other location - About 1 hr to fix
                  src/Mapping/Sde/RamActivityMapping.php on lines 99..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method handle has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function handle()
                      {
                          // collect optional kills ID from arguments
                          $killmail_ids = $this->argument('killmail_ids') ?: [];
                  
                  
                  Severity: Minor
                  Found in src/Commands/Esi/Update/Killmails.php - About 1 hr to fix

                    Method handle has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function handle()
                        {
                    
                            $contract = ContractDetail::find($this->contract_id);
                    
                    
                    Severity: Minor
                    Found in src/Jobs/Contracts/Character/Bids.php - About 1 hr to fix

                      Method handle has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function handle()
                          {
                              parent::handle();
                      
                              $response = $this->retrieve([
                      Severity: Minor
                      Found in src/Jobs/PlanetaryInteraction/Character/Planets.php - About 1 hr to fix

                        Method fire has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function fire(): void
                            {
                                $this->addPublicJobs();
                        
                                if (! is_null($this->token))
                        Severity: Minor
                        Found in src/Bus/Character.php - About 1 hr to fix

                          Method fire has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function fire(): void
                              {
                                  $this->addPublicJobs();
                          
                                  if (! is_null($this->token))
                          Severity: Minor
                          Found in src/Bus/Corporation.php - About 1 hr to fix

                            Method fire has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function fire(): void
                                {
                                    $this->addPublicJobs();
                            
                                    if (! is_null($this->token))
                            Severity: Minor
                            Found in src/Bus/Alliance.php - About 1 hr to fix

                              Method customValidationMessages has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function customValidationMessages()
                                  {
                                      return [
                                          '0.integer' => self::INTEGER_VALIDATION_MESSAGE,
                                          '0.min' => self::MIN_VALIDATION_MESSAGE,
                              Severity: Minor
                              Found in src/Mapping/Sde/InvTypeMapping.php - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language