Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star

Showing 156 of 218 total issues

File federal_accounts_v2.py has 626 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import ast
from collections import OrderedDict
from typing import List

from django.db.models import DecimalField, Exists, F, Func, OuterRef, Q, Subquery, Sum
Severity: Major
Found in usaspending_api/accounts/views/federal_accounts_v2.py - About 1 day to fix

    File download_generation.py has 625 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import json
import logging
import multiprocessing
import os
from copy import deepcopy
    Severity: Major
    Found in usaspending_api/download/filestreaming/download_generation.py - About 1 day to fix

      File award_search.py has 621 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      from usaspending_api.awards.v2.lookups.lookups import award_type_mapping

AWARD_SEARCH_COLUMNS = {
    "treasury_account_identifiers": {"delta": "ARRAY<INTEGER>", "postgres": "INTEGER[]", "gold": False},
    "award_id": {"delta": "LONG NOT NULL", "postgres": "BIGINT NOT NULL", "gold": False},
      Severity: Major
      Found in usaspending_api/search/delta_models/award_search.py - About 1 day to fix

        File query_with_filters.py has 580 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import copy
import logging
from datetime import datetime
from typing import List, Tuple
        Severity: Major
        Found in usaspending_api/common/query_with_filters.py - About 1 day to fix

          File delete_data.py has 560 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import logging
from time import perf_counter
from typing import Any, Dict, List, Optional, Union

import pandas as pd
          Severity: Major
          Found in usaspending_api/etl/elasticsearch_loader_helpers/delete_data.py - About 1 day to fix

            Function type_filter has a Cognitive Complexity of 67 (exceeds 15 allowed). Consider refactoring.
            Open

            def type_filter(_type, filters, limit=None):
    _types = [
        "budget_function",
        "budget_subfunction",
        "federal_account",
            Severity: Minor
            Found in usaspending_api/spending_explorer/v2/filters/type_filter.py - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Cyclomatic complexity is too high in function subaward_filter. (59)
            Open

            def subaward_filter(filters, for_downloads=False):
    queryset = SubawardSearch.objects.all()

    recipient_scope_q = Q(sub_legal_entity_country_code="USA") | Q(sub_legal_entity_country_name="UNITED STATES")
    pop_scope_q = Q(sub_place_of_perform_country_co="USA") | Q(sub_place_of_perform_country_name="UNITED STATES")
            Severity: Minor
            Found in usaspending_api/awards/v2/filters/sub_award.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            File conftest.py has 478 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import logging
import os
import sys
import tempfile
from pathlib import Path
            Severity: Minor
            Found in usaspending_api/conftest.py - About 7 hrs to fix

              File transaction_search.py has 471 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              from django.contrib.postgres.fields import ArrayField
from django.db import models
from django.db.models import Q

from usaspending_api.common.custom_django_fields import NumericField
              Severity: Minor
              Found in usaspending_api/search/models/transaction_search.py - About 7 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if row["funding_agency_code"] is None or len(row["funding_agency_code"].strip()) < 1:
                    funding_subtier_agency_id = subtier_agency_map.get(row["funding_sub_tier_agency_co"])
                    if funding_subtier_agency_id is not None:
                        funding_toptier_agency_id = subtier_to_agency_map[funding_subtier_agency_id][
                            "toptier_agency_id"
                Severity: Major
                Found in usaspending_api/broker/management/commands/update_transactions.py and 1 other location - About 7 hrs to fix
                usaspending_api/broker/management/commands/update_transactions.py on lines 119..126

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 113.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function construct_es_response_for_prime_awards has a Cognitive Complexity of 57 (exceeds 15 allowed). Consider refactoring.
                Open

                    def construct_es_response_for_prime_awards(self, response) -> dict:
        results = []
        should_return_display_award_id = "Award ID" in self.fields
        should_return_recipient_id = "recipient_id" in self.fields
        for res in response:
                Severity: Minor
                Found in usaspending_api/search/v2/views/spending_by_award.py - About 7 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if row["funding_agency_code"] is None or len(row["funding_agency_code"].strip()) < 1:
                funding_subtier_agency_id = subtier_agency_map.get(row["funding_sub_tier_agency_co"])
                if funding_subtier_agency_id is not None:
                    funding_toptier_agency_id = subtier_to_agency_map[funding_subtier_agency_id]["toptier_agency_id"]
                    funding_toptier_code = toptier_agency_map[funding_toptier_agency_id]
                Severity: Major
                Found in usaspending_api/broker/management/commands/update_transactions.py and 1 other location - About 7 hrs to fix
                usaspending_api/broker/management/commands/update_transactions.py on lines 287..296

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 113.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File spending_by_geography.py has 461 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import copy
import logging
from decimal import Decimal
from enum import Enum
from typing import Dict, List, Optional
                Severity: Minor
                Found in usaspending_api/search/v2/views/spending_by_geography.py - About 7 hrs to fix

                  File spending_by_award.py has 445 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import copy
from ast import literal_eval

from sys import maxsize
from django.conf import settings
                  Severity: Minor
                  Found in usaspending_api/search/v2/views/spending_by_award.py - About 6 hrs to fix

                    Function initial_run has a Cognitive Complexity of 51 (exceeds 15 allowed). Consider refactoring.
                    Open

                        def initial_run(self, next_last_load):
        """
        Procedure to create & set up transaction_id_lookup and award_id_lookup tables and create other tables in
        int database that will be populated by subsequent calls.
        """
                    Severity: Minor
                    Found in usaspending_api/etl/management/commands/load_transactions_in_delta.py - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Cyclomatic complexity is too high in method initial_run. (47)
                    Open

                        def initial_run(self, next_last_load):
        """
        Procedure to create & set up transaction_id_lookup and award_id_lookup tables and create other tables in
        int database that will be populated by subsequent calls.
        """
                    Severity: Minor
                    Found in usaspending_api/etl/management/commands/load_transactions_in_delta.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    Function create_q_from_filter has a Cognitive Complexity of 50 (exceeds 15 allowed). Consider refactoring.
                    Open

                        def create_q_from_filter(self, filt):
        if "combine_method" in filt:
            return self.create_q_from_filter_list(filt["filters"], filt["combine_method"])
        else:
            q_kwargs = {}
                    Severity: Minor
                    Found in usaspending_api/common/api_request_utils.py - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File populate_reporting_agency_overview.py has 420 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import logging

from enum import Enum

from django.core.management import BaseCommand
                    Severity: Minor
                    Found in usaspending_api/reporting/management/commands/populate_reporting_agency_overview.py - About 6 hrs to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if row["awarding_agency_code"] is None or len(row["awarding_agency_code"].strip()) < 1:
                awarding_subtier_agency_id = subtier_agency_map[row["awarding_sub_tier_agency_c"]]
                awarding_toptier_agency_id = subtier_to_agency_map[awarding_subtier_agency_id]["toptier_agency_id"]
                awarding_toptier_code = toptier_agency_map[awarding_toptier_agency_id]
                row["awarding_agency_code"] = awarding_toptier_code
                      Severity: Major
                      Found in usaspending_api/broker/management/commands/update_transactions.py and 1 other location - About 5 hrs to fix
                      usaspending_api/broker/management/commands/update_transactions.py on lines 278..282

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      if row["awarding_agency_code"] is None or len(row["awarding_agency_code"].strip()) < 1:
                    awarding_subtier_agency_id = subtier_agency_map[row["awarding_sub_tier_agency_c"]]
                    awarding_toptier_agency_id = subtier_to_agency_map[awarding_subtier_agency_id]["toptier_agency_id"]
                    awarding_toptier_code = toptier_agency_map[awarding_toptier_agency_id]
                    row["awarding_agency_code"] = awarding_toptier_code
                      Severity: Major
                      Found in usaspending_api/broker/management/commands/update_transactions.py and 1 other location - About 5 hrs to fix
                      usaspending_api/broker/management/commands/update_transactions.py on lines 110..114

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language