Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star

Showing 164 of 226 total issues

Avoid too many return statements within this function.
Open

                return Q()
Severity: Major
Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

    Function get_business_categories_fabs has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
    Open

    def get_business_categories_fabs(business_types):
    # This function is supposed to be invoked as a Spark UDF with the business_types field passed to it.

    business_category_set = set()
    Severity: Minor
    Found in usaspending_api/broker/helpers/get_business_categories.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_unreported_data_obj has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
    Open

    def get_unreported_data_obj(
    queryset, filters, limit, spending_type, actual_total, fiscal_year, fiscal_period
) -> (list, float):
    """Returns the modified list of result objects including the object corresponding to the unreported amount, only
    if applicable. If the unreported amount does not fit within the limit of results provided, it will not be added.
    Severity: Minor
    Found in usaspending_api/spending_explorer/v2/filters/type_filter.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function post has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
    Open

        def post(self, request):
        models = [
            {
                "name": "fields",
                "key": "fields",
    Severity: Minor
    Found in usaspending_api/search/v2/views/search_elasticsearch.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language