Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star

Showing 158 of 220 total issues

Function update_transaction_assistance has a Cognitive Complexity of 19 (exceeds 15 allowed). Consider refactoring.
Open

    def update_transaction_assistance(db_cursor, fiscal_year=None, page=1, limit=500000):

        query = "SELECT * FROM published_fabs"
        arguments = []
Severity: Minor
Found in usaspending_api/broker/management/commands/update_transactions.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse_source has 9 arguments (exceeds 6 allowed). Consider refactoring.
Open

def parse_source(
Severity: Major
Found in usaspending_api/download/filestreaming/download_generation.py - About 50 mins to fix

    Function _download_and_copy has 9 arguments (exceeds 6 allowed). Consider refactoring.
    Open

    def _download_and_copy(
    Severity: Major
    Found in usaspending_api/common/csv_stream_s3_to_pg.py - About 50 mins to fix

      Function receive_messages has 9 arguments (exceeds 6 allowed). Consider refactoring.
      Open

          def receive_messages(
      Severity: Major
      Found in usaspending_api/common/sqs/sqs_handler.py - About 50 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        def run_broker_select_query(transaction_sql, id_tuple):
    with broker_connection.cursor() as select_cursor:
        select_cursor.execute(transaction_sql, [id_tuple])
        return select_cursor.fetchall()
        Severity: Minor
        Found in usaspending_api/database_scripts/job_archive/backfill_solicitation_date.py and 1 other location - About 50 mins to fix
        usaspending_api/database_scripts/job_archive/backfill_per_transaction_exec_comp.py on lines 218..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 36.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        def run_broker_select_query(transaction_sql, id_tuple):
    with broker_connection.cursor() as select_cursor:
        select_cursor.execute(transaction_sql, [id_tuple])
        return select_cursor.fetchall()
        Severity: Minor
        Found in usaspending_api/database_scripts/job_archive/backfill_per_transaction_exec_comp.py and 1 other location - About 50 mins to fix
        usaspending_api/database_scripts/job_archive/backfill_solicitation_date.py on lines 114..117

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 36.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid deeply nested control flow statements.
        Open

                            if broker_fpds_data:
                        updated_row_count = run_spending_update_query(
                            SPENDING_FPDS_UPDATE_SQL, "FPDS", broker_fpds_data
                        )
                        fpds_row_count += updated_row_count
        Severity: Major
        Found in usaspending_api/database_scripts/job_archive/backfill_solicitation_date.py - About 45 mins to fix

          Function update_transaction_contract has a Cognitive Complexity of 18 (exceeds 15 allowed). Consider refactoring.
          Open

              def update_transaction_contract(db_cursor, fiscal_year=None, page=1, limit=500000):

        # logger.info("Getting IDs for what's currently in the DB...")
        # current_ids = TransactionFPDS.objects
        #
          Severity: Minor
          Found in usaspending_api/broker/management/commands/update_transactions.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if "toptier_name" in v:
                            awarding_subtier |= Q(awarding_subtier_agency_name=name) & Q(
                                awarding_toptier_agency_name=v["toptier_name"]
                            )
                        else:
          Severity: Major
          Found in usaspending_api/awards/v2/filters/search.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if "toptier_name" in v:
                            funding_subtier |= Q(funding_subtier_agency_name=name) & Q(
                                funding_toptier_agency_name=v["toptier_name"]
                            )
                        else:
            Severity: Major
            Found in usaspending_api/awards/v2/filters/search.py - About 45 mins to fix

              Function get_deleted_fpds_data_from_s3 has a Cognitive Complexity of 18 (exceeds 15 allowed). Consider refactoring.
              Open

              def get_deleted_fpds_data_from_s3(date):
    ids_to_delete = []
    regex_str = ".*_delete_records_(IDV|award).*"

    if not date:
              Severity: Minor
              Found in usaspending_api/etl/transaction_loaders/data_load_helpers.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function django_db_setup has 8 arguments (exceeds 6 allowed). Consider refactoring.
              Open

              def django_db_setup(
              Severity: Major
              Found in usaspending_api/conftest.py - About 45 mins to fix

                Function delete_docs_by_unique_key has 7 arguments (exceeds 6 allowed). Consider refactoring.
                Open

                def delete_docs_by_unique_key(
                Severity: Major
                Found in usaspending_api/etl/elasticsearch_loader_helpers/delete_data.py - About 35 mins to fix

                  Function download_s3_object has 7 arguments (exceeds 6 allowed). Consider refactoring.
                  Open

                  def download_s3_object(
                  Severity: Major
                  Found in usaspending_api/common/helpers/s3_helpers.py - About 35 mins to fix

                    Function log_dispatcher_message has 7 arguments (exceeds 6 allowed). Consider refactoring.
                    Open

                    def log_dispatcher_message(
                    Severity: Major
                    Found in usaspending_api/common/sqs/sqs_job_logging.py - About 35 mins to fix

                      Function create_empty_data_file has 7 arguments (exceeds 6 allowed). Consider refactoring.
                      Open

                      def create_empty_data_file(
                      Severity: Major
                      Found in usaspending_api/download/filestreaming/download_generation.py - About 35 mins to fix

                        Function __init__ has 7 arguments (exceeds 6 allowed). Consider refactoring.
                        Open

                            def __init__(
                        Severity: Major
                        Found in usaspending_api/common/sqs/sqs_work_dispatcher.py - About 35 mins to fix

                          Function write_csv_file has 7 arguments (exceeds 6 allowed). Consider refactoring.
                          Open

                          def write_csv_file(
                          Severity: Major
                          Found in usaspending_api/common/etl/spark.py - About 35 mins to fix

                            Function get_unreported_data_obj has 7 arguments (exceeds 6 allowed). Consider refactoring.
                            Open

                            def get_unreported_data_obj(
                            Severity: Major
                            Found in usaspending_api/spending_explorer/v2/filters/type_filter.py - About 35 mins to fix

                              Function delete_transactions has 7 arguments (exceeds 6 allowed). Consider refactoring.
                              Open

                              def delete_transactions(
                              Severity: Major
                              Found in usaspending_api/etl/elasticsearch_loader_helpers/delete_data.py - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language