Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star

Showing 164 of 226 total issues

Function delete_docs_by_unique_key has 7 arguments (exceeds 6 allowed). Consider refactoring.
Open

def delete_docs_by_unique_key(
Severity: Major
Found in usaspending_api/etl/elasticsearch_loader_helpers/delete_data.py - About 35 mins to fix

    Function create_empty_data_file has 7 arguments (exceeds 6 allowed). Consider refactoring.
    Open

    def create_empty_data_file(
    Severity: Major
    Found in usaspending_api/download/filestreaming/download_generation.py - About 35 mins to fix

      Function load_data_into_model has 7 arguments (exceeds 6 allowed). Consider refactoring.
      Open

          def load_data_into_model(self, model_instance, fields, field_map, value_map, row, logger, as_dict=False):
      Severity: Major
      Found in usaspending_api/common/threaded_data_loader.py - About 35 mins to fix

        Function download_s3_object has 7 arguments (exceeds 6 allowed). Consider refactoring.
        Open

        def download_s3_object(
        Severity: Major
        Found in usaspending_api/common/helpers/s3_helpers.py - About 35 mins to fix

          Function log_dispatcher_message has 7 arguments (exceeds 6 allowed). Consider refactoring.
          Open

          def log_dispatcher_message(
          Severity: Major
          Found in usaspending_api/common/sqs/sqs_job_logging.py - About 35 mins to fix

            Function get_unreported_data_obj has 7 arguments (exceeds 6 allowed). Consider refactoring.
            Open

            def get_unreported_data_obj(
            Severity: Major
            Found in usaspending_api/spending_explorer/v2/filters/type_filter.py - About 35 mins to fix

              Function load_data_into_model has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
              Open

                  def load_data_into_model(self, model_instance, fields, field_map, value_map, row, logger, as_dict=False):
        mod = model_instance

        if as_dict:
            mod = {}
              Severity: Minor
              Found in usaspending_api/common/threaded_data_loader.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function build_data_file_name has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
              Open

              def build_data_file_name(source, download_job, piid, assistance_id):
    if download_job and download_job.monthly_download:
        # For monthly archives, use the existing detailed zip filename for the data files
        # e.g. FY(All)-012_Contracts_Delta_20191108.zip -> FY(All)-012_Contracts_Delta_20191108_%.csv
        return strip_file_extension(download_job.file_name)
              Severity: Minor
              Found in usaspending_api/download/filestreaming/download_generation.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function generate_elasticsearch_query has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
              Open

                  def generate_elasticsearch_query(cls, filter_values: List[dict], query_type: _QueryType, **options) -> ES_Q:
        recipient_locations_query = []

        for filter_value in filter_values:
            location_query = []
              Severity: Minor
              Found in usaspending_api/common/query_with_filters.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function parse_cli_args has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
              Open

              def parse_cli_args(options: dict, es_client) -> dict:
    passthrough_values = [
        "create_new_index",
        "drop_db_view",
        "index_name",
              Severity: Minor
              Found in usaspending_api/etl/management/commands/elasticsearch_indexer.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              frec_inst = FrecMap.objects.filter(
                    agency_identifier=agency_identifier,
                    main_account_code=row["Account Code"],
                    sub_function_code=row["Subfunction Code"],
              Severity: Minor
              Found in usaspending_api/etl/management/commands/load_budget_authority.py and 1 other location - About 35 mins to fix
              usaspending_api/etl/management/commands/load_budget_authority.py on lines 121..124

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      frec_inst = FrecMap.objects.filter(
            agency_identifier=agency_identifier,
            main_account_code=row["Account Code"],
            sub_function_code=row["Subfunction Code"],
              Severity: Minor
              Found in usaspending_api/etl/management/commands/load_budget_authority.py and 1 other location - About 35 mins to fix
              usaspending_api/etl/management/commands/load_budget_authority.py on lines 146..149

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                                  return ~fy.get_filter_object(field)
              Severity: Minor
              Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                    return ~self.range_intersect(field, value)
                Severity: Major
                Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return ~Q(**q_kwargs)
                  Severity: Major
                  Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return q_obj
                    Severity: Major
                    Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return fy.get_filter_object(field)
                      Severity: Major
                      Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return self.range_intersect(field, value)
                        Severity: Major
                        Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return Q(**q_kwargs)
                          Severity: Major
                          Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return 4
                            Severity: Minor
                            Found in usaspending_api/etl/helpers.py - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language