Sign upLogin

fremag/MemoScope.Net

View on GitHub
Star
MemoScope/Core/ClrDump.cs

Summary

Maintainability
D
3 days
Test Coverage

File ClrDump.cs has 504 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System.Collections.Generic;
using System.Linq;
using MemoScope.Core.Dac;
using Microsoft.Diagnostics.Runtime;
using System;
Severity: Major
Found in MemoScope/Core/ClrDump.cs - About 1 day to fix

    Class ClrDump has 44 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public class ClrDump : IClrDump
    {
        static Logger logger = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType.FullName);

        private static int n = 0;
    Severity: Minor
    Found in MemoScope/Core/ClrDump.cs - About 6 hrs to fix

      Method GetFieldNameReferenceImpl has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public string GetFieldNameReferenceImpl(ulong refAddress, ulong address, bool prefixWithType)
        {
            ClrType type = GetObjectTypeImpl(address);
            if (type == null)
            {
      Severity: Minor
      Found in MemoScope/Core/ClrDump.cs - About 1 hr to fix

        Method GetBlockingObjects has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public List<BlockingObject> GetBlockingObjects()
        {
            List<BlockingObject> blockingObjects = new List<BlockingObject>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
        Severity: Minor
        Found in MemoScope/Core/ClrDump.cs - About 1 hr to fix

          Method GetClrRoots has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public List<ClrRoot> GetClrRoots()
        {
            List<ClrRoot> clrRoots = new List<ClrRoot>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
          Severity: Minor
          Found in MemoScope/Core/ClrDump.cs - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    public List<BlockingObject> GetBlockingObjects()
        {
            List<BlockingObject> blockingObjects = new List<BlockingObject>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
            Severity: Major
            Found in MemoScope/Core/ClrDump.cs and 1 other location - About 3 hrs to fix
            MemoScope/Core/ClrDump.cs on lines 488..518

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    public List<ClrRoot> GetClrRoots()
        {
            List<ClrRoot> clrRoots = new List<ClrRoot>();
            CancellationTokenSource source = new CancellationTokenSource();
            var token = source.Token;
            Severity: Major
            Found in MemoScope/Core/ClrDump.cs and 1 other location - About 3 hrs to fix
            MemoScope/Core/ClrDump.cs on lines 456..486

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status