gabrielbull/php-ups-api

View on GitHub

Showing 174 of 174 total issues

Method __construct has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(\stdClass $response = null)
    {
        $this->AddressExtendedInformation = [];

        if (null !== $response) {
Severity: Major
Found in src/Entity/UpdatedAddress.php - About 2 hrs to fix

    Method request has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function request($access, $request, $endpointurl, $operation = null, $wsdl = null)
        {
            // Check for operation
            if (is_null($operation)) {
                throw new \Exception('Operation is required');
    Severity: Major
    Found in src/SoapRequest.php - About 2 hrs to fix

      Shipment has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Shipment implements NodeInterface
      {
          const TRANSPORT_MODE_AIR = 1;
          const TRANSPORT_MODE_GROUND = 2;
          const TRANSPORT_MODE_RAIL = 3;
      Severity: Minor
      Found in src/Entity/Tradeability/Shipment.php - About 2 hrs to fix

        ShipTo has 24 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class ShipTo implements NodeInterface
        {
            /** @deprecated */
            public $LocationID;
            /** @deprecated */
        Severity: Minor
        Found in src/Entity/ShipTo.php - About 2 hrs to fix

          Function __construct has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($attributes = null)
              {
                  $this->address = new Address();
          
                  if (null !== $attributes) {
          Severity: Minor
          Found in src/Entity/Shipper.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($attributes = null)
              {
                  if (null !== $attributes) {
                      if (isset($attributes->FormType)) {
                          $this->setType($attributes->FormType);
          Severity: Minor
          Found in src/Entity/InternationalForms.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function createRequest(RateRequest $rateRequest)
              {
                  $shipment = $rateRequest->getShipment();
          
                  $document = $xml = new DOMDocument();
          Severity: Major
          Found in src/Rate.php - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function toNode(DOMDocument $document = null)
                {
                    if (null === $document) {
                        $document = new DOMDocument();
                    }
            Severity: Major
            Found in src/Entity/LabelMethod.php and 1 other location - About 2 hrs to fix
            src/Entity/POA.php on lines 44..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function toNode(DOMDocument $document = null)
                {
                    if (null === $document) {
                        $document = new DOMDocument();
                    }
            Severity: Major
            Found in src/Entity/POA.php and 1 other location - About 2 hrs to fix
            src/Entity/LabelMethod.php on lines 47..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method __construct has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct($response = null)
                {
                    $this->Service = new Service();
                    $this->BillingWeight = new BillingWeight();
                    $this->TransportationCharges = new Charges();
            Severity: Major
            Found in src/Entity/RatedShipment.php - About 2 hrs to fix

              Method __construct has 57 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($response = null)
                  {
                      $this->ShipmentReferenceNumber = new ShipmentReferenceNumber();
                      $this->PackageReferenceNumber = new PackageReferenceNumber();
                      $this->Service = new Service();
              Severity: Major
              Found in src/Entity/Generic.php - About 2 hrs to fix

                Function build has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function build(\stdClass $response = null)
                    {
                        if (null !== $response) {
                            if (isset($response->Arrival)) {
                                $this->Arrival = new Arrival($response->Arrival);
                Severity: Minor
                Found in src/Entity/EstimatedArrivalTrait.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __construct has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __construct(\stdClass $response = null)
                    {
                        $this->LabelLinkIndicator = null;
                
                        if (null !== $response) {
                Severity: Minor
                Found in src/Entity/LabelDelivery.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function __construct(\stdClass $response = null)
                    {
                        $this->PackageReferenceNumber = [];
                        $this->ShipmentReferenceNumber = [];
                        $this->Resolution = new Resolution();
                Severity: Major
                Found in src/Entity/Exception.php - About 2 hrs to fix

                  Method request has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function request($access, $request, $endpointurl)
                      {
                          $this->setAccess($access);
                          $this->setRequest($request);
                          $this->setEndpointUrl($endpointurl);
                  Severity: Major
                  Found in src/Request.php - About 2 hrs to fix

                    Method toNode has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function toNode(DOMDocument $document = null)
                        {
                            if (null === $document) {
                                $document = new DOMDocument();
                            }
                    Severity: Major
                    Found in src/Entity/ShipmentServiceOptions.php - About 2 hrs to fix

                      Method __construct has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function __construct($response = null)
                          {
                              $this->ShipmentReferenceNumber = new ShipmentReferenceNumber();
                              $this->PackageReferenceNumber = new PackageReferenceNumber();
                              $this->ActivityLocation = new ActivityLocation();
                      Severity: Major
                      Found in src/Entity/Delivery.php - About 2 hrs to fix

                        File ShipmentServiceOptions.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        namespace Ups\Entity;
                        
                        use DOMDocument;
                        Severity: Minor
                        Found in src/Entity/ShipmentServiceOptions.php - About 2 hrs to fix

                          File Shipment.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php
                          
                          namespace Ups\Entity;
                          
                          class Shipment
                          Severity: Minor
                          Found in src/Entity/Shipment.php - About 2 hrs to fix

                            Method __construct has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function __construct($response = null)
                                {
                                    $this->PackageReferenceNumber = new PackageReferenceNumber();
                                    $this->ShipmentReferenceNumber = new ShipmentReferenceNumber();
                                    $this->ActivityLocation = new ActivityLocation();
                            Severity: Minor
                            Found in src/Entity/Origin.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language