gabrielbull/php-ups-api

View on GitHub

Showing 174 of 174 total issues

Function toNode has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }
Severity: Minor
Found in src/Entity/InternationalForms.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(\stdClass $response = null)
    {
        $this->StatusType = new StatusType();
        $this->Manifest = new Manifest();
        $this->Origin = new Origin();
Severity: Minor
Found in src/Entity/SubscriptionFile.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($attributes = null)
    {
        $this->setPackagingType(new PackagingType(
            isset($attributes->PackagingType) ? $attributes->PackagingType : null)
        );
Severity: Minor
Found in src/Entity/Package.php - About 1 hr to fix

    Method toNode has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toNode(DOMDocument $document = null)
        {
            if (null === $document) {
                $document = new DOMDocument();
            }
    Severity: Minor
    Found in src/Entity/InternationalForms.php - About 1 hr to fix

      Method createRequest has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createRequest()
          {
              $xml = new DOMDocument();
              $xml->formatOutput = true;
      
      
      Severity: Minor
      Found in src/AddressValidation.php - About 1 hr to fix

        Method __construct has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct($response = null)
            {
                $this->CallTagARS = new CallTagARS();
        
                if (null !== $response) {
        Severity: Minor
        Found in src/Entity/ShipmentServiceOptions.php - About 1 hr to fix

          Method toNode has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toNode(DOMDocument $document = null)
              {
                  if (null === $document) {
                      $document = new DOMDocument();
                  }
          Severity: Minor
          Found in src/Entity/Tradeability/Shipment.php - About 1 hr to fix

            Function createRequest has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                private function createRequest(RateRequest $rateRequest)
                {
                    $shipment = $rateRequest->getShipment();
            
                    $document = $xml = new DOMDocument();
            Severity: Minor
            Found in src/Rate.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __construct(\stdClass $response = null)
                {
                    $this->LabelImageFormat = new LabelImageFormat();
            
                    if (null !== $response) {
            Severity: Minor
            Found in src/Entity/LabelImage.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __construct($parameters = null)
                {
                    if (null !== $parameters) {
                        if (isset($parameters->COD)) {
                            $this->setCOD(new COD($parameters->COD));
            Severity: Minor
            Found in src/Entity/PackageServiceOptions.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct(\stdClass $response = null)
                {
                    $this->TransitFrom = new Address();
                    $this->TransitTo = new Address();
                    $this->ShipmentWeight = new ShipmentWeight();
            Severity: Minor
            Found in src/Entity/TimeInTransitResponse.php - About 1 hr to fix

              Method createRequest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function createRequest(TimeInTransitRequest $timeInTransitRequest)
                  {
                      $xml = new DOMDocument();
                      $xml->formatOutput = true;
              
              
              Severity: Minor
              Found in src/TimeInTransit.php - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function __construct($response = null)
                    {
                        if (null !== $response) {
                            if (isset($response->LanguageCode)) {
                                $this->setLanguageCode($response->LanguageCode);
                Severity: Major
                Found in src/Entity/Translate.php and 2 other locations - About 1 hr to fix
                src/Entity/Product.php on lines 52..68
                src/Entity/ShipperFiled.php on lines 40..56

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php
                
                namespace Ups\Entity;
                
                class FailureNotification
                Severity: Major
                Found in src/Entity/FailureNotification.php and 2 other locations - About 1 hr to fix
                src/Entity/LabelSpecification.php on lines 1..26
                src/Entity/Receipt.php on lines 1..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function __construct($attributes = null)
                    {
                        if (null !== $attributes) {
                            if (isset($attributes->Description)) {
                                $this->setDescription1($attributes->Description);
                Severity: Major
                Found in src/Entity/Product.php and 2 other locations - About 1 hr to fix
                src/Entity/ShipperFiled.php on lines 40..56
                src/Entity/Translate.php on lines 52..68

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php
                
                namespace Ups\Entity;
                
                class Receipt
                Severity: Major
                Found in src/Entity/Receipt.php and 2 other locations - About 1 hr to fix
                src/Entity/FailureNotification.php on lines 1..26
                src/Entity/LabelSpecification.php on lines 1..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php
                
                namespace Ups\Entity;
                
                class LabelSpecification
                Severity: Major
                Found in src/Entity/LabelSpecification.php and 2 other locations - About 1 hr to fix
                src/Entity/FailureNotification.php on lines 1..26
                src/Entity/Receipt.php on lines 1..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function __construct($attributes = null)
                    {
                        if (null !== $attributes) {
                            if (isset($attributes->Code)) {
                                $this->setCode($attributes->Code);
                Severity: Major
                Found in src/Entity/ShipperFiled.php and 2 other locations - About 1 hr to fix
                src/Entity/Product.php on lines 52..68
                src/Entity/Translate.php on lines 52..68

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method createRequest has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function createRequest()
                    {
                        $xml = new DOMDocument();
                        $xml->formatOutput = true;
                
                
                Severity: Minor
                Found in src/Tracking.php - About 1 hr to fix

                  Method __construct has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function __construct(\stdClass $attributes = null)
                      {
                          $this->address = new Address();
                  
                          if (null !== $attributes) {
                  Severity: Minor
                  Found in src/Entity/ShipTo.php - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language