gabrielbull/php-ups-api

View on GitHub

Showing 176 of 176 total issues

Method toNode has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }
Severity: Minor
Found in src/Entity/Package.php - About 1 hr to fix

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
        {
            if (null !== $request) {
                $this->setRequest($request);
            }
    Severity: Major
    Found in src/Shipping.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct(
            $accessKey = null,
            $userId = null,
            $password = null,
            $useIntegration = false,
    Severity: Major
    Found in src/Tradeability.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
        {
            if (null !== $request) {
                $this->setRequest($request);
            }
    Severity: Major
    Found in src/Tracking.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
        {
            if (null !== $request) {
                $this->setRequest($request);
            }
    Severity: Major
    Found in src/Locator.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct(
            $accessKey = null,
            $userId = null,
            $password = null,
            $useIntegration = false,
    Severity: Major
    Found in src/AddressValidation.php and 7 other locations - About 1 hr to fix
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
        {
            if (null !== $request) {
                $this->setRequest($request);
            }
    Severity: Major
    Found in src/QuantumView.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
        {
            if (null !== $request) {
                $this->setRequest($request);
            }
    Severity: Major
    Found in src/TimeInTransit.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/SimpleAddressValidation.php on lines 45..57
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 8 locations. Consider refactoring.
    Open

        public function __construct(
            $accessKey = null,
            $userId = null,
            $password = null,
            $useIntegration = false,
    Severity: Major
    Found in src/SimpleAddressValidation.php and 7 other locations - About 1 hr to fix
    src/AddressValidation.php on lines 69..81
    src/Locator.php on lines 40..46
    src/QuantumView.php on lines 62..68
    src/Shipping.php on lines 54..60
    src/TimeInTransit.php on lines 31..37
    src/Tracking.php on lines 80..86
    src/Tradeability.php on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($attributes = null)
        {
            $this->address = new Address();
    
            if (null !== $attributes) {
    Severity: Minor
    Found in src/Entity/Shipper.php - About 1 hr to fix

      Method compileLabelSpecificationNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function compileLabelSpecificationNode(ShipmentRequestLabelSpecification $labelSpec)
          {
              $xml = new DOMDocument();
              $xml->formatOutput = true;
      
      
      Severity: Minor
      Found in src/Shipping.php - About 1 hr to fix

        Method toNode has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function toNode(DOMDocument $document = null)
            {
                if (null === $document) {
                    $document = new DOMDocument();
                }
        Severity: Minor
        Found in src/Entity/AddressKeyFormat.php - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          <?php
          
          namespace Ups\Entity;
          
          class LabelSpecification
          Severity: Major
          Found in src/Entity/LabelSpecification.php and 2 other locations - About 1 hr to fix
          src/Entity/FailureNotification.php on lines 1..26
          src/Entity/Receipt.php on lines 1..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          <?php
          
          namespace Ups\Entity;
          
          class FailureNotification
          Severity: Major
          Found in src/Entity/FailureNotification.php and 2 other locations - About 1 hr to fix
          src/Entity/LabelSpecification.php on lines 1..26
          src/Entity/Receipt.php on lines 1..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          <?php
          
          namespace Ups\Entity;
          
          class Receipt
          Severity: Major
          Found in src/Entity/Receipt.php and 2 other locations - About 1 hr to fix
          src/Entity/FailureNotification.php on lines 1..26
          src/Entity/LabelSpecification.php on lines 1..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct(\stdClass $response = null)
              {
                  $this->ServiceSummary = [];
          
                  if (null !== $response) {
          Severity: Minor
          Found in src/Entity/RateTimeInTransitResponse.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct(\stdClass $response = null)
              {
                  if (null !== $response) {
                      $this->build($response);
                      if (isset($response->BusinessTransitDays)) {
          Severity: Minor
          Found in src/Entity/EstimatedArrival.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct(\stdClass $response = null)
              {
                  $this->BillingWeight = new BillingWeight();
                  $this->TransportationCharges = new Charges();
                  $this->ServiceOptionsCharges = new Charges();
          Severity: Minor
          Found in src/Entity/RatedPackage.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($attributes = null)
              {
                  if (null !== $attributes) {
                      if (isset($attributes->Code)) {
                          $this->setCode($attributes->Code);
          Severity: Minor
          Found in src/Entity/EEIFilingOption.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($response = null)
              {
                  $this->RatedShipment = [];
          
                  if (null !== $response) {
          Severity: Minor
          Found in src/Entity/RateResponse.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language