gabrielbull/php-ups-api

View on GitHub

Showing 174 of 174 total issues

Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($attributes = null)
    {
        if (null !== $attributes) {
            if (isset($attributes->FormType)) {
                $this->setType($attributes->FormType);
Severity: Minor
Found in src/Entity/InternationalForms.php - About 1 hr to fix

    Method validate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function validate(Address $address, $requestOption = self::REQUEST_OPTION_ADDRESS_VALIDATION, $maxSuggestion = 15)
        {
            if ($maxSuggestion > 50) {
                throw new \Exception('Maximum of 50 suggestions allowed');
            }
    Severity: Minor
    Found in src/AddressValidation.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct($response = null)
          {
              $this->SubscriptionEvents = [];
      
              if (null !== $response) {
      Severity: Minor
      Found in src/Entity/QuantumViewEvents.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compileLabelSpecificationNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function compileLabelSpecificationNode(ShipmentRequestLabelSpecification $labelSpec)
          {
              $xml = new DOMDocument();
              $xml->formatOutput = true;
      
      
      Severity: Minor
      Found in src/Shipping.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toNode(DOMDocument $document = null)
          {
              if (null === $document) {
                  $document = new DOMDocument();
              }
      Severity: Minor
      Found in src/Entity/Package.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function request has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function request($access, $request, $endpointurl)
          {
              $this->setAccess($access);
              $this->setRequest($request);
              $this->setEndpointUrl($endpointurl);
      Severity: Minor
      Found in src/Request.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSubscription has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getSubscription($name = null, $beginDateTime = null, $endDateTime = null, $fileName = null, $bookmark = null)
          {
              // Format date times
              if (null !== $beginDateTime) {
                  $beginDateTime = $this->formatDateTime($beginDateTime);
      Severity: Minor
      Found in src/QuantumView.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(\stdClass $response = null)
          {
              $this->LabelLinkIndicator = null;
      
              if (null !== $response) {
      Severity: Minor
      Found in src/Entity/LabelDelivery.php - About 1 hr to fix

        Method isMailInnovations has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function isMailInnovations()
            {
                $patterns = [
        
                    // UPS Mail Innovations tracking numbers
        Severity: Minor
        Found in src/Tracking.php - About 1 hr to fix

          Method recoverLabel has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function recoverLabel($trackingData, $labelSpecification = null, $labelDelivery = null, $translate = null)
              {
                  if (is_array($trackingData)) {
                      if (!isset($trackingData['value'])) {
                          throw new InvalidArgumentException('$trackingData parameter is required to contain `value`.');
          Severity: Minor
          Found in src/Shipping.php - About 1 hr to fix

            Method build has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function build(\stdClass $response = null)
                {
                    if (null !== $response) {
                        if (isset($response->Arrival)) {
                            $this->Arrival = new Arrival($response->Arrival);
            Severity: Minor
            Found in src/Entity/EstimatedArrivalTrait.php - About 1 hr to fix

              Method toNode has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function toNode(DOMDocument $document = null)
                  {
                      if (null === $document) {
                          $document = new DOMDocument();
                      }
              Severity: Minor
              Found in src/Entity/EmailMessage.php - About 1 hr to fix

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct(
                        $accessKey = null,
                        $userId = null,
                        $password = null,
                        $useIntegration = false,
                Severity: Major
                Found in src/Tradeability.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
                    {
                        if (null !== $request) {
                            $this->setRequest($request);
                        }
                Severity: Major
                Found in src/TimeInTransit.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
                    {
                        if (null !== $request) {
                            $this->setRequest($request);
                        }
                Severity: Major
                Found in src/Tracking.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct(
                        $accessKey = null,
                        $userId = null,
                        $password = null,
                        $useIntegration = false,
                Severity: Major
                Found in src/SimpleAddressValidation.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
                    {
                        if (null !== $request) {
                            $this->setRequest($request);
                        }
                Severity: Major
                Found in src/QuantumView.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
                    {
                        if (null !== $request) {
                            $this->setRequest($request);
                        }
                Severity: Major
                Found in src/Locator.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct($accessKey = null, $userId = null, $password = null, $useIntegration = false, RequestInterface $request = null, LoggerInterface $logger = null)
                    {
                        if (null !== $request) {
                            $this->setRequest($request);
                        }
                Severity: Major
                Found in src/Shipping.php and 7 other locations - About 1 hr to fix
                src/AddressValidation.php on lines 69..81
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 8 locations. Consider refactoring.
                Open

                    public function __construct(
                        $accessKey = null,
                        $userId = null,
                        $password = null,
                        $useIntegration = false,
                Severity: Major
                Found in src/AddressValidation.php and 7 other locations - About 1 hr to fix
                src/Locator.php on lines 40..46
                src/QuantumView.php on lines 62..68
                src/Shipping.php on lines 54..60
                src/SimpleAddressValidation.php on lines 45..57
                src/TimeInTransit.php on lines 31..37
                src/Tracking.php on lines 80..86
                src/Tradeability.php on lines 49..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language