Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star

Showing 191 of 191 total issues

Function update_additional_object_fields has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    protected function update_additional_object_fields( $access_plan, $request, $schema, $prepared_item, $creating = true ) {

        $error = new WP_Error();

        // Will contain the properties to set.
Severity: Minor
Found in includes/server/class-llms-rest-access-plans-controller.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_additional_object_fields has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function update_additional_object_fields( $course, $request, $schema, $prepared_item, $creating = true ) {

        $error = new WP_Error();

        // Course catalog visibility.
Severity: Major
Found in includes/server/class-llms-rest-courses-controller.php - About 4 hrs to fix

    Method get_hooks has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_hooks() {

        $hooks = array(

            // Courses.
    Severity: Major
    Found in includes/class-llms-rest-webhooks.php - About 4 hrs to fix

      Method get_fields has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function get_fields() {

        require_once 'tables/class-llms-rest-table-webhooks.php';

        $add_hook = '1' === llms_filter_input( INPUT_GET, 'add-webhook', FILTER_SANITIZE_NUMBER_INT );
      Severity: Major
      Found in includes/admin/class-llms-rest-admin-settings-webhooks.php - About 4 hrs to fix

        File class-llms-rest-access-plans-controller.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * REST Access Plans Controller
 *
 * @package LifterLMS_REST/Classes/Controllers
        Severity: Minor
        Found in includes/server/class-llms-rest-access-plans-controller.php - About 4 hrs to fix

          Function prepare_item_for_database has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function prepare_item_for_database( $request ) {

        $prepared_item = array();

        // LLMS Post ID.
          Severity: Minor
          Found in includes/abstracts/class-llms-rest-posts-controller.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          LLMS_REST_Enrollments_Controller has 34 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class LLMS_REST_Enrollments_Controller extends LLMS_REST_Controller {

    /**
     * Route base.
     *
          Severity: Minor
          Found in includes/server/class-llms-rest-enrollments-controller.php - About 4 hrs to fix

            Function prepare_item_for_database has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
            Severity: Minor
            Found in includes/server/class-llms-rest-lessons-controller.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_objects_query has 103 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function get_objects_query( $query_args, $request = null ) {

        global $wpdb;

        // Maybe limit the query results depending on the page param.
            Severity: Major
            Found in includes/server/class-llms-rest-enrollments-controller.php - About 4 hrs to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          'enrollment_opens_message'  => array(
                'description' => __( 'Message displayed to visitors when attempting to enroll into a course before the enrollment_opens_date has passed.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
              Severity: Major
              Found in includes/server/class-llms-rest-courses-controller.php and 3 other locations - About 4 hrs to fix
              includes/server/class-llms-rest-courses-controller.php on lines 373..395
              includes/server/class-llms-rest-courses-controller.php on lines 407..429
              includes/server/class-llms-rest-courses-controller.php on lines 441..463

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          'access_closes_message'     => array(
                'description' => __( 'Message displayed to enrolled students when the course is accessed after the access_closes_date has passed.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
              Severity: Major
              Found in includes/server/class-llms-rest-courses-controller.php and 3 other locations - About 4 hrs to fix
              includes/server/class-llms-rest-courses-controller.php on lines 407..429
              includes/server/class-llms-rest-courses-controller.php on lines 441..463
              includes/server/class-llms-rest-courses-controller.php on lines 475..497

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          'access_opens_message'      => array(
                'description' => __( 'Message displayed to enrolled students when the course is accessed before the access_opens_date has passed.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
              Severity: Major
              Found in includes/server/class-llms-rest-courses-controller.php and 3 other locations - About 4 hrs to fix
              includes/server/class-llms-rest-courses-controller.php on lines 373..395
              includes/server/class-llms-rest-courses-controller.php on lines 441..463
              includes/server/class-llms-rest-courses-controller.php on lines 475..497

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          'enrollment_closes_message' => array(
                'description' => __( 'Message displayed to visitors when attempting to enroll into a course after the enrollment_closes_date has passed.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
              Severity: Major
              Found in includes/server/class-llms-rest-courses-controller.php and 3 other locations - About 4 hrs to fix
              includes/server/class-llms-rest-courses-controller.php on lines 373..395
              includes/server/class-llms-rest-courses-controller.php on lines 407..429
              includes/server/class-llms-rest-courses-controller.php on lines 475..497

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function prepare_collection_query_search_args has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function prepare_collection_query_search_args( $prepared, $request ) {

        // Search?
        if ( ! empty( $prepared['search'] ) ) {
              Severity: Minor
              Found in includes/abstracts/class-llms-rest-controller.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_additional_object_fields has 92 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function update_additional_object_fields( $access_plan, $request, $schema, $prepared_item, $creating = true ) {

        $error = new WP_Error();

        // Will contain the properties to set.
              Severity: Major
              Found in includes/server/class-llms-rest-access-plans-controller.php - About 3 hrs to fix

                LLMS_REST_Controller has 29 functions (exceeds 20 allowed). Consider refactoring.
                Open

                abstract class LLMS_REST_Controller extends LLMS_REST_Controller_Stubs {

    /**
     * Endpoint namespace.
     *
                Severity: Minor
                Found in includes/abstracts/class-llms-rest-controller.php - About 3 hrs to fix

                  Function prepare_item_for_database has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
                  Severity: Minor
                  Found in includes/server/class-llms-rest-courses-controller.php - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File class-llms-rest-webhooks.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
/**
 * CRUD Webhooks
 *
 * @package LifterLMS_REST/Classes
                  Severity: Minor
                  Found in includes/class-llms-rest-webhooks.php - About 3 hrs to fix

                    Method get_item_schema_base has 82 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function get_item_schema_base() {

        return array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'webhook',
                    Severity: Major
                    Found in includes/server/class-llms-rest-webhooks-controller.php - About 3 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  'capacity_message'          => array(
                'description' => __( 'Message displayed when enrollment capacity has been reached.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
                      Severity: Major
                      Found in includes/server/class-llms-rest-courses-controller.php and 1 other location - About 3 hrs to fix
                      includes/server/class-llms-rest-courses-controller.php on lines 316..337

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 147.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language