gocodebox/lifterlms-rest

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( ! empty( $schema['properties']['instructors'] ) ) {

            $instructors = array();

            if ( isset( $request['instructors'] ) ) {

Found in includes/server/class-llms-rest-memberships-controller.php and 1 other location - About 2 hrs to fix

Read up
Read up

includes/server/class-llms-rest-courses-controller.php on lines 834..856

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( ! empty( $schema['properties']['instructors'] ) ) {

            $instructors = array();

            if ( isset( $request['instructors'] ) ) {

Found in includes/server/class-llms-rest-courses-controller.php and 1 other location - About 2 hrs to fix

Read up
Read up

includes/server/class-llms-rest-memberships-controller.php on lines 617..639

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `get_item_schema_base` has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_item_schema_base() {

        return array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'students-progress',

Found in includes/server/class-llms-rest-students-progress-controller.php - About 1 hr to fix

Function `create_item` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function create_item( $request ) {

        $schema = $this->get_item_schema();

        $prepared_item = $this->prepare_item_for_database( $request );

Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `get_collection_params` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_collection_params() {

        $query_params = parent::get_collection_params();

        $query_params['context']['default'] = 'view';

Found in includes/abstracts/class-llms-rest-controller.php - About 1 hr to fix

Method `delivery_after` has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function delivery_after( $delivery_id, $req_args, $res, $duration ) {

        // Parse response.
        if ( is_wp_error( $res ) ) {
            $res_code    = $res->get_error_code();

Found in includes/models/class-llms-rest-webhook.php - About 1 hr to fix

Method `get_item_schema_base` has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_item_schema_base() {

        return array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'api_key',

Found in includes/server/class-llms-rest-api-keys-controller.php - About 1 hr to fix

Method `prepare_links` has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_links( $lesson, $request ) {

        $links = parent::prepare_links( $lesson, $request );

        unset( $links['content'] );

Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

Function `update_item` has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function update_item( $request ) {

        $student_id = (int) $request['id'];
        $post_id    = (int) $request['post_id'];

Found in includes/server/class-llms-rest-enrollments-controller.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `get_fields` has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static function get_fields() {

        require_once 'tables/class-llms-rest-table-webhooks.php';

        $add_hook = '1' === llms_filter_input( INPUT_GET, 'add-webhook', FILTER_SANITIZE_NUMBER_INT );

Found in includes/admin/class-llms-rest-admin-settings-webhooks.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `update_item` has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update_item( $request ) {

        $object = $this->get_object( (int) $request['id'] );
        if ( is_wp_error( $object ) ) {
            return $object;

Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

Method `prepare_links` has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_links( $course, $request ) {

        $links     = parent::prepare_links( $course, $request );
        $course_id = $course->get( 'id' );

Found in includes/server/class-llms-rest-courses-controller.php - About 1 hr to fix

Method `get_topics` has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_topics() {

        /**
         * Filter the available webhook topics.
         *

Found in includes/class-llms-rest-webhooks.php - About 1 hr to fix

Method `delete_item` has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function delete_item( $request ) {

        $object   = $this->get_object( (int) $request['id'] );
        $response = new WP_REST_Response();
        $response->set_status( 204 );

Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

Method `update_item` has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update_item( $request ) {

        $student_id = (int) $request['id'];
        $post_id    = (int) $request['post_id'];

Found in includes/server/class-llms-rest-enrollments-controller.php - About 1 hr to fix

Function `prepare_item_for_database` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_item_for_database( $request ) {
        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();

        // Restriction action.

Found in includes/server/class-llms-rest-memberships-controller.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `get_objects_query` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function get_objects_query( $query_args, $request = null ) {

        global $wpdb;

        // Maybe limit the query results depending on the page param.

Found in includes/server/class-llms-rest-enrollments-controller.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `check_assign_terms_permission` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function check_assign_terms_permission( $request ) {
        $taxonomies = wp_list_filter( get_object_taxonomies( $this->post_type, 'objects' ), array( 'show_in_llms_rest' => true ) );
        foreach ( $taxonomies as $taxonomy ) {
            $base = $this->get_taxonomy_rest_base( $taxonomy );

Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `prepare_object_for_response` has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_object_for_response( $membership, $request ) {
        $data    = parent::prepare_object_for_response( $membership, $request );
        $context = $request->get_param( 'context' );

        // Auto enroll.

Found in includes/server/class-llms-rest-memberships-controller.php - About 1 hr to fix

Method `register_routes` has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register_routes() {

        parent::register_routes();

        register_rest_route(

Found in includes/server/class-llms-rest-courses-controller.php - About 1 hr to fix