Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star

Showing 191 of 191 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            'length'                    => array(
                'description' => __( 'User defined course length.', 'lifterlms' ),
                'type'        => 'object',
                'context'     => array( 'view', 'edit' ),
                'arg_options' => array(
Severity: Major
Found in includes/server/class-llms-rest-courses-controller.php and 1 other location - About 3 hrs to fix
includes/server/class-llms-rest-courses-controller.php on lines 278..299

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method prepare_object_for_response has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_object_for_response( $course, $request ) {

        $data = parent::prepare_object_for_response( $course, $request );

        // Catalog visibility.
Severity: Major
Found in includes/server/class-llms-rest-courses-controller.php - About 2 hrs to fix

    Function get_fields has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function get_fields() {

        require_once 'tables/class-llms-rest-table-api-keys.php';

        $add_key = '1' === llms_filter_input( INPUT_GET, 'add-key', FILTER_SANITIZE_NUMBER_INT );
    Severity: Minor
    Found in includes/admin/class-llms-rest-admin-settings-api-keys.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_item_for_database has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
    Severity: Major
    Found in includes/server/class-llms-rest-lessons-controller.php - About 2 hrs to fix

      Method prepare_item_for_database has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function prepare_item_for_database( $request ) {

        $prepared_item = array();

        // LLMS Post ID.
      Severity: Major
      Found in includes/abstracts/class-llms-rest-posts-controller.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            'properties'  => array(
                        'rendered'  => array(
                            'description' => __( 'Rendered HTML excerpt.', 'lifterlms' ),
                            'type'        => 'string',
                            'context'     => array( 'view', 'edit' ),
        Severity: Major
        Found in includes/abstracts/class-llms-rest-posts-controller.php and 1 other location - About 2 hrs to fix
        includes/abstracts/class-llms-rest-posts-controller.php on lines 1182..1200

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 133.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            'properties'  => array(
                        'rendered'  => array(
                            'description' => __( 'Rendered HTML content.', 'lifterlms' ),
                            'type'        => 'string',
                            'context'     => array( 'view', 'edit' ),
        Severity: Major
        Found in includes/abstracts/class-llms-rest-posts-controller.php and 1 other location - About 2 hrs to fix
        includes/abstracts/class-llms-rest-posts-controller.php on lines 1210..1228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 133.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File class-llms-rest-students-progress-controller.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * REST Controller for Student Progress.
 *
 * @package LifterLMS_REST/Classes
        Severity: Minor
        Found in includes/server/class-llms-rest-students-progress-controller.php - About 2 hrs to fix

          Method update_additional_object_fields has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function update_additional_object_fields( $membership, $request, $schema, $prepared_item, $creating = true ) {
        $error = new WP_Error();

        // Auto enroll.
        if ( ! empty( $schema['properties']['auto_enroll'] ) && isset( $request['auto_enroll'] ) ) {
          Severity: Major
          Found in includes/server/class-llms-rest-memberships-controller.php - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    register_rest_route(
            $this->namespace,
            '/' . $this->rest_base . '/(?P<id>[\d]+)/enrollments',
            array(
                'args'   => array(
            Severity: Major
            Found in includes/server/class-llms-rest-memberships-controller.php and 1 other location - About 2 hrs to fix
            includes/server/class-llms-rest-courses-controller.php on lines 127..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    register_rest_route(
            $this->namespace,
            '/' . $this->rest_base . '/(?P<id>[\d]+)/enrollments',
            array(
                'args'   => array(
            Severity: Major
            Found in includes/server/class-llms-rest-courses-controller.php and 1 other location - About 2 hrs to fix
            includes/server/class-llms-rest-memberships-controller.php on lines 566..584

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            LLMS_REST_API_Keys_Controller has 21 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class LLMS_REST_API_Keys_Controller extends LLMS_REST_Controller {

    /**
     * Route base.
     *
            Severity: Minor
            Found in includes/server/class-llms-rest-api-keys-controller.php - About 2 hrs to fix

              Method prepare_item_for_database has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();
              Severity: Major
              Found in includes/server/class-llms-rest-courses-controller.php - About 2 hrs to fix

                Function is_valid_resource has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function is_valid_resource( $args ) {

        $resource = $this->get_resource();

        if ( in_array( $resource, LLMS_REST_API()->webhooks()->get_post_type_resources(), true ) ) {
                Severity: Minor
                Found in includes/models/class-llms-rest-webhook.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method get_filters_to_be_removed_for_response has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function get_filters_to_be_removed_for_response( $course ) {

        $filters = array();

        if ( llms_blocks_is_post_migrated( $course->get( 'id' ) ) ) {
                Severity: Major
                Found in includes/server/class-llms-rest-courses-controller.php - About 2 hrs to fix

                  Method prepare_object_for_response has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function prepare_object_for_response( $access_plan, $request ) {

        $data    = parent::prepare_object_for_response( $access_plan, $request );
        $context = $request->get_param( 'context' );
                  Severity: Major
                  Found in includes/server/class-llms-rest-access-plans-controller.php - About 2 hrs to fix

                    Method create_item has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function create_item( $request ) {

        $schema = $this->get_item_schema();

        $prepared_item = $this->prepare_item_for_database( $request );
                    Severity: Major
                    Found in includes/abstracts/class-llms-rest-posts-controller.php - About 2 hrs to fix

                      Method register_routes has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function register_routes() {

        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
                      Severity: Minor
                      Found in includes/abstracts/class-llms-rest-controller.php - About 2 hrs to fix

                        Method register_routes has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function register_routes() {

        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
                        Severity: Minor
                        Found in includes/server/class-llms-rest-enrollments-controller.php - About 2 hrs to fix

                          Method get_item_schema_base has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function get_item_schema_base() {

        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'students-enrollments',
                          Severity: Minor
                          Found in includes/server/class-llms-rest-enrollments-controller.php - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language