Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star

Showing 191 of 191 total issues

Function update_additional_object_fields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function update_additional_object_fields( $lesson, $request, $schema, $prepared_item, $creating = true ) {

        $error = new WP_Error();

        $to_set = array();
Severity: Minor
Found in includes/server/class-llms-rest-lessons-controller.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_webhook_upsert has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handle_webhook_upsert() {

        $data = array(
            'name'         => llms_filter_input_sanitize_string( INPUT_POST, 'llms_rest_webhook_name' ),
            'status'       => llms_filter_input_sanitize_string( INPUT_POST, 'llms_rest_webhook_status' ),
Severity: Minor
Found in includes/admin/class-llms-rest-admin-form-controller.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function check_read_permission has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function check_read_permission( $object ) {

        if ( is_wp_error( $object ) ) {
            return false;
        }
Severity: Minor
Found in includes/abstracts/class-llms-rest-posts-controller.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepare_item_for_database has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_item_for_database( $request ) {

        $prepared_item = parent::prepare_item_for_database( $request );

        $schema = $this->get_item_schema();
Severity: Minor
Found in includes/server/class-llms-rest-sections-controller.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function get_data( $key, $api_key ) {

        switch ( $key ) {

            case 'description':
Severity: Minor
Found in includes/admin/tables/class-llms-rest-table-api-keys.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_additional_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function update_additional_data( $object_id, $prepared, $request ) {

        $object = $this->get_object( $object_id );

        if ( is_wp_error( $object ) ) {
Severity: Minor
Found in includes/abstracts/class-llms-rest-users-controller.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_status_param has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handle_status_param( $status ) {

        $post_type_object = get_post_type_object( $this->post_type );
        $post_type_name   = $post_type_object->labels->name;
Severity: Minor
Found in includes/abstracts/class-llms-rest-posts-controller.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_item_permissions_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function get_item_permissions_check( $request ) {

        $object = $this->get_object( (int) $request['id'] );
        if ( is_wp_error( $object ) ) {
            return $object;
Severity: Minor
Found in includes/abstracts/class-llms-rest-posts-controller.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_events has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle_events() {

        if ( llms_verify_nonce( 'key-revoke-nonce', 'revoke', 'GET' ) ) {
            $delete = LLMS_REST_API()->keys()->delete( llms_filter_input( INPUT_GET, 'revoke-key', FILTER_VALIDATE_INT ) );
            if ( $delete ) {
Severity: Minor
Found in includes/admin/class-llms-rest-admin-form-controller.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepare_collection_query_args has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_collection_query_args( $request ) {

        $args   = array();
        $params = $this->get_collection_params();
Severity: Minor
Found in includes/server/class-llms-rest-api-keys-controller.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sql_where has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function sql_where() {

        global $wpdb;

        $sql = 'WHERE 1';
Severity: Minor
Found in includes/class-llms-rest-webhooks-query.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sql_where has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function sql_where() {

        global $wpdb;

        $sql = 'WHERE 1';
Severity: Minor
Found in includes/class-llms-rest-api-keys-query.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( ! empty( $schema['properties']['sales_page_page_id'] ) && isset( $request['sales_page_page_id'] ) ) {
            $page = get_post( $request['sales_page_page_id'] );
            if ( $page && is_a( $page, 'WP_Post' ) ) {
                $prepared_item['sales_page_content_page_id'] = $request['sales_page_page_id'];
            } else {
Severity: Minor
Found in includes/server/class-llms-rest-memberships-controller.php and 1 other location - About 40 mins to fix
includes/server/class-llms-rest-memberships-controller.php on lines 348..355

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function get_webhooks() {

        $hooks   = array();
        $results = $this->get_results();
Severity: Minor
Found in includes/class-llms-rest-webhooks-query.php and 1 other location - About 40 mins to fix
includes/class-llms-rest-api-keys-query.php on lines 72..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function get_keys() {

        $keys    = array();
        $results = $this->get_results();
Severity: Minor
Found in includes/class-llms-rest-api-keys-query.php and 1 other location - About 40 mins to fix
includes/class-llms-rest-webhooks-query.php on lines 70..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( ! empty( $schema['properties']['restriction_page_id'] ) && isset( $request['restriction_page_id'] ) ) {
            $page = get_post( $request['restriction_page_id'] );
            if ( $page && is_a( $page, 'WP_Post' ) ) {
                $prepared_item['redirect_page_id'] = $request['restriction_page_id'];
            } else {
Severity: Minor
Found in includes/server/class-llms-rest-memberships-controller.php and 1 other location - About 40 mins to fix
includes/server/class-llms-rest-memberships-controller.php on lines 363..370

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method update_additional_object_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function update_additional_object_fields( $lesson, $request, $schema, $prepared_item, $creating = true ) {
Severity: Minor
Found in includes/server/class-llms-rest-lessons-controller.php - About 35 mins to fix

    Method update_additional_object_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function update_additional_object_fields( $membership, $request, $schema, $prepared_item, $creating = true ) {
    Severity: Minor
    Found in includes/server/class-llms-rest-memberships-controller.php - About 35 mins to fix

      Method update_additional_object_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function update_additional_object_fields( $course, $request, $schema, $prepared_item, $creating = true ) {
      Severity: Minor
      Found in includes/server/class-llms-rest-courses-controller.php - About 35 mins to fix

        Method update_additional_object_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function update_additional_object_fields( $access_plan, $request, $schema, $prepared_item, $creating = true ) {
        Severity: Minor
        Found in includes/server/class-llms-rest-access-plans-controller.php - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language