Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star

Showing 191 of 191 total issues

Method handle_webhook_upsert has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handle_webhook_upsert() {

        $data = array(
            'name'         => llms_filter_input_sanitize_string( INPUT_POST, 'llms_rest_webhook_name' ),
            'status'       => llms_filter_input_sanitize_string( INPUT_POST, 'llms_rest_webhook_status' ),
Severity: Minor
Found in includes/admin/class-llms-rest-admin-form-controller.php - About 1 hr to fix

    Method sql_where has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function sql_where() {

        global $wpdb;

        $sql = 'WHERE 1';
    Severity: Minor
    Found in includes/class-llms-rest-webhooks-query.php - About 1 hr to fix

      Method deliver has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function deliver( $args ) {

        $start   = microtime( true );
        $payload = $this->get_payload( $args );
      Severity: Minor
      Found in includes/models/class-llms-rest-webhook.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function get_collection_params() {

        $params = parent::get_collection_params();

        $params['post_in'] = array(
        Severity: Major
        Found in includes/server/class-llms-rest-instructors-controller.php and 1 other location - About 1 hr to fix
        includes/server/class-llms-rest-students-controller.php on lines 104..125

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function get_collection_params() {

        $params = parent::get_collection_params();

        $params['enrolled_in'] = array(
        Severity: Major
        Found in includes/server/class-llms-rest-students-controller.php and 1 other location - About 1 hr to fix
        includes/server/class-llms-rest-instructors-controller.php on lines 121..142

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( ! empty( $schema['properties']['parent_id'] ) && isset( $request['parent_id'] ) ) {

            $parent_course = llms_get_post( $request['parent_id'] );

            if ( ! $parent_course || ! is_a( $parent_course, 'LLMS_Course' ) ) {
        Severity: Major
        Found in includes/server/class-llms-rest-sections-controller.php and 1 other location - About 1 hr to fix
        includes/server/class-llms-rest-lessons-controller.php on lines 163..172

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( ! empty( $schema['properties']['course_id'] ) && isset( $request['course_id'] ) ) {

            $parent_course = llms_get_post( $request['course_id'] );

            if ( ! $parent_course || ! is_a( $parent_course, 'LLMS_Course' ) ) {
        Severity: Major
        Found in includes/server/class-llms-rest-lessons-controller.php and 1 other location - About 1 hr to fix
        includes/server/class-llms-rest-sections-controller.php on lines 205..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function delivery_after has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function delivery_after( $delivery_id, $req_args, $res, $duration ) {

        // Parse response.
        if ( is_wp_error( $res ) ) {
            $res_code    = $res->get_error_code();
        Severity: Minor
        Found in includes/models/class-llms-rest-webhook.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function check_roles_permissions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function check_roles_permissions( $request ) {

        global $wp_roles;

        $schema = $this->get_item_schema();
        Severity: Minor
        Found in includes/abstracts/class-llms-rest-users-controller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepare_object_for_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function prepare_object_for_response( $access_plan, $request ) {

        $data    = parent::prepare_object_for_response( $access_plan, $request );
        $context = $request->get_param( 'context' );
        Severity: Minor
        Found in includes/server/class-llms-rest-access-plans-controller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_payload has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function get_payload( $args ) {

        // Switch current user to the user who created the webhook.
        $current_user = get_current_user_id();
        wp_set_current_user( $this->get( 'user_id' ) );
        Severity: Minor
        Found in includes/abstracts/class-llms-rest-webhook-data.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function( source, options ) {

    const
        opts = Object.assign( {
            indent: '  '
        Severity: Minor
        Found in .bin/httpsnippet-client-for-llms-node-api.js - About 1 hr to fix

          Method get_payload has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function get_payload( $args ) {

        // Switch current user to the user who created the webhook.
        $current_user = get_current_user_id();
        wp_set_current_user( $this->get( 'user_id' ) );
          Severity: Minor
          Found in includes/abstracts/class-llms-rest-webhook-data.php - About 1 hr to fix

            Method prepare_object_for_response has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function prepare_object_for_response( $lesson, $request ) {

        $data = parent::prepare_object_for_response( $lesson, $request );

        // Audio Embed.
            Severity: Minor
            Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

              Method check_roles_permissions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function check_roles_permissions( $request ) {

        global $wp_roles;

        $schema = $this->get_item_schema();
              Severity: Minor
              Found in includes/abstracts/class-llms-rest-users-controller.php - About 1 hr to fix

                Method get_objects_query has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function get_objects_query( $prepared, $request ) {

        if ( 'id' === $prepared['orderby'] ) {
            $prepared['orderby'] = 'ID';
        } elseif ( 'registered_date' === $prepared['orderby'] ) {
                Severity: Minor
                Found in includes/abstracts/class-llms-rest-users-controller.php - About 1 hr to fix

                  Method update_additional_data has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function update_additional_data( $object_id, $prepared, $request ) {

        $object = $this->get_object( $object_id );

        if ( is_wp_error( $object ) ) {
                  Severity: Minor
                  Found in includes/abstracts/class-llms-rest-users-controller.php - About 1 hr to fix

                    Function unset_subordinate_props has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function unset_subordinate_props( &$to_set, $saved_props ) {

        // Merge new properties to set and saved props.
        $props = wp_parse_args( $to_set, $saved_props );
                    Severity: Minor
                    Found in includes/server/class-llms-rest-access-plans-controller.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prepare_items_query has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function prepare_items_query( $prepared_args = array(), $request = null ) {

        $query_args = array();

        foreach ( $prepared_args as $key => $value ) {
                    Severity: Minor
                    Found in includes/server/class-llms-rest-enrollments-controller.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prepare_links has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function prepare_links( $object, $request ) {

        $links = parent::prepare_links( $object, $request );

        $object_id = $object->get( 'id' );
                    Severity: Minor
                    Found in includes/abstracts/class-llms-rest-posts-controller.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language