Sign upLogin

gocodebox/lifterlms-rest

View on GitHub
Star

Showing 191 of 191 total issues

Method prepare_links has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_links( $membership, $request ) {

        $links = parent::prepare_links( $membership, $request );
        unset( $links['content'] );
        $id = $membership->get( 'id' );
Severity: Minor
Found in includes/server/class-llms-rest-memberships-controller.php - About 1 hr to fix

    Method get_item_schema_base has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema_base() {

        $schema = parent::get_item_schema_base();

        // Section's title.
    Severity: Minor
    Found in includes/server/class-llms-rest-sections-controller.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $settings[] = array(
            'title' => $key_id || $add_key ? __( 'API Key Details', 'lifterlms' ) : __( 'API Keys', 'lifterlms' ),
            'type'  => 'title-with-html',
            'id'    => 'rest_keys_options_title',
            'html'  => $key_id || $add_key ? '' : '<a href="' . esc_url( admin_url( 'admin.php?page=llms-settings&tab=rest-api&section=keys&add-key=1' ) ) . '" class="llms-button-primary small" type="submit" style="top:-2px;">' . __( 'Add API Key', 'lifterlms' ) . '</a>',
      Severity: Major
      Found in includes/admin/class-llms-rest-admin-settings-api-keys.php and 1 other location - About 1 hr to fix
      includes/admin/class-llms-rest-admin-settings-webhooks.php on lines 43..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $settings[] = array(
            'title' => $hook_id || $add_hook ? __( 'Webhook Details', 'lifterlms' ) : __( 'Webhooks', 'lifterlms' ),
            'type'  => 'title-with-html',
            'id'    => 'rest_hooks_options_title',
            'html'  => $hook_id || $add_hook ? '' : '<a href="' . esc_url( admin_url( 'admin.php?page=llms-settings&tab=rest-api&section=webhooks&add-webhook=1' ) ) . '" class="llms-button-primary small" type="submit" style="top:-2px;">' . __( 'Add Webhook', 'lifterlms' ) . '</a>',
      Severity: Major
      Found in includes/admin/class-llms-rest-admin-settings-webhooks.php and 1 other location - About 1 hr to fix
      includes/admin/class-llms-rest-admin-settings-api-keys.php on lines 53..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method register_routes has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {

        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
      Severity: Minor
      Found in includes/server/class-llms-rest-students-progress-controller.php - About 1 hr to fix

        Method prepare_collection_query_search_args has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepare_collection_query_search_args( $prepared, $request ) {

        // Search?
        if ( ! empty( $prepared['search'] ) ) {
        Severity: Minor
        Found in includes/abstracts/class-llms-rest-controller.php - About 1 hr to fix

          Method prepare_links has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function prepare_links( $enrollment, $request ) {

        $links = array(
            'self'       => array(
                'href' => rest_url(
          Severity: Minor
          Found in includes/server/class-llms-rest-enrollments-controller.php - About 1 hr to fix

            Function sanitize_post_statuses has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function sanitize_post_statuses( $statuses, $request, $parameter ) {
        $statuses = wp_parse_slug_list( $statuses );

        $attributes     = $request->get_attributes();
        $default_status = $attributes['args']['status']['default'];
            Severity: Minor
            Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function update_item has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function update_item( $request ) {

        $object = $this->get_object( (int) $request['id'] );
        if ( is_wp_error( $object ) ) {
            return $object;
            Severity: Minor
            Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method prepare_links has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function prepare_links( $section, $request ) {

        $links            = parent::prepare_links( $section, $request );
        $parent_course_id = $section->get( 'parent_course' );
            Severity: Minor
            Found in includes/server/class-llms-rest-sections-controller.php - About 1 hr to fix

              Method prepare_object_for_response has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function prepare_object_for_response( $object, $request ) {

        $object_id         = $object->get( 'id' );
        $password_required = post_password_required( $object_id );
        $password          = $object->get( 'password' );
              Severity: Minor
              Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

                Method prepare_collection_query_args has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function prepare_collection_query_args( $request ) {

        $query_args = parent::prepare_collection_query_args( $request );
        if ( is_wp_error( $query_args ) ) {
            return $query_args;
                Severity: Minor
                Found in includes/server/class-llms-rest-lessons-controller.php - About 1 hr to fix

                  Method prepare_links has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function prepare_links( $object, $request ) {

        $links = parent::prepare_links( $object, $request );

        $object_id = $object->get( 'id' );
                  Severity: Minor
                  Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

                    Method prepare_collection_query_args has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function prepare_collection_query_args( $request ) {

        $query_args = parent::prepare_collection_query_args( $request );
        if ( is_wp_error( $query_args ) ) {
            return $query_args;
                    Severity: Minor
                    Found in includes/server/class-llms-rest-sections-controller.php - About 1 hr to fix

                      Method prepare_item_for_database has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function prepare_item_for_database( $request ) {
        $prepared_item = parent::prepare_item_for_database( $request );
        $schema        = $this->get_item_schema();

        // Restriction action.
                      Severity: Minor
                      Found in includes/server/class-llms-rest-memberships-controller.php - About 1 hr to fix

                        Method sql_where has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function sql_where() {

        global $wpdb;

        $sql = 'WHERE 1';
                        Severity: Minor
                        Found in includes/class-llms-rest-api-keys-query.php - About 1 hr to fix

                          Function delete_item has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function delete_item( $request ) {

        $object   = $this->get_object( (int) $request['id'] );
        $response = new WP_REST_Response();
        $response->set_status( 204 );
                          Severity: Minor
                          Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function maybe_remove_filters_for_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function maybe_remove_filters_for_response( $object ) {

        $filters_to_be_removed = $this->get_filters_to_be_removed_for_response( $object );
        $filters_removed       = array();
                          Severity: Minor
                          Found in includes/abstracts/class-llms-rest-posts-controller.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method create_item has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function create_item( $request ) {

        $user_id = (int) $request['id'];
        $post_id = (int) $request['post_id'];
                          Severity: Minor
                          Found in includes/server/class-llms-rest-enrollments-controller.php - About 1 hr to fix

                            Method get_schema has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public static function get_schema( $schema, $collate ) {

        global $wpdb;

        $schema .= "
                            Severity: Minor
                            Found in includes/class-llms-rest-install.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language