Sign upLogin

hipay/hipay-wallet-cashout-mirakl-library

View on GitHub
Star

Showing 101 of 101 total issues

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        Factory $factory,
        VendorInterface $operatorAccount,
        VendorInterface $technicalAccount,
Severity: Major
Found in src/Cashout/Transfer.php - About 1 hr to fix

    Method createVendor has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $email,
        $walletId,
        $walletSpaceId,
        $identified,
        $miraklId,
    Severity: Major
    Found in src/Vendor/Processor.php - About 1 hr to fix

      Method create has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $email,
        $miraklId,
        $hipayId,
        $hipayUserSpaceId,
        $identified,
      Severity: Major
      Found in src/Vendor/Model/VendorManagerInterface.php - About 1 hr to fix

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        Factory $factory,
        OperationManager $operationManager,
        VendorManager $vendorManager,
        Severity: Major
        Found in src/Cashout/TransactionStatus.php - About 50 mins to fix

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        Factory $factory,
        OperationManager $operationManager,
        VendorManager $vendorManager,
          Severity: Major
          Found in src/Cashout/Withdraw.php - About 50 mins to fix

            Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        Factory $factory,
        OperationManager $operationManager,
        VendorManager $vendorManager,
            Severity: Major
            Found in src/Cashout/AbstractOperationProcessor.php - About 50 mins to fix

              Method createOperation has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $amount,
        $originAmount,
        DateTime $cycleDate,
        $paymentVoucher,
        $vendor,
              Severity: Major
              Found in src/Cashout/Initializer.php - About 50 mins to fix

                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        OperationManager $operationManager,
        VendorManagerInterface $vendorManager,
        LogVendorsManagerInterface $logVendorManager,
                Severity: Major
                Found in src/Notification/Handler.php - About 50 mins to fix

                  Method setNewStatus has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $operationId,
        $operation,
        $successStatus,
        $failStatus,
        $validatedStatus,
                  Severity: Major
                  Found in src/Cashout/TransactionStatus.php - About 50 mins to fix

                    Method getInvoices has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            DateTime $startDate = null,
        DateTime $endDate = null,
        $max = self::MIRAKL_API_MAX_PAGINATE,
        $offset = self::MIRAKL_API_DEFAULT_OFFSET_PAGINATE,
        $shopId = null,
                    Severity: Major
                    Found in src/Api/Mirakl.php - About 50 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              try {
            $result = $this->executeRest($command);
        } catch (HipayRestResponseException $e) {

            if ($e->getResponse()->getStatusCode() == '401') {
                      Severity: Minor
                      Found in src/Api/HiPay.php and 1 other location - About 50 mins to fix
                      src/Api/HiPay.php on lines 684..700

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              try {
            $result = $this->executeRest($command);
        } catch (HipayRestResponseException $e) {
            /** retro compatible if old account */
            if ($e->getResponse()->getStatusCode() == '401') {
                      Severity: Minor
                      Found in src/Api/HiPay.php and 1 other location - About 50 mins to fix
                      src/Api/HiPay.php on lines 572..589

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function transfer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function transfer(OperationInterface $operation)
    {
        try {
            $vendor = $this->getVendor($operation);
                      Severity: Minor
                      Found in src/Cashout/Transfer.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function disableVendor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function disableVendor($vendorData)
    {

        $vendor = $this->vendorManager->findByMiraklId($vendorData['shop_id']);
        $logVendor = $this->logVendorManager->findByMiraklId($vendorData['shop_id']);
                      Severity: Minor
                      Found in src/Vendor/Processor.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method other has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              $amount,
        $currency,
        $label,
        $hipayId,
        $date,
                      Severity: Minor
                      Found in src/Notification/Handler.php - About 45 mins to fix

                        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                $md5string,
        $callback_salt,
        $hipayId,
        $message = '',
        $code = 0,
                        Severity: Minor
                        Found in src/Exception/ChecksumFailedException.php - About 45 mins to fix

                          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  $miraklId,
        $operation,
        $amount,
        $balance,
        $code = 0,
                          Severity: Minor
                          Found in src/Exception/WrongWalletBalance.php - About 45 mins to fix

                            Method create has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function create($miraklId, $hipayId, $paymentVoucher, $amount, $originAmount, $balance);
                            Severity: Minor
                            Found in src/Notification/Model/LogOperationsManagerInterface.php - About 45 mins to fix

                              Method uploadDocument has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      $userSpaceId,
        $accountId,
        $documentType,
        $fileName,
        \DateTime $validityDate = null,
                              Severity: Minor
                              Found in src/Api/HiPay.php - About 45 mins to fix

                                Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        EventDispatcherInterface $dispatcherInterface,
        LoggerInterface $logger,
        ApiFactory $factory,
        VendorManagerInterface $vendorManager,
        DocumentManagerInterface $documentManager,
                                Severity: Minor
                                Found in src/Vendor/Processor.php - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language