Sign upLogin

honeybee/trellis

View on GitHub
Star

Showing 223 of 223 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    protected $metadata_options = [
        self::OPTION_METADATA_ALLOWED_KEYS,
        self::OPTION_METADATA_ALLOWED_VALUES,
        self::OPTION_METADATA_ALLOWED_PAIRS,
        self::OPTION_METADATA_VALUE_TYPE,
Severity: Major
Found in src/Runtime/Attribute/Image/ImageRule.php and 1 other location - About 4 hrs to fix
src/Runtime/Attribute/Asset/AssetRule.php on lines 214..246

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 175.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method execute has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_array($value)) {
            $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
            return false;
Severity: Major
Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 4 hrs to fix

    DataGenerator has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DataGenerator
{
    protected $faker;

    protected $locale;
    Severity: Minor
    Found in src/Sham/DataGenerator.php - About 3 hrs to fix

      File UrlRule.php has 323 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace Trellis\Runtime\Validator\Rule\Type;

use Trellis\Common\Error\RuntimeException;
      Severity: Minor
      Found in src/Runtime/Validator/Rule/Type/UrlRule.php - About 3 hrs to fix

        Method execute has 92 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_string($value)) {
            $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
            return false;
        Severity: Major
        Found in src/Runtime/Validator/Rule/Type/SanitizedFilenameRule.php - About 3 hrs to fix

          Function getUsedEmbedDefinitions has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getUsedEmbedDefinitions(EntityTypeDefinition $type_definition)
    {
        $embed_types_definitions_list = new EntityTypeDefinitionList();
        $embed_type_attributes = $type_definition->getAttributes()->filterByType('embedded-entity-list');
          Severity: Minor
          Found in src/CodeGen/Schema/EntityTypeSchema.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getUsedReferenceDefinitions has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getUsedReferenceDefinitions(EntityTypeDefinition $type_definition)
    {
        $reference_definitions_list = new EntityTypeDefinitionList();
        $reference_attributes = $type_definition->getAttributes()->filterByType('entity-reference-list');
        foreach ($reference_attributes as $reference_attribute) {
          Severity: Minor
          Found in src/CodeGen/Schema/EntityTypeSchema.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function execute($value, EntityInterface $entity = null)
    {
        $default_timezone = new DateTimeZone(
            $this->getOption(
                self::OPTION_INTERNAL_TIMEZONE_NAME,
          Severity: Minor
          Found in src/Runtime/Validator/Rule/Type/TimestampRule.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_string($value)) {
            $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
            return false;
          Severity: Minor
          Found in src/Runtime/Validator/Rule/Type/SanitizedFilenameRule.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 85 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function execute($value, EntityInterface $entity = null)
    {
        if ($value === '') {
            $value = $this->getOption(
                AttributeInterface::OPTION_NULL_VALUE,
          Severity: Major
          Found in src/Runtime/Validator/Rule/Type/FloatRule.php - About 3 hrs to fix

            Function execute has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function execute($values, EntityInterface $entity = null)
    {
        if (!is_array($values)) {
            $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
            return false;
            Severity: Minor
            Found in src/Runtime/Attribute/IntegerList/IntegerListRule.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Entity has 27 functions (exceeds 20 allowed). Consider refactoring.
            Open

            abstract class Entity extends BaseObject implements EntityInterface, ValueChangedListenerInterface, JsonSerializable
{
    /**
     * Holds the entity's type.
     *
            Severity: Minor
            Found in src/Runtime/Entity/Entity.php - About 3 hrs to fix

              File ImageRule.php has 293 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

namespace Trellis\Runtime\Attribute\Image;

use Exception;
              Severity: Minor
              Found in src/Runtime/Attribute/Image/ImageRule.php - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php

namespace Trellis\Common\Collection;

use Trellis\Common\Error\InvalidTypeException;
                Severity: Major
                Found in src/Common/Collection/TypedMap.php and 1 other location - About 3 hrs to fix
                src/Common/Collection/TypedList.php on lines 1..35

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 142.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php

namespace Trellis\Common\Collection;

use Trellis\Common\Error\InvalidTypeException;
                Severity: Major
                Found in src/Common/Collection/TypedList.php and 1 other location - About 3 hrs to fix
                src/Common/Collection/TypedMap.php on lines 1..35

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 142.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method execute has 72 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function execute($value, EntityInterface $entity = null)
    {
        $default_timezone = new DateTimeZone(
            $this->getOption(
                self::OPTION_INTERNAL_TIMEZONE_NAME,
                Severity: Major
                Found in src/Runtime/Validator/Rule/Type/TimestampRule.php - About 2 hrs to fix

                  File AssetRule.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

namespace Trellis\Runtime\Attribute\Asset;

use Exception;
                  Severity: Minor
                  Found in src/Runtime/Attribute/Asset/AssetRule.php - About 2 hrs to fix

                    Function createComplexValue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function createComplexValue(AttributeInterface $attribute, array $options = array())
    {
        $values = array();
        $value_holder = $attribute->createValueHolder();
        $value_type = $value_holder->getValueType();
                    Severity: Minor
                    Found in src/Sham/DataGenerator.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
                    $this->throwError('non_assoc_array', [ 'value' => $value ], IncidentInterface::CRITICAL);
                    return false;
                }
                    Severity: Major
                    Found in src/Runtime/Attribute/Image/ImageRule.php and 2 other locations - About 2 hrs to fix
                    src/Runtime/Attribute/Asset/AssetRule.php on lines 251..262
                    src/Runtime/Attribute/HtmlLink/HtmlLinkRule.php on lines 140..151

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 136.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
                    $this->throwError('non_assoc_array', [ 'value' => $value ], IncidentInterface::CRITICAL);
                    return false;
                }
                    Severity: Major
                    Found in src/Runtime/Attribute/Asset/AssetRule.php and 2 other locations - About 2 hrs to fix
                    src/Runtime/Attribute/HtmlLink/HtmlLinkRule.php on lines 140..151
                    src/Runtime/Attribute/Image/ImageRule.php on lines 262..273

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 136.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language